feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Add fallback finder for file paths in issues pane

Browse Source 
The more specific output parsers often fail to resolve relative file
paths, so add a fallback that attempts to find the corresponding file in
the current session.
A follow-up patch should add support for manual ambiguity resolving.

Change-Id: If0aecbab0f3bf1aa779f4a538076c87ae6bf22d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-02-25 14:21:42 +01:00
parent 2b1b00d0e6
commit f3778d77fe
7 changed files with 147 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/plugins/projectexplorer/taskmodel.cpp
View File

@@ -25,11 +25,13 @@
#include "taskmodel.h"
#include "fileinsessionfinder.h"
#include "task.h"
#include "taskhub.h"
#include <utils/qtcassert.h>
#include <QFileInfo>
#include <QFontMetrics>
#include <algorithm>
@@ -102,8 +104,14 @@ bool sortById(const Task &task, unsigned int id)
return task.taskId < id;
}
void TaskModel::addTask(const Task &task)
void TaskModel::addTask(const Task &t)
{
Task task = t;
if (!task.file.isEmpty() && !task.file.toFileInfo().isAbsolute()) {
const Utils::FileName fullFilePath = findFileInSession(task.file);
if (!fullFilePath.isEmpty())
task.file = fullFilePath;
}
Q_ASSERT(m_categories.keys().contains(task.category));
CategoryData &data = m_categories[task.category];
CategoryData &global = m_categories[Core::Id()];
@@ -117,17 +125,18 @@ void TaskModel::addTask(const Task &task)
endInsertRows();
}
void TaskModel::removeTask(const Task &task)
void TaskModel::removeTask(unsigned int id)
{
int index = m_tasks.indexOf(task);
if (index >= 0) {
for (int index = 0; index < m_tasks.length(); ++index) {
if (m_tasks.at(index).taskId != id)
continue;
const Task &t = m_tasks.at(index);
beginRemoveRows(QModelIndex(), index, index);
m_categories[task.category].removeTask(t);
m_categories[t.category].removeTask(t);
m_categories[Core::Id()].removeTask(t);
m_tasks.removeAt(index);
endRemoveRows();
break;
}
}