forked from qt-creator/qt-creator
ProjectExplorer: Simplify BuildStepFactory
De-QObject-ify class, tr contexts are now the product's
context, which was the case in some BuildStepFactories already,
and is current state in {Run,DeployConfiguration}Factory.
One spurious object name removed.
De-virtualize canHandle(), it was never overloaded and is not
intended to be overloaded anymore.
Remove unused clone() function.
Change-Id: Iff7fba5f707505f868f94458084a18650535fa23
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
@@ -832,7 +832,7 @@ bool QbsBuildStepConfigWidget::validateProperties(Utils::FancyLineEdit *edit, QS
|
||||
QbsBuildStepFactory::QbsBuildStepFactory()
|
||||
{
|
||||
registerStep<QbsBuildStep>(Constants::QBS_BUILDSTEP_ID);
|
||||
setDisplayName(tr("Qbs Build"));
|
||||
setDisplayName(QbsBuildStep::tr("Qbs Build"));
|
||||
setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_BUILD);
|
||||
setSupportedConfiguration(Constants::QBS_BC_ID);
|
||||
setSupportedProjectType(Constants::PROJECT_ID);
|
||||
|
||||
@@ -143,8 +143,6 @@ private:
|
||||
|
||||
class QbsBuildStepFactory : public ProjectExplorer::BuildStepFactory
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
QbsBuildStepFactory();
|
||||
};
|
||||
|
||||
@@ -295,7 +295,7 @@ QbsCleanStepFactory::QbsCleanStepFactory()
|
||||
registerStep<QbsCleanStep>(Constants::QBS_CLEANSTEP_ID);
|
||||
setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN);
|
||||
setSupportedConfiguration(Constants::QBS_BC_ID);
|
||||
setDisplayName(tr("Qbs Clean"));
|
||||
setDisplayName(QbsCleanStep::tr("Qbs Clean"));
|
||||
}
|
||||
|
||||
} // namespace Internal
|
||||
|
||||
@@ -114,8 +114,6 @@ private:
|
||||
|
||||
class QbsCleanStepFactory : public ProjectExplorer::BuildStepFactory
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
QbsCleanStepFactory();
|
||||
};
|
||||
|
||||
@@ -338,7 +338,7 @@ QbsInstallStepFactory::QbsInstallStepFactory()
|
||||
setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY);
|
||||
setSupportedDeviceType(ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE);
|
||||
setSupportedProjectType(Constants::PROJECT_ID);
|
||||
setDisplayName(tr("Qbs Install"));
|
||||
setDisplayName(QbsInstallStep::tr("Qbs Install"));
|
||||
}
|
||||
|
||||
} // namespace Internal
|
||||
|
||||
@@ -119,8 +119,6 @@ private:
|
||||
|
||||
class QbsInstallStepFactory : public ProjectExplorer::BuildStepFactory
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
QbsInstallStepFactory();
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user