diff --git a/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp b/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp index b1bc7994375..7e2efa3844c 100644 --- a/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp +++ b/src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp @@ -82,7 +82,7 @@ void QmlMainFileAspect::addToLayout(LayoutBuilder &builder) connect(m_fileListCombo, QOverload::of(&QComboBox::activated), this, &QmlMainFileAspect::setMainScript); - builder.addItems(QmlProjectRunConfiguration::tr("Main QML file:"), m_fileListCombo.data()); + builder.addItems(tr("Main QML file:"), m_fileListCombo.data()); } void QmlMainFileAspect::toMap(QVariantMap &map) const @@ -92,8 +92,7 @@ void QmlMainFileAspect::toMap(QVariantMap &map) const void QmlMainFileAspect::fromMap(const QVariantMap &map) { - m_scriptFile = map.value(Constants::QML_MAINSCRIPT_KEY, - M_CURRENT_FILE).toString(); + m_scriptFile = map.value(Constants::QML_MAINSCRIPT_KEY, M_CURRENT_FILE).toString(); if (m_scriptFile == M_CURRENT_FILE) setScriptSource(FileInEditor); diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp index 2edfc2d7164..5afb957789c 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp +++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp @@ -27,6 +27,7 @@ #include "qmlproject.h" #include "qmlprojectmanagerconstants.h" #include "qmlmainfileaspect.h" +#include "qmlmainfileaspect.h" #include #include @@ -58,9 +59,30 @@ using namespace QtSupport; using namespace Utils; namespace QmlProjectManager { +namespace Internal { // QmlProjectRunConfiguration +class QmlProjectRunConfiguration final : public RunConfiguration +{ + Q_DECLARE_TR_FUNCTIONS(QmlProjectManager::QmlProjectRunConfiguration) + +public: + QmlProjectRunConfiguration(Target *target, Core::Id id); + +private: + Runnable runnable() const final; + QString disabledReason() const final; + bool isEnabled() const final; + + QString mainScript() const; + Utils::FilePath qmlScenePath() const; + QString commandLineArguments() const; + + BaseStringAspect *m_qmlViewerAspect = nullptr; + QmlMainFileAspect *m_qmlMainFileAspect = nullptr; +}; + QmlProjectRunConfiguration::QmlProjectRunConfiguration(Target *target, Id id) : RunConfiguration(target, id) { @@ -203,7 +225,7 @@ QString QmlProjectRunConfiguration::mainScript() const return m_qmlMainFileAspect->mainScript(); } -namespace Internal { +// QmlProjectRunConfigurationFactory QmlProjectRunConfigurationFactory::QmlProjectRunConfigurationFactory() : FixedRunConfigurationFactory(QmlProjectRunConfiguration::tr("QML Scene"), false) diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h index afb16ddbb7a..48a87564573 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h +++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h @@ -25,40 +25,12 @@ #pragma once -#include "qmlprojectmanager_global.h" - #include -namespace ProjectExplorer { -class BaseStringAspect; -} namespace QmlProjectManager { - -class QmlMainFileAspect; - -class QMLPROJECTMANAGER_EXPORT QmlProjectRunConfiguration : public ProjectExplorer::RunConfiguration -{ - Q_OBJECT - -public: - QmlProjectRunConfiguration(ProjectExplorer::Target *target, Core::Id id); - -private: - ProjectExplorer::Runnable runnable() const final; - QString disabledReason() const final; - bool isEnabled() const final; - - QString mainScript() const; - Utils::FilePath qmlScenePath() const; - QString commandLineArguments() const; - - ProjectExplorer::BaseStringAspect *m_qmlViewerAspect = nullptr; - QmlMainFileAspect *m_qmlMainFileAspect = nullptr; -}; - namespace Internal { -class QmlProjectRunConfigurationFactory : public ProjectExplorer::FixedRunConfigurationFactory +class QmlProjectRunConfigurationFactory final : public ProjectExplorer::FixedRunConfigurationFactory { public: QmlProjectRunConfigurationFactory();