feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Meson: Inline mesonbuildsettingswidget file pair into buildconfiguration

Browse Source 
Less code, leaner header.

Change-Id: Ibc018a60434f5dfeb67a7a77192c30e4cefeea96
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
hjk
2023-06-13 12:44:56 +02:00
parent b37b94f0e5
commit f489a3e4d5
6 changed files with 246 additions and 303 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
src/plugins/mesonprojectmanager/mesonbuildconfiguration.h
View File

@@ -1,71 +1,15 @@
// Copyright (C) 2020 Alexis Jeandet.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#pragma once
#include <projectexplorer/buildconfiguration.h>
#include <projectexplorer/target.h>
namespace MesonProjectManager {
namespace Internal {
namespace MesonProjectManager::Internal {
enum class MesonBuildType { plain, debug, debugoptimized, release, minsize, custom };
const QHash<QString, MesonBuildType> buildTypesByName = {{"plain", MesonBuildType::plain},
{"debug", MesonBuildType::debug},
{"debugoptimized",
MesonBuildType::debugoptimized},
{"release", MesonBuildType::release},
{"minsize", MesonBuildType::minsize},
{"custom", MesonBuildType::custom}};
inline QString mesonBuildTypeName(MesonBuildType type)
{
return buildTypesByName.key(type, "custom");
}
inline QString mesonBuildTypeDisplayName(MesonBuildType type)
{
switch (type) {
case MesonBuildType::plain:
return {"Plain"};
case MesonBuildType::debug:
return {"Debug"};
case MesonBuildType::debugoptimized:
return {"Debug With Optimizations"};
case MesonBuildType::release:
return {"Release"};
case MesonBuildType::minsize:
return {"Minimum Size"};
default:
return {"Custom"};
}
}
inline MesonBuildType mesonBuildType(const QString &typeName)
{
return buildTypesByName.value(typeName, MesonBuildType::custom);
}
inline ProjectExplorer::BuildConfiguration::BuildType buildType(MesonBuildType type)
{
switch (type) {
case MesonBuildType::plain:
return ProjectExplorer::BuildConfiguration::Unknown;
case MesonBuildType::debug:
return ProjectExplorer::BuildConfiguration::Debug;
case MesonBuildType::debugoptimized:
return ProjectExplorer::BuildConfiguration::Profile;
case MesonBuildType::release:
return ProjectExplorer::BuildConfiguration::Release;
case MesonBuildType::minsize:
return ProjectExplorer::BuildConfiguration::Release;
default:
return ProjectExplorer::BuildConfiguration::Unknown;
}
}
class MesonBuildSystem;
class MesonTools;
class MesonBuildConfiguration final : public ProjectExplorer::BuildConfiguration
{
@@ -74,12 +18,6 @@ public:
MesonBuildConfiguration(ProjectExplorer::Target *target, Utils::Id id);
~MesonBuildConfiguration() final;
static Utils::FilePath shadowBuildDirectory(
const Utils::FilePath &projectFilePath,
const ProjectExplorer::Kit *k,
const QString &bcName,
ProjectExplorer::BuildConfiguration::BuildType buildType);
ProjectExplorer::BuildSystem *buildSystem() const final;
void build(const QString &target);
@@ -106,5 +44,4 @@ public:
MesonBuildConfigurationFactory();
};
} // namespace Internal
} // namespace MesonProjectManager
} // MesonProjectManager::Internal