From f491d93d2a2c95aded5fa11a31fc4e97fcc43c83 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Wed, 13 Sep 2023 10:29:05 +0200 Subject: [PATCH] CppEditor: remove superfluous locker in model manager This locker potentially results in a freeze since the called projectPart might require to lock for writing, which is not possible if the read locker is still there. Additionally there is nothing we would need the lock for in projectPartFromDependencies. Change-Id: If957edfb4ebc45e18141cb14a63bf9567242cc48 Reviewed-by: Marcus Tillmanns --- src/plugins/cppeditor/cppmodelmanager.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/plugins/cppeditor/cppmodelmanager.cpp b/src/plugins/cppeditor/cppmodelmanager.cpp index 231740899be..cc08724373d 100644 --- a/src/plugins/cppeditor/cppmodelmanager.cpp +++ b/src/plugins/cppeditor/cppmodelmanager.cpp @@ -1660,7 +1660,6 @@ QList CppModelManager::projectPartFromDependencies( QSet parts; const FilePaths deps = snapshot().filesDependingOn(fileName); - QReadLocker locker(&d->m_projectLock); for (const FilePath &dep : deps) parts.unite(Utils::toSet(projectPart(dep)));