feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Always seed pseudo-random number generator

Browse Source 
qrand() is used in several places, but it is only seeded in ToolSettings

Change-Id: I72ed3b96315081384c63572566d31dea1a8f8b69
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Orgad Shaneh
2013-02-28 11:42:50 +02:00
committed by Orgad Shaneh
parent d101a3609c
commit f4a9f56e3e
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/coreplugin/toolsettings.cpp
View File

@@ -75,7 +75,6 @@ QWidget *ToolSettings::createPage(QWidget *parent)
static QString getUserFilePath(const QString &proposalFileName)
{
static bool seeded = false;
QDir resourceDir(ICore::userResourcePath());
if (!resourceDir.exists(QLatin1String("externaltools")))
resourceDir.mkpath(QLatin1String("externaltools"));
@@ -89,10 +88,6 @@ static QString getUserFilePath(const QString &proposalFileName)
if (count > 15)
return QString();
// add random number
if (!seeded) {
seeded = true;
qsrand(QTime::currentTime().msec());
}
int number = qrand() % 1000;
tryPath = newFilePath + QString::number(number) + suffix;
}