feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Terminal: Remove unnecessary destructor

Browse Source 
Calling Aggregate::remove is not necessary and led to a warning message.

Change-Id: I51cdd7bfa9bdda7a3ebedf6a86e48fe54fd8f3ef
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-05-05 10:02:02 +02:00
parent 84b2862058
commit f4abb1ec4a
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/terminal/terminalwidget.cpp
View File

@@ -128,13 +128,6 @@ TerminalWidget::TerminalWidget(QWidget *parent, const OpenTerminalParameters &op
m_aggregate->add(m_search.get()); m_aggregate->add(m_search.get());
} }
TerminalWidget::~TerminalWidget()
{
// The Aggregate stuff tries to do clever deletion of the children, but we
// we don't want that.
m_aggregate->remove(this);
}
void TerminalWidget::setupPty() void TerminalWidget::setupPty()
{ {
m_process = std::make_unique<Process>(); m_process = std::make_unique<Process>();

1
src/plugins/terminal/terminalwidget.h
View File

@@ -29,7 +29,6 @@ class TerminalWidget : public QAbstractScrollArea
public: public:
TerminalWidget(QWidget *parent = nullptr, TerminalWidget(QWidget *parent = nullptr,
const Utils::Terminal::OpenTerminalParameters &openParameters = {}); const Utils::Terminal::OpenTerminalParameters &openParameters = {});
~TerminalWidget() override;
void setFont(const QFont &font); void setFont(const QFont &font);