forked from qt-creator/qt-creator
ProjectExplorer: Rename BaseStringAspect::{f,setF}ileName
... to filePath and setFilePath. In line with Utils::FilePath. Change-Id: I7115b91876542629c3d61c8259bbd8d9f4022fc1 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -117,7 +117,7 @@ void QdbRunConfiguration::updateTargetInformation()
|
|||||||
const DeployableFile depFile = target()->deploymentData().deployableForLocalFile(localExecutable);
|
const DeployableFile depFile = target()->deploymentData().deployableForLocalFile(localExecutable);
|
||||||
|
|
||||||
aspect<ExecutableAspect>()->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
|
aspect<ExecutableAspect>()->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
|
||||||
aspect<SymbolFileAspect>()->setFileName(localExecutable);
|
aspect<SymbolFileAspect>()->setFilePath(localExecutable);
|
||||||
}
|
}
|
||||||
|
|
||||||
QString QdbRunConfiguration::defaultDisplayName() const
|
QString QdbRunConfiguration::defaultDisplayName() const
|
||||||
|
@@ -911,7 +911,7 @@ DebuggerRunTool::DebuggerRunTool(RunControl *runControl, AllowTerminal allowTerm
|
|||||||
m_runParameters.displayName = runControl->displayName();
|
m_runParameters.displayName = runControl->displayName();
|
||||||
|
|
||||||
if (auto symbolsAspect = runControl->aspect<SymbolFileAspect>())
|
if (auto symbolsAspect = runControl->aspect<SymbolFileAspect>())
|
||||||
m_runParameters.symbolFile = symbolsAspect->fileName();
|
m_runParameters.symbolFile = symbolsAspect->filePath();
|
||||||
if (auto terminalAspect = runControl->aspect<TerminalAspect>())
|
if (auto terminalAspect = runControl->aspect<TerminalAspect>())
|
||||||
m_runParameters.useTerminal = terminalAspect->useTerminal();
|
m_runParameters.useTerminal = terminalAspect->useTerminal();
|
||||||
|
|
||||||
|
@@ -51,7 +51,7 @@ NimCompilerCleanStep::NimCompilerCleanStep(BuildStepList *parentList)
|
|||||||
workingDirectory->setDisplayStyle(BaseStringAspect::LineEditDisplay);
|
workingDirectory->setDisplayStyle(BaseStringAspect::LineEditDisplay);
|
||||||
|
|
||||||
setSummaryUpdater([this, workingDirectory] {
|
setSummaryUpdater([this, workingDirectory] {
|
||||||
workingDirectory->setFileName(buildConfiguration()->buildDirectory());
|
workingDirectory->setFilePath(buildConfiguration()->buildDirectory());
|
||||||
return displayName();
|
return displayName();
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
@@ -126,14 +126,14 @@ Utils::FilePath BuildConfiguration::buildDirectory() const
|
|||||||
|
|
||||||
Utils::FilePath BuildConfiguration::rawBuildDirectory() const
|
Utils::FilePath BuildConfiguration::rawBuildDirectory() const
|
||||||
{
|
{
|
||||||
return m_buildDirectoryAspect->fileName();
|
return m_buildDirectoryAspect->filePath();
|
||||||
}
|
}
|
||||||
|
|
||||||
void BuildConfiguration::setBuildDirectory(const Utils::FilePath &dir)
|
void BuildConfiguration::setBuildDirectory(const Utils::FilePath &dir)
|
||||||
{
|
{
|
||||||
if (dir == m_buildDirectoryAspect->fileName())
|
if (dir == m_buildDirectoryAspect->filePath())
|
||||||
return;
|
return;
|
||||||
m_buildDirectoryAspect->setFileName(dir);
|
m_buildDirectoryAspect->setFilePath(dir);
|
||||||
emitBuildDirectoryChanged();
|
emitBuildDirectoryChanged();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -105,7 +105,7 @@ void ProcessStep::setupProcessParameters(ProcessParameters *pp)
|
|||||||
pp->setMacroExpander(bc ? bc->macroExpander() : Utils::globalMacroExpander());
|
pp->setMacroExpander(bc ? bc->macroExpander() : Utils::globalMacroExpander());
|
||||||
pp->setEnvironment(bc ? bc->environment() : Utils::Environment::systemEnvironment());
|
pp->setEnvironment(bc ? bc->environment() : Utils::Environment::systemEnvironment());
|
||||||
pp->setWorkingDirectory(Utils::FilePath::fromString(workingDirectory));
|
pp->setWorkingDirectory(Utils::FilePath::fromString(workingDirectory));
|
||||||
pp->setCommandLine({m_command->fileName(), m_arguments->value(), CommandLine::Raw});
|
pp->setCommandLine({m_command->filePath(), m_arguments->value(), CommandLine::Raw});
|
||||||
pp->resolveAll();
|
pp->resolveAll();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -153,12 +153,12 @@ void BaseStringAspect::toMap(QVariantMap &map) const
|
|||||||
d->m_checker->toMap(map);
|
d->m_checker->toMap(map);
|
||||||
}
|
}
|
||||||
|
|
||||||
FilePath BaseStringAspect::fileName() const
|
FilePath BaseStringAspect::filePath() const
|
||||||
{
|
{
|
||||||
return FilePath::fromString(d->m_value);
|
return FilePath::fromString(d->m_value);
|
||||||
}
|
}
|
||||||
|
|
||||||
void BaseStringAspect::setFileName(const FilePath &val)
|
void BaseStringAspect::setFilePath(const FilePath &val)
|
||||||
{
|
{
|
||||||
setValue(val.toString());
|
setValue(val.toString());
|
||||||
}
|
}
|
||||||
|
@@ -133,8 +133,8 @@ public:
|
|||||||
void fromMap(const QVariantMap &map) override;
|
void fromMap(const QVariantMap &map) override;
|
||||||
void toMap(QVariantMap &map) const override;
|
void toMap(QVariantMap &map) const override;
|
||||||
|
|
||||||
Utils::FilePath fileName() const;
|
Utils::FilePath filePath() const;
|
||||||
void setFileName(const Utils::FilePath &val);
|
void setFilePath(const Utils::FilePath &val);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
void update();
|
void update();
|
||||||
|
@@ -445,9 +445,9 @@ void ExecutableAspect::makeOverridable(const QString &overridingKey, const QStri
|
|||||||
FilePath ExecutableAspect::executable() const
|
FilePath ExecutableAspect::executable() const
|
||||||
{
|
{
|
||||||
if (m_alternativeExecutable && m_alternativeExecutable->isChecked())
|
if (m_alternativeExecutable && m_alternativeExecutable->isChecked())
|
||||||
return m_alternativeExecutable->fileName();
|
return m_alternativeExecutable->filePath();
|
||||||
|
|
||||||
return m_executable.fileName();
|
return m_executable.filePath();
|
||||||
}
|
}
|
||||||
|
|
||||||
void ExecutableAspect::addToConfigurationLayout(QFormLayout *layout)
|
void ExecutableAspect::addToConfigurationLayout(QFormLayout *layout)
|
||||||
|
@@ -261,7 +261,7 @@ void QnxAttachDebugSupport::showProcessesDialog()
|
|||||||
FilePath localExecutable = dlg.localExecutable();
|
FilePath localExecutable = dlg.localExecutable();
|
||||||
if (localExecutable.isEmpty()) {
|
if (localExecutable.isEmpty()) {
|
||||||
if (auto aspect = runConfig->aspect<SymbolFileAspect>())
|
if (auto aspect = runConfig->aspect<SymbolFileAspect>())
|
||||||
localExecutable = aspect->fileName();
|
localExecutable = aspect->filePath();
|
||||||
}
|
}
|
||||||
|
|
||||||
auto runControl = new RunControl(ProjectExplorer::Constants::DEBUG_RUN_MODE);
|
auto runControl = new RunControl(ProjectExplorer::Constants::DEBUG_RUN_MODE);
|
||||||
|
@@ -75,7 +75,7 @@ QnxRunConfiguration::QnxRunConfiguration(Target *target, Core::Id id)
|
|||||||
const DeployableFile depFile = target->deploymentData().deployableForLocalFile(localExecutable);
|
const DeployableFile depFile = target->deploymentData().deployableForLocalFile(localExecutable);
|
||||||
|
|
||||||
exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
|
exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
|
||||||
symbolsAspect->setFileName(localExecutable);
|
symbolsAspect->setFilePath(localExecutable);
|
||||||
|
|
||||||
emit enabledChanged();
|
emit enabledChanged();
|
||||||
};
|
};
|
||||||
|
@@ -85,7 +85,7 @@ MakeInstallStep::MakeInstallStep(BuildStepList *parent) : MakeStep(parent, stepI
|
|||||||
commandLineAspect->setLabelText(tr("Full command line:"));
|
commandLineAspect->setLabelText(tr("Full command line:"));
|
||||||
|
|
||||||
QTemporaryDir tmpDir;
|
QTemporaryDir tmpDir;
|
||||||
installRootAspect->setFileName(FilePath::fromString(tmpDir.path()));
|
installRootAspect->setFilePath(FilePath::fromString(tmpDir.path()));
|
||||||
const MakeInstallCommand cmd = target()->makeInstallCommand(tmpDir.path());
|
const MakeInstallCommand cmd = target()->makeInstallCommand(tmpDir.path());
|
||||||
QTC_ASSERT(!cmd.command.isEmpty(), return);
|
QTC_ASSERT(!cmd.command.isEmpty(), return);
|
||||||
makeAspect->setExecutable(cmd.command);
|
makeAspect->setExecutable(cmd.command);
|
||||||
@@ -188,7 +188,7 @@ void MakeInstallStep::stdError(const QString &line)
|
|||||||
|
|
||||||
FilePath MakeInstallStep::installRoot() const
|
FilePath MakeInstallStep::installRoot() const
|
||||||
{
|
{
|
||||||
return static_cast<BaseStringAspect *>(aspect(InstallRootAspectId))->fileName();
|
return static_cast<BaseStringAspect *>(aspect(InstallRootAspectId))->filePath();
|
||||||
}
|
}
|
||||||
|
|
||||||
bool MakeInstallStep::cleanInstallRoot() const
|
bool MakeInstallStep::cleanInstallRoot() const
|
||||||
@@ -205,7 +205,7 @@ void MakeInstallStep::updateCommandFromAspect()
|
|||||||
void MakeInstallStep::updateArgsFromAspect()
|
void MakeInstallStep::updateArgsFromAspect()
|
||||||
{
|
{
|
||||||
setUserArguments(QtcProcess::joinArgs(target()->makeInstallCommand(
|
setUserArguments(QtcProcess::joinArgs(target()->makeInstallCommand(
|
||||||
static_cast<BaseStringAspect *>(aspect(InstallRootAspectId))->fileName().toString())
|
static_cast<BaseStringAspect *>(aspect(InstallRootAspectId))->filePath().toString())
|
||||||
.arguments));
|
.arguments));
|
||||||
updateFullCommandLine();
|
updateFullCommandLine();
|
||||||
}
|
}
|
||||||
|
@@ -94,7 +94,7 @@ void RemoteLinuxRunConfiguration::updateTargetInformation()
|
|||||||
DeployableFile depFile = target()->deploymentData().deployableForLocalFile(localExecutable);
|
DeployableFile depFile = target()->deploymentData().deployableForLocalFile(localExecutable);
|
||||||
|
|
||||||
aspect<ExecutableAspect>()->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
|
aspect<ExecutableAspect>()->setExecutable(FilePath::fromString(depFile.remoteFilePath()));
|
||||||
aspect<SymbolFileAspect>()->setFileName(localExecutable);
|
aspect<SymbolFileAspect>()->setFilePath(localExecutable);
|
||||||
|
|
||||||
emit enabledChanged();
|
emit enabledChanged();
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user