feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CorePlugin: Remove foreach / Q_FOREACH usage mostly in dialogs

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: Iad47e9cb0b2fa7590dba2d26d0a33a83d2909bb7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Artem Sokolovskii
2022-05-02 17:25:11 +02:00
parent 33a385c4d6
commit f4e943bda3
15 changed files with 73 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/coreplugin/sidebarwidget.cpp
View File

@@ -90,7 +90,7 @@ SideBarWidget::SideBarWidget(SideBar *sideBar, const QString &id)
Utils::sort(titleList);
QString t = id;
if (!titleList.isEmpty()) {
foreach (const QString &itemTitle, titleList)
for (const QString &itemTitle : qAsConst(titleList))
m_comboBox->addItem(itemTitle, m_sideBar->idForTitle(itemTitle));
m_comboBox->setCurrentIndex(0);
@@ -139,7 +139,8 @@ void SideBarWidget::setCurrentItem(const QString &id)
m_currentItem->widget()->show();
// Add buttons and remember their actions for later removal
foreach (QToolButton *b, m_currentItem->createToolBarWidgets())
QList<QToolButton *> buttons = m_currentItem->createToolBarWidgets();
for (QToolButton *b : buttons)
m_addedToolBarActions.append(m_toolbar->insertWidget(m_splitAction, b));
}
@@ -153,7 +154,7 @@ void SideBarWidget::updateAvailableItems()
titleList.append(currentTitle);
Utils::sort(titleList);
foreach (const QString &itemTitle, titleList)
for (const QString &itemTitle : qAsConst(titleList))
m_comboBox->addItem(itemTitle, m_sideBar->idForTitle(itemTitle));
int idx = m_comboBox->findText(currentTitle);