From f52c1db02f751d0d00591126a37e2bd14c7e9364 Mon Sep 17 00:00:00 2001 From: Erik Verbruggen Date: Thu, 11 Sep 2014 11:02:05 +0200 Subject: [PATCH] Help: fix possible nullptr deref. Setting QTC_HELPVIEWER_BACKEND to "native" when the native backend is not compiled in, would result in a nullptr deref. Change-Id: I5618650e0c4ae1c986a54a46232e8f782e43f350 Reviewed-by: Eike Ziller --- src/plugins/help/helpplugin.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/plugins/help/helpplugin.cpp b/src/plugins/help/helpplugin.cpp index 5d0f9fdcfa1..f77eed732a0 100644 --- a/src/plugins/help/helpplugin.cpp +++ b/src/plugins/help/helpplugin.cpp @@ -566,6 +566,9 @@ HelpViewer *HelpPlugin::createHelpViewer(qreal zoom) if (backend.compare(QLatin1String("native"), Qt::CaseInsensitive) == 0) { #ifdef QTC_MAC_NATIVE_HELPVIEWER viewer = new MacWebKitHelpViewer(zoom); +#else + qWarning() << "native help viewer is requested, but was not enabled during compilation"; + viewer = new TextBrowserHelpViewer(zoom); #endif } else if (backend.compare(QLatin1String("textbrowser"), Qt::CaseInsensitive) == 0) { viewer = new TextBrowserHelpViewer(zoom);