feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Use override consistently

Browse Source 
clang-tidy fixes from modernize-use-override check.

Change-Id: I86854125710ee2a24f4b663546f87baafefb9679
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-07 15:06:00 +02:00
parent a939ec8244
commit f531f76d04
7 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/plugins/valgrind/valgrindsettings.h
View File

@@ -61,8 +61,8 @@ public:
ValgrindBaseSettings(ProjectExplorer::RunConfiguration *runConfiguration = nullptr);
void toMap(QVariantMap &map) const;
void fromMap(const QVariantMap &map);
void toMap(QVariantMap &map) const override;
void fromMap(const QVariantMap &map) override;
signals:
void changed(); // sent when multiple values have changed simulatenously (e.g. fromMap)
@@ -184,17 +184,17 @@ public:
ValgrindGlobalSettings();
QWidget *createConfigWidget(QWidget *parent) override;
void toMap(QVariantMap &map) const;
void fromMap(const QVariantMap &map);
void toMap(QVariantMap &map) const override;
void fromMap(const QVariantMap &map) override;
/*
* Global memcheck settings
*/
public:
QStringList suppressionFiles() const;
QStringList suppressionFiles() const override;
// in the global settings we change the internal list directly
void addSuppressionFiles(const QStringList &);
void removeSuppressionFiles(const QStringList &);
void addSuppressionFiles(const QStringList &) override;
void removeSuppressionFiles(const QStringList &) override;
// internal settings which don't require any UI
void setLastSuppressionDialogDirectory(const QString &directory);
@@ -242,17 +242,17 @@ public:
ValgrindProjectSettings(ProjectExplorer::RunConfiguration *runConfiguration);
QWidget *createConfigWidget(QWidget *parent) override;
void toMap(QVariantMap &map) const;
void fromMap(const QVariantMap &map);
void toMap(QVariantMap &map) const override;
void fromMap(const QVariantMap &map) override;
/**
* Per-project memcheck settings, saves a diff to the global suppression files list
*/
public:
QStringList suppressionFiles() const;
QStringList suppressionFiles() const override;
// in the project-specific settings we store a diff to the global list
void addSuppressionFiles(const QStringList &suppressions);
void removeSuppressionFiles(const QStringList &suppressions);
void addSuppressionFiles(const QStringList &suppressions) override;
void removeSuppressionFiles(const QStringList &suppressions) override;
private:
QStringList m_disabledGlobalSuppressionFiles;