forked from qt-creator/qt-creator
VcsBase: Add comments for translators
Change-Id: Ib805a1fe610fb9b6995ce628cf004cd0398e0bf3 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
committed by
Tobias Hunger
parent
7450a09af3
commit
f5498e9fdf
@@ -80,6 +80,7 @@ bool VcsConfigurationPageFactory::validateData(Id typeId, const QVariant &data,
|
|||||||
QTC_ASSERT(canCreate(typeId), return false);
|
QTC_ASSERT(canCreate(typeId), return false);
|
||||||
|
|
||||||
if (data.isNull() || data.type() != QVariant::Map) {
|
if (data.isNull() || data.type() != QVariant::Map) {
|
||||||
|
//: Do not translate "VcsConfiguration", because it is the id of a page.
|
||||||
*errorMessage = QCoreApplication::translate("ProjectExplorer::JsonWizard",
|
*errorMessage = QCoreApplication::translate("ProjectExplorer::JsonWizard",
|
||||||
"\"data\" must be a JSON object for \"VcsConfiguration\" pages.");
|
"\"data\" must be a JSON object for \"VcsConfiguration\" pages.");
|
||||||
return false;
|
return false;
|
||||||
@@ -88,6 +89,7 @@ bool VcsConfigurationPageFactory::validateData(Id typeId, const QVariant &data,
|
|||||||
QVariantMap tmp = data.toMap();
|
QVariantMap tmp = data.toMap();
|
||||||
const QString vcsId = tmp.value(QLatin1String("vcsId")).toString();
|
const QString vcsId = tmp.value(QLatin1String("vcsId")).toString();
|
||||||
if (vcsId.isEmpty()) {
|
if (vcsId.isEmpty()) {
|
||||||
|
//: Do not translate "VcsConfiguration", because it is the id of a page.
|
||||||
*errorMessage = QCoreApplication::translate("ProjectExplorer::JsonWizard",
|
*errorMessage = QCoreApplication::translate("ProjectExplorer::JsonWizard",
|
||||||
"\"VcsConfiguration\" page requires a \"vcsId\" set.");
|
"\"VcsConfiguration\" page requires a \"vcsId\" set.");
|
||||||
return false;
|
return false;
|
||||||
@@ -145,14 +147,17 @@ void VcsConfigurationPage::initializePage()
|
|||||||
{
|
{
|
||||||
if (!d->m_versionControlId.isEmpty()) {
|
if (!d->m_versionControlId.isEmpty()) {
|
||||||
auto jw = qobject_cast<JsonWizard *>(wizard());
|
auto jw = qobject_cast<JsonWizard *>(wizard());
|
||||||
if (!jw)
|
if (!jw) {
|
||||||
|
//: Do not translate "VcsConfiguration", because it is the id of a page.
|
||||||
emit reportError(tr("No version control set on \"VcsConfiguration\" page."));
|
emit reportError(tr("No version control set on \"VcsConfiguration\" page."));
|
||||||
|
}
|
||||||
|
|
||||||
const QString vcsId = jw ? jw->expander()->expand(d->m_versionControlId) : d->m_versionControlId;
|
const QString vcsId = jw ? jw->expander()->expand(d->m_versionControlId) : d->m_versionControlId;
|
||||||
|
|
||||||
d->m_versionControl = VcsManager::versionControl(Id::fromString(vcsId));
|
d->m_versionControl = VcsManager::versionControl(Id::fromString(vcsId));
|
||||||
if (!d->m_versionControl) {
|
if (!d->m_versionControl) {
|
||||||
emit reportError(
|
emit reportError(
|
||||||
|
//: Do not translate "VcsConfiguration", because it is the id of a page.
|
||||||
tr("\"vcsId\" (\"%1\") is invalid for \"VcsConfiguration\" page. "
|
tr("\"vcsId\" (\"%1\") is invalid for \"VcsConfiguration\" page. "
|
||||||
"Possible values are: %2.")
|
"Possible values are: %2.")
|
||||||
.arg(vcsId)
|
.arg(vcsId)
|
||||||
|
Reference in New Issue
Block a user