Clang: Test for file path RequestSourceLocationsForRenamingMessage

Change-Id: Ia384deb60e644d8894d7c56f81b3deb8b7706c11
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

src/libs/clangbackendipc/sourcelocationscontainer.h

@@ -105,6 +105,12 @@ public:
         return SourceLocationsContainer(Utils::clone(filePathHash), Utils::clone(sourceLocationContainers_));
     }
 
+
+    const std::unordered_map<uint, FilePath> &filePathsForTestOnly() const
+    {
+        return filePathHash;
+    }
+
 private:
     std::unordered_map<uint, FilePath> filePathHash;
     std::vector<V2::SourceLocationContainer> sourceLocationContainers_;

src/tools/clangrefactoringbackend/source/sourcelocationsutils.h

@@ -43,14 +43,26 @@
 namespace ClangBackEnd {
 
 inline
-Utils::SmallString absolutePath(const char *path)
+llvm::SmallString<256> absolutePath(const char *path)
 {
     llvm::SmallString<256> absolutePath(path);
 
     if (!llvm::sys::path::is_absolute(absolutePath))
         llvm::sys::fs::make_absolute(absolutePath);
 
-    return Utils::SmallString(absolutePath.begin(), absolutePath.end());
+    return absolutePath;
+}
+
+template <typename Container>
+Utils::SmallString fromNativePath(Container container)
+{
+    Utils::SmallString path(container.data(), container.size());
+
+#ifdef WIN32
+    std::replace(path.begin(), path.end(), '\\', '/');
+#endif
+
+    return path;
 }
 
 inline
@@ -65,12 +77,13 @@ void appendSourceLocationsToSourceLocationsContainer(
         clang::FullSourceLoc fullSourceLocation(sourceLocation, sourceManager);
         auto fileId = fullSourceLocation.getFileID();
         auto fileEntry = sourceManager.getFileEntryForID(fileId);
-        auto fileName = fileEntry->getName();
+        auto filePath = absolutePath(fileEntry->getName());
-        auto fileDirectoryPath = absolutePath(fileEntry->getDir()->getName());
+        auto fileName = llvm::sys::path::filename(filePath);
+        llvm::sys::path::remove_filename(filePath);
 
         sourceLocationsContainer.insertFilePath(fileId.getHashValue(),
-                                                std::move(fileDirectoryPath),
+                                                fromNativePath(filePath),
-                                                fileName);
+                                                fromNativePath(fileName));
         sourceLocationsContainer.insertSourceLocation(fileId.getHashValue(),
                                                       fullSourceLocation.getSpellingLineNumber(),
                                                       fullSourceLocation.getSpellingColumnNumber());

tests/unit/unittest/refactoringservertest.cpp

@@ -39,12 +39,15 @@ namespace {
 
 using testing::AllOf;
 using testing::Contains;
+using testing::Pair;
 using testing::PrintToString;
 using testing::Property;
+using testing::_;
 
 using ClangBackEnd::RequestSourceLocationsForRenamingMessage;
 using ClangBackEnd::SourceLocationsContainer;
 using ClangBackEnd::SourceLocationsForRenamingMessage;
+using ClangBackEnd::FilePath;
 
 MATCHER_P2(IsSourceLocation, line, column,
            std::string(negation ? "isn't" : "is")
@@ -83,9 +86,11 @@ TEST_F(RefactoringServer, RequestSourceLocationsForRenamingMessage)
                 sourceLocationsForRenamingMessage(
                     AllOf(Property(&SourceLocationsForRenamingMessage::symbolName, "v"),
                           Property(&SourceLocationsForRenamingMessage::sourceLocations,
-                                   Property(&SourceLocationsContainer::sourceLocationContainers,
+                                   AllOf(Property(&SourceLocationsContainer::sourceLocationContainers,
                                             AllOf(Contains(IsSourceLocation(1, 5)),
-                                                  Contains(IsSourceLocation(3, 9))))))))
+                                                  Contains(IsSourceLocation(3, 9)))),
+                                         Property(&SourceLocationsContainer::filePathsForTestOnly,
+                                                  Contains(Pair(_, FilePath(TESTDATA_DIR, "renamevariable.cpp")))))))))
         .Times(1);
 
     refactoringServer.requestSourceLocationsForRenamingMessage(std::move(requestSourceLocationsForRenamingMessage));