feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Dissolve VcsManager::registerVersionControl

Browse Source 
It's a somewhat unusual pattern, spelling it out will help
to move the vcs plugins setup closer to the now-usual pattern.

Change-Id: Ie7b70e52d75e34cd36b6a1d55ca868e3edab44a7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-01-21 18:04:49 +01:00
parent 5cda42020e
commit f5d4b65931
11 changed files with 26 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/vcsbase/vcsbaseplugin.h
View File

@@ -130,14 +130,6 @@ class VCSBASE_EXPORT VcsBasePlugin : public ExtensionSystem::IPlugin
protected:
explicit VcsBasePlugin();
template<class T, typename... Args>
T *initializeVcs(const Core::Context &context, Args&&... args)
{
T *vc = Core::VcsManager::registerVersionControl<T>(std::forward<Args>(args)...);
initializeVcs(vc, context);
return vc;
}
void extensionsInitialized() override;
public:
@@ -216,12 +208,12 @@ protected:
// Returns whether actions should be set up further.
bool enableMenuAction(ActionState as, QAction *in) const;
void initializeVcs(Core::IVersionControl *vc, const Core::Context &context);
private:
void slotSubmitEditorAboutToClose(VcsBaseSubmitEditor *submitEditor, bool *result);
void slotStateChanged(const VcsBase::Internal::State &s, Core::IVersionControl *vc);
void initializeVcs(Core::IVersionControl *vc, const Core::Context &context);
VcsBasePluginPrivate *d;
};