feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Nim: Remove unused method

Browse Source 
... and its associated attribute along the way since it is not needed any longer.

Change-Id: I25a8c5fd9ee45de10b3764805c4df0500a5fd6cf
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Bernhard Beschow
2020-12-17 11:36:58 +01:00
parent faec8f09cb
commit f607f125f1
2 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/nim/project/nimblebuildsystem.cpp
View File

@@ -153,11 +153,11 @@ void NimbleBuildSystem::updateProject()
const FilePath projectDir = projectDirectory(); const FilePath projectDir = projectDirectory();
const FilePath nimble = Nim::nimblePathFromKit(kit()); const FilePath nimble = Nim::nimblePathFromKit(kit());
m_metadata = parseMetadata(nimble.toString(), projectDir.toString()); const NimbleMetadata metadata = parseMetadata(nimble.toString(), projectDir.toString());
const FilePath binDir = projectDir.pathAppended(m_metadata.binDir); const FilePath binDir = projectDir.pathAppended(metadata.binDir);
const FilePath srcDir = projectDir.pathAppended("src"); const FilePath srcDir = projectDir.pathAppended("src");
QList<BuildTargetInfo> targets = Utils::transform(m_metadata.bin, [&](const QString &bin){ QList<BuildTargetInfo> targets = Utils::transform(metadata.bin, [&](const QString &bin){
BuildTargetInfo info = {}; BuildTargetInfo info = {};
info.displayName = bin; info.displayName = bin;
info.targetFilePath = binDir.pathAppended(bin); info.targetFilePath = binDir.pathAppended(bin);
@@ -187,11 +187,6 @@ std::vector<NimbleTask> NimbleBuildSystem::tasks() const
return m_tasks; return m_tasks;
} }
NimbleMetadata NimbleBuildSystem::metadata() const
{
return m_metadata;
}
void NimbleBuildSystem::saveSettings() void NimbleBuildSystem::saveSettings()
{ {
// only handles nimble specific settings - NimProjectScanner handles general settings // only handles nimble specific settings - NimProjectScanner handles general settings

2
src/plugins/nim/project/nimblebuildsystem.h
View File

@@ -61,7 +61,6 @@ public:
NimbleBuildSystem(ProjectExplorer::Target *target); NimbleBuildSystem(ProjectExplorer::Target *target);
std::vector<NimbleTask> tasks() const; std::vector<NimbleTask> tasks() const;
NimbleMetadata metadata() const;
signals: signals:
void tasksChanged(); void tasksChanged();
@@ -86,7 +85,6 @@ private:
void triggerParsing() final; void triggerParsing() final;
NimbleMetadata m_metadata;
std::vector<NimbleTask> m_tasks; std::vector<NimbleTask> m_tasks;
NimProjectScanner m_projectScanner; NimProjectScanner m_projectScanner;