Valgrind: Fix coding style issues.

Header specification, remove internal classes from exported
headers, fully qualify signals,slots.
This commit is contained in:
Friedemann Kleint
2011-03-08 13:56:52 +01:00
parent ecce5bca6f
commit f610bf4d45
47 changed files with 197 additions and 201 deletions

View File

@@ -41,10 +41,10 @@
#include <utils/qtcassert.h>
#include <QTcpServer>
#include <QTcpSocket>
#include <QEventLoop>
#include <QNetworkInterface>
#include <QtNetwork/QTcpServer>
#include <QtNetwork/QTcpSocket>
#include <QtNetwork/QNetworkInterface>
#include <QtCore/QEventLoop>
using namespace Valgrind::Memcheck;

View File

@@ -35,9 +35,9 @@
#include "valgrindprocess.h"
#include <QDebug>
#include <QEventLoop>
#include <QFileInfo>
#include <QtCore/QDebug>
#include <QtCore/QEventLoop>
#include <QtCore/QFileInfo>
namespace Valgrind {
namespace Internal {

View File

@@ -40,7 +40,7 @@
#include <utils/environment.h>
#include <QEventLoop>
#include <QtCore/QEventLoop>
using namespace Valgrind;

View File

@@ -36,7 +36,7 @@
#ifndef VALGRIND_RUNNER_H
#define VALGRIND_RUNNER_H
#include <QProcess>
#include <QtCore/QProcess>
#include "valgrind_global.h"

View File

@@ -36,8 +36,8 @@
#include "announcethread.h"
#include "frame.h"
#include <QSharedData>
#include <QVector>
#include <QtCore/QSharedData>
#include <QtCore/QVector>
#include <algorithm>

View File

@@ -38,7 +38,7 @@
#include "../valgrind_global.h"
#include <QSharedDataPointer>
#include <QtCore/QSharedDataPointer>
QT_BEGIN_NAMESPACE
template <typename T> class QVector;

View File

@@ -38,12 +38,12 @@
#include "stack.h"
#include "suppression.h"
#include <QSharedData>
#include <QString>
#include <QTextStream>
#include <QVector>
#include <QtCore/QSharedData>
#include <QtCore/QString>
#include <QtCore/QTextStream>
#include <QtCore/QVector>
#include <QtAlgorithms>
#include <QtCore/QtAlgorithms>
using namespace Valgrind;
using namespace Valgrind::XmlProtocol;

View File

@@ -38,8 +38,8 @@
#include "../valgrind_global.h"
#include <QMetaType>
#include <QSharedDataPointer>
#include <QtCore/QMetaType>
#include <QtCore/QSharedDataPointer>
QT_BEGIN_NAMESPACE
class QString;

View File

@@ -40,8 +40,8 @@
#include "modelhelpers.h"
#include <utils/qtcassert.h>
#include <QDir>
#include <QVector>
#include <QtCore/QDir>
#include <QtCore/QVector>
using namespace Valgrind;
using namespace Valgrind::XmlProtocol;

View File

@@ -38,8 +38,8 @@
#include "../valgrind_global.h"
#include <QAbstractItemModel>
#include <QSharedPointer>
#include <QtCore/QAbstractItemModel>
#include <QtCore/QSharedPointer>
namespace Valgrind {
namespace XmlProtocol {

View File

@@ -35,9 +35,8 @@
#include "frame.h"
#include <QString>
#include <QtAlgorithms>
#include <QtCore/QString>
#include <QtCore/QtAlgorithms>
using namespace Valgrind;
using namespace Valgrind::XmlProtocol;

View File

@@ -38,7 +38,7 @@
#include "../valgrind_global.h"
#include <QSharedDataPointer>
#include <QtCore/QSharedDataPointer>
namespace Valgrind {
namespace XmlProtocol {

View File

@@ -36,9 +36,9 @@
#include "stack.h"
#include "frame.h"
#include <QSharedData>
#include <QString>
#include <QVector>
#include <QtCore/QSharedData>
#include <QtCore/QString>
#include <QtCore/QVector>
#include <algorithm>

View File

@@ -38,7 +38,7 @@
#include "../valgrind_global.h"
#include <QSharedDataPointer>
#include <QtCore/QSharedDataPointer>
QT_BEGIN_NAMESPACE
template <typename T> class QVector;

View File

@@ -37,11 +37,12 @@
#include "error.h"
#include "frame.h"
#include "stack.h"
#include "modelhelpers.h"
#include <utils/qtcassert.h>
#include <QDir>
#include <QVector>
#include "modelhelpers.h"
#include <QtCore/QDir>
#include <QtCore/QVector>
using namespace Valgrind;
using namespace Valgrind::XmlProtocol;

View File

@@ -38,7 +38,7 @@
#include "../valgrind_global.h"
#include <QAbstractItemModel>
#include <QtCore/QAbstractItemModel>
namespace Valgrind {
namespace XmlProtocol {

View File

@@ -35,8 +35,8 @@
#include "status.h"
#include <QSharedData>
#include <QString>
#include <QtCore/QSharedData>
#include <QtCore/QString>
using namespace Valgrind;
using namespace Valgrind::XmlProtocol;

View File

@@ -38,8 +38,8 @@
#include "../valgrind_global.h"
#include <QMetaType>
#include <QSharedDataPointer>
#include <QtCore/QMetaType>
#include <QtCore/QSharedDataPointer>
QT_BEGIN_NAMESPACE
class QString;

View File

@@ -35,10 +35,10 @@
#include "suppression.h"
#include <QSharedData>
#include <QString>
#include <QVector>
#include <QTextStream>
#include <QtCore/QSharedData>
#include <QtCore/QString>
#include <QtCore/QVector>
#include <QtCore/QTextStream>
#include <algorithm>

View File

@@ -38,7 +38,7 @@
#include "../valgrind_global.h"
#include <QSharedDataPointer>
#include <QtCore/QSharedDataPointer>
QT_BEGIN_NAMESPACE
class QString;

View File

@@ -41,9 +41,9 @@
#include "suppression.h"
#include <utils/qtcassert.h>
#include <QMetaType>
#include <QThread>
#include <QSharedPointer>
#include <QtCore/QMetaType>
#include <QtCore/QThread>
#include <QtCore/QSharedPointer>
using namespace Valgrind;
using namespace Valgrind::XmlProtocol;

View File

@@ -38,7 +38,7 @@
#include "../valgrind_global.h"
#include <QObject>
#include <QtCore/QObject>
QT_BEGIN_NAMESPACE
class QIODevice;

View File

@@ -36,14 +36,14 @@
#ifndef ANALYZERCONSTANTS_H
#define ANALYZERCONSTANTS_H
#include <QtGlobal>
#include <QtCore/QtGlobal>
namespace Analyzer {
namespace Constants {
// modes and their priorities
const char * const MODE_ANALYZE = "Analyzer.Mode.Analyze";
const int P_MODE_ANALYZE = 60;
const int P_MODE_ANALYZE = 76;
// context
const char * const C_ANALYZEMODE = "Analyzer.AnalyzeMode";

View File

@@ -34,6 +34,7 @@
**************************************************************************/
#include "analyzermanager.h"
#include "analyzerconstants.h"
#include "ianalyzertool.h"
#include "analyzerplugin.h"
@@ -51,6 +52,9 @@
#include <coreplugin/actionmanager/actioncontainer.h>
#include <coreplugin/icore.h>
#include <coreplugin/uniqueidmanager.h>
#include <coreplugin/coreconstants.h>
#include <coreplugin/editormanager/editormanager.h>
#include <coreplugin/imode.h>
#include <projectexplorer/projectexplorerconstants.h>
#include <projectexplorer/projectexplorer.h>
@@ -69,23 +73,22 @@
#include <cmakeprojectmanager/cmakeprojectconstants.h>
#include <qt4projectmanager/qt4projectmanagerconstants.h>
#include <QHBoxLayout>
#include <QVBoxLayout>
#include <QDockWidget>
#include <QVariant>
#include <QAction>
#include <QMenu>
#include <QMenuBar>
#include <QToolButton>
#include <QComboBox>
#include <QStackedWidget>
#include <QDebug>
#include <QDialog>
#include <QApplication>
#include <QLabel>
#include <QCheckBox>
#include <QDialogButtonBox>
#include <QtCore/QVariant>
#include <QtCore/QDebug>
#include <QtGui/QHBoxLayout>
#include <QtGui/QVBoxLayout>
#include <QtGui/QDockWidget>
#include <QtGui/QAction>
#include <QtGui/QMenu>
#include <QtGui/QMenuBar>
#include <QtGui/QToolButton>
#include <QtGui/QComboBox>
#include <QtGui/QStackedWidget>
#include <QtGui/QDialog>
#include <QtGui/QApplication>
#include <QtGui/QLabel>
#include <QtGui/QCheckBox>
#include <QtGui/QDialogButtonBox>
using namespace Core;
using namespace Analyzer;
@@ -94,6 +97,20 @@ using namespace Analyzer::Internal;
namespace Analyzer {
namespace Internal {
class DockWidgetEventFilter : public QObject
{
Q_OBJECT
public:
explicit DockWidgetEventFilter(QObject *parent = 0) : QObject(parent) {}
signals:
void widgetResized();
protected:
virtual bool eventFilter(QObject *obj, QEvent *event);
};
bool DockWidgetEventFilter::eventFilter(QObject *obj, QEvent *event)
{
switch (event->type()) {
@@ -109,6 +126,44 @@ bool DockWidgetEventFilter::eventFilter(QObject *obj, QEvent *event)
// AnalyzerMode ////////////////////////////////////////////////////
class AnalyzerMode : public Core::IMode
{
Q_OBJECT
public:
AnalyzerMode(QObject *parent = 0)
: Core::IMode(parent)
, m_widget(0)
{}
~AnalyzerMode()
{
// Make sure the editor manager does not get deleted.
if (m_widget) {
delete m_widget;
m_widget = 0;
}
Core::EditorManager::instance()->setParent(0);
}
QString displayName() const { return tr("Analyze"); }
QIcon icon() const { return QIcon(":/images/analyzer_mode.png"); }
int priority() const { return Constants::P_MODE_ANALYZE; }
QWidget *widget() { return m_widget; }
QString id() const { return QLatin1String(Constants::MODE_ANALYZE); }
QString type() const { return Core::Constants::MODE_EDIT_TYPE; }
Core::Context context() const
{
return Core::Context(Core::Constants::C_EDITORMANAGER, Constants::C_ANALYZEMODE,
Core::Constants::C_NAVIGATION_PANE);
}
QString contextHelpId() const { return QString(); }
void setWidget(QWidget *widget) { m_widget = widget; }
private:
QWidget *m_widget;
};
} // namespace Internal
} // namespace Analyzer
@@ -181,8 +236,8 @@ AnalyzerManager::AnalyzerManagerPrivate::AnalyzerManagerPrivate(AnalyzerManager
{
m_runControlFactory = new AnalyzerRunControlFactory();
AnalyzerPlugin::instance()->addAutoReleasedObject(m_runControlFactory);
connect(m_runControlFactory, SIGNAL(runControlCreated(AnalyzerRunControl *)),
q, SLOT(runControlCreated(AnalyzerRunControl *)));
connect(m_runControlFactory, SIGNAL(runControlCreated(Analyzer::Internal::AnalyzerRunControl *)),
q, SLOT(runControlCreated(Analyzer::Internal::AnalyzerRunControl *)));
setupActions();
}
@@ -699,3 +754,5 @@ void AnalyzerManager::updateRunActions()
bool startEnabled = !d->m_currentRunControl && pe->canRun(project, Constants::MODE_ANALYZE);
d->m_startAction->setEnabled(startEnabled);
}
#include "analyzermanager.moc"

View File

@@ -37,14 +37,8 @@
#define ANALYZERMANAGER_H
#include "analyzerbase_global.h"
#include "analyzerconstants.h"
#include <coreplugin/coreconstants.h>
#include <coreplugin/editormanager/editormanager.h>
#include <coreplugin/imode.h>
#include <QObject>
#include <QIcon>
#include <QtCore/QObject>
QT_BEGIN_NAMESPACE
class QAction;
@@ -60,68 +54,10 @@ class FancyMainWindow;
}
namespace Analyzer {
class IAnalyzerTool;
namespace Internal {
class AnalyzerRunControl;
class DockWidgetEventFilter : public QObject
{
Q_OBJECT
public:
explicit DockWidgetEventFilter(QObject *parent = 0) : QObject(parent) {}
signals:
void widgetResized();
protected:
virtual bool eventFilter(QObject *obj, QEvent *event);
};
class AnalyzerMode : public Core::IMode
{
Q_OBJECT
public:
AnalyzerMode(QObject *parent = 0)
: Core::IMode(parent)
, m_widget(0)
{}
~AnalyzerMode()
{
// Make sure the editor manager does not get deleted.
if (m_widget) {
delete m_widget;
m_widget = 0;
}
Core::EditorManager::instance()->setParent(0);
}
QString displayName() const { return tr("Analyze"); }
QIcon icon() const { return QIcon(":/images/analyzer_mode.png"); }
int priority() const { return Constants::P_MODE_ANALYZE; }
QWidget *widget() { return m_widget; }
QString id() const { return QLatin1String(Constants::MODE_ANALYZE); }
QString type() const { return Core::Constants::MODE_EDIT_TYPE; }
Core::Context context() const
{
return Core::Context(Core::Constants::C_EDITORMANAGER, Constants::C_ANALYZEMODE,
Core::Constants::C_NAVIGATION_PANE);
}
QString contextHelpId() const { return QString(); }
void setWidget(QWidget *widget) { m_widget = widget; }
private:
QWidget *m_widget;
};
}
using Analyzer::Internal::AnalyzerRunControl;
} // namespace Internal
class ANALYZER_EXPORT AnalyzerManager : public QObject
{
@@ -167,10 +103,10 @@ private slots:
void toolSelected(int);
void toolSelected(QAction *);
void modeChanged(Core::IMode *mode);
void runControlCreated(AnalyzerRunControl *);
void runControlCreated(Analyzer::Internal::AnalyzerRunControl *);
void resetLayout();
void saveToolSettings(IAnalyzerTool *tool);
void loadToolSettings(IAnalyzerTool *tool);
void saveToolSettings(Analyzer::IAnalyzerTool *tool);
void loadToolSettings(Analyzer::IAnalyzerTool *tool);
void updateRunActions();
private:

View File

@@ -38,14 +38,15 @@
#include "analyzeroptionspage.h"
#include "analyzersettings.h"
#include <QCoreApplication>
#include <QLatin1String>
#include <QWidget>
#include <QDebug>
#include <QIcon>
#include <coreplugin/icore.h>
#include <QtCore/QCoreApplication>
#include <QtCore/QLatin1String>
#include <QtCore/QDebug>
#include <QtGui/QIcon>
#include <QtGui/QWidget>
using namespace Analyzer;
using namespace Analyzer::Internal;

View File

@@ -45,10 +45,10 @@
#include <projectexplorer/task.h>
#include <projectexplorer/taskhub.h>
#include <QtPlugin>
#include <QMessageBox>
#include <QMainWindow>
#include <QApplication>
#include <QtCore/QtPlugin>
#include <QtGui/QMessageBox>
#include <QtGui/QMainWindow>
#include <QtGui/QApplication>
using namespace Analyzer;
using namespace Analyzer::Internal;

View File

@@ -40,9 +40,9 @@
#include <utils/detailswidget.h>
#include <utils/qtcassert.h>
#include <QDebug>
#include <QGroupBox>
#include <QVBoxLayout>
#include <QtCore/QDebug>
#include <QtGui/QGroupBox>
#include <QtGui/QVBoxLayout>
using namespace Analyzer;
using namespace Analyzer::Internal;
@@ -82,6 +82,7 @@ void AnalyzerRunConfigWidget::setRunConfiguration(ProjectExplorer::RunConfigurat
QLayout* layout = m_detailsWidget->widget()->layout();
foreach(AbstractAnalyzerSubConfig *config, settings->subConfigs()) {
QGroupBox* box = new QGroupBox(config->displayName());
Q_UNUSED(box)
QWidget* widget = config->createConfigWidget(this);
layout->addWidget(widget);
}

View File

@@ -49,10 +49,10 @@
#include <projectexplorer/taskhub.h>
#include <coreplugin/ioutputpane.h>
#include <QDebug>
#include <QHBoxLayout>
#include <QLabel>
#include <QMessageBox>
#include <QtCore/QDebug>
#include <QtGui/QHBoxLayout>
#include <QtGui/QLabel>
#include <QtGui/QMessageBox>
using namespace Analyzer;
using namespace Analyzer::Internal;

View File

@@ -72,7 +72,7 @@ public:
ProjectExplorer::RunConfigWidget *createConfigurationWidget(RunConfiguration *runConfiguration);
signals:
void runControlCreated(AnalyzerRunControl *);
void runControlCreated(Analyzer::Internal::AnalyzerRunControl *);
};

View File

@@ -44,7 +44,7 @@
#include <valgrind/xmlprotocol/error.h>
#include <utils/qtcassert.h>
#include <QSettings>
#include <QtCore/QSettings>
using namespace Analyzer;
using namespace Analyzer::Internal;

View File

@@ -36,8 +36,8 @@
#ifndef ANALYZER_INTERNAL_ANALYZERSETTINGS_H
#define ANALYZER_INTERNAL_ANALYZERSETTINGS_H
#include <QObject>
#include <QVariant>
#include <QtCore/QObject>
#include <QtCore/QVariant>
#include "analyzerbase_global.h"

View File

@@ -40,8 +40,8 @@
#include <projectexplorer/task.h>
#include <QObject>
#include <QString>
#include <QtCore/QObject>
#include <QtCore/QString>
namespace ProjectExplorer {
class RunConfiguration;

View File

@@ -38,7 +38,7 @@
#include "analyzerbase_global.h"
#include <QObject>
#include <QtCore/QObject>
namespace ProjectExplorer {
class RunConfiguration;

View File

@@ -41,9 +41,9 @@
#include <utils/qtcassert.h>
#include <QStandardItemModel>
#include <QFileDialog>
#include <QDebug>
#include <QtGui/QStandardItemModel>
#include <QtGui/QFileDialog>
#include <QtCore/QDebug>
using namespace Analyzer::Internal;

View File

@@ -37,7 +37,7 @@
#ifndef ANALYZER_INTERNAL_MEMCHECKCONFIGWIDGET_H
#define ANALYZER_INTERNAL_MEMCHECKCONFIGWIDGET_H
#include <QWidget>
#include <QtGui/QWidget>
QT_BEGIN_NAMESPACE
class QStandardItemModel;

View File

@@ -41,8 +41,8 @@
#include "memchecktool.h"
#include "memchecksettings.h"
#include <QStringList>
#include <QtPlugin>
#include <QtCore/QStringList>
#include <QtCore/QtPlugin>
using namespace Analyzer;
using namespace Analyzer::Internal;

View File

@@ -73,21 +73,22 @@
#include <utils/styledbar.h>
#include <utils/qtcassert.h>
#include <QString>
#include <QLatin1String>
#include <QFileInfo>
#include <QDockWidget>
#include <QFile>
#include <QDir>
#include <QHBoxLayout>
#include <QComboBox>
#include <QLabel>
#include <QSpinBox>
#include <QAction>
#include <QMenu>
#include <QMessageBox>
#include <QToolButton>
#include <QCheckBox>
#include <QtCore/QString>
#include <QtCore/QLatin1String>
#include <QtCore/QFileInfo>
#include <QtCore/QFile>
#include <QtCore/QDir>
#include <QtGui/QDockWidget>
#include <QtGui/QHBoxLayout>
#include <QtGui/QComboBox>
#include <QtGui/QLabel>
#include <QtGui/QSpinBox>
#include <QtGui/QAction>
#include <QtGui/QMenu>
#include <QtGui/QMessageBox>
#include <QtGui/QToolButton>
#include <QtGui/QCheckBox>
#include <utils/stylehelper.h>
using namespace Analyzer;

View File

@@ -38,8 +38,8 @@
#include <analyzerbase/ianalyzertool.h>
#include <QSortFilterProxyModel>
#include <QSharedPointer>
#include <QtGui/QSortFilterProxyModel>
#include <QtCore/QSharedPointer>
QT_BEGIN_NAMESPACE
class QItemSelection;

View File

@@ -48,8 +48,8 @@
#include <utils/pathchooser.h>
#include <utils/qtcassert.h>
#include <QFile>
#include <QPushButton>
#include <QtCore/QFile>
#include <QtGui/QPushButton>
#include <valgrind/xmlprotocol/suppression.h>
#include <valgrind/xmlprotocol/errorlistmodel.h>

View File

@@ -37,7 +37,7 @@
#ifndef ANALYZER_VALGRIND_INTERNAL_SUPPRESSIONDIALOG_H
#define ANALYZER_VALGRIND_INTERNAL_SUPPRESSIONDIALOG_H
#include <QDialog>
#include <QtGui/QDialog>
#include <valgrind/xmlprotocol/error.h>

View File

@@ -39,7 +39,7 @@
#include "valgrindsettings.h"
#include <QDebug>
#include <QtCore/QDebug>
using namespace Analyzer::Internal;

View File

@@ -37,7 +37,7 @@
#ifndef ANALYZER_INTERNAL_VALGRINDCONFIGWIDGET_H
#define ANALYZER_INTERNAL_VALGRINDCONFIGWIDGET_H
#include <QWidget>
#include <QtGui/QWidget>
QT_BEGIN_NAMESPACE
namespace Ui {

View File

@@ -44,9 +44,9 @@
#include <valgrind/valgrindrunner.h>
#include <QString>
#include <QByteArray>
#include <QFutureInterface>
#include <QtCore/QString>
#include <QtCore/QByteArray>
#include <QtCore/QFutureInterface>
namespace Analyzer {

View File

@@ -40,7 +40,7 @@
#include <coreplugin/icore.h>
#include <utils/qtcassert.h>
#include <QSettings>
#include <QtCore/QSettings>
using namespace Analyzer::Internal;
using namespace Analyzer;

View File

@@ -40,8 +40,8 @@
#include "valgrindtoolbase_global.h"
#include <QObject>
#include <QVariant>
#include <QtCore/QObject>
#include <QtCore/QVariant>
namespace Analyzer {
namespace Internal {

View File

@@ -39,8 +39,8 @@
#include <analyzerbase/analyzersettings.h>
#include <QStringList>
#include <QtPlugin>
#include <QtCore/QStringList>
#include <QtCore/QtPlugin>
using namespace Analyzer;
using namespace Analyzer::Internal;