feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qbs: Remove QbsBuildConfiguration::emitBuildTypeChanged

Browse Source 
The base BuildConfiguration::buildType() is accessible, and does
not need the casts.

Change-Id: I74bf9636901b99e3bf24a1a2ec8f46aabe707fbb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-05-02 12:05:13 +02:00
parent fc11380e07
commit f6312282f7
3 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qbsprojectmanager/qbsbuildconfiguration.cpp
View File

@@ -220,11 +220,6 @@ QStringList QbsBuildConfiguration::products() const
return m_products; return m_products;
} }
void QbsBuildConfiguration::emitBuildTypeChanged()
{
emit buildTypeChanged();
}
QString QbsBuildConfiguration::configurationName() const QString QbsBuildConfiguration::configurationName() const
{ {
return m_configurationName->value(); return m_configurationName->value();

2
src/plugins/qbsprojectmanager/qbsbuildconfiguration.h
View File

@@ -69,8 +69,6 @@ public:
void setProducts(const QStringList &products); void setProducts(const QStringList &products);
QStringList products() const; QStringList products() const;
void emitBuildTypeChanged();
QString configurationName() const; QString configurationName() const;
QString equivalentCommandLine(const ProjectExplorer::BuildStep *buildStep) const; QString equivalentCommandLine(const ProjectExplorer::BuildStep *buildStep) const;

10
src/plugins/qbsprojectmanager/qbsbuildstep.cpp
View File

@@ -227,9 +227,8 @@ void QbsBuildStep::setQbsConfiguration(const QVariantMap &config)
if (tmp == m_qbsConfiguration) if (tmp == m_qbsConfiguration)
return; return;
m_qbsConfiguration = tmp; m_qbsConfiguration = tmp;
auto bc = static_cast<QbsBuildConfiguration *>(buildConfiguration()); if (ProjectExplorer::BuildConfiguration *bc = buildConfiguration())
if (bc) emit bc->buildTypeChanged();
bc->emitBuildTypeChanged();
emit qbsConfigurationChanged(); emit qbsConfigurationChanged();
} }
@@ -417,9 +416,8 @@ void QbsBuildStep::setBuildVariant(const QString &variant)
return; return;
m_qbsConfiguration.insert(Constants::QBS_CONFIG_VARIANT_KEY, variant); m_qbsConfiguration.insert(Constants::QBS_CONFIG_VARIANT_KEY, variant);
emit qbsConfigurationChanged(); emit qbsConfigurationChanged();
auto bc = static_cast<QbsBuildConfiguration *>(buildConfiguration()); if (ProjectExplorer::BuildConfiguration *bc = buildConfiguration())
if (bc) emit bc->buildTypeChanged();
bc->emitBuildTypeChanged();
} }
QString QbsBuildStep::profile() const QString QbsBuildStep::profile() const