feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix some code scanning issues.

Browse Source 
foreach()-Loops.
This commit is contained in:
Friedemann Kleint
2010-02-01 14:00:07 +01:00
parent 0f6551c43f
commit f672bff338
22 changed files with 48 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/help/filtersettingspage.cpp
View File

@@ -99,8 +99,8 @@ void FilterSettingsPage::updateFilterPage()
help.setupData();
m_filterMapBackup.clear();
const QStringList filters = help.customFilters();
foreach (const QString filter, filters) {
QStringList atts = help.filterAttributes(filter);
foreach (const QString &filter, filters) {
const QStringList atts = help.filterAttributes(filter);
m_filterMapBackup.insert(filter, atts);
if (!m_filterMap.contains(filter))
m_filterMap.insert(filter, atts);
@@ -108,8 +108,8 @@ void FilterSettingsPage::updateFilterPage()
m_ui.filterWidget->addItems(m_filterMap.keys());
foreach (const QString a, help.filterAttributes())
new QTreeWidgetItem(m_ui.attributeWidget, QStringList() << a);
foreach (const QString &a, help.filterAttributes())
new QTreeWidgetItem(m_ui.attributeWidget, QStringList(a));
if (m_filterMap.keys().count())
m_ui.filterWidget->setCurrentRow(0);
@@ -215,7 +215,7 @@ bool FilterSettingsPage::applyChanges()
}
}
if (changed) {
foreach (QString filter, m_removedFilters)
foreach (const QString &filter, m_removedFilters)
m_helpEngine->removeCustomFilter(filter);
QMapIterator<QString, QStringList> it(m_filterMap);
while (it.hasNext()) {