feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Add move contructors

Browse Source 
Because of adding a default destructor is removing the move construtor
we add default move contructor.

Change-Id: Ic253e3173956389b11c0aa04204ea27f00c0e9b3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Marco Bubke
2023-05-20 00:42:28 +02:00
parent be824148be
commit f68421a53f
4 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmldesigner/designercore/include/abstractproperty.h
View File

@@ -50,6 +50,10 @@ class QMLDESIGNERCORE_EXPORT AbstractProperty
public: public:
AbstractProperty() = default; AbstractProperty() = default;
AbstractProperty(const AbstractProperty &) = default;
AbstractProperty &operator=(const AbstractProperty &) = default;
AbstractProperty(AbstractProperty &&) = default;
AbstractProperty &operator=(AbstractProperty &&) noexcept = default;
~AbstractProperty(); ~AbstractProperty();
AbstractProperty(const AbstractProperty &property, AbstractView *view); AbstractProperty(const AbstractProperty &property, AbstractView *view);

4
src/plugins/qmldesigner/designercore/include/modelnode.h
View File

@@ -80,6 +80,10 @@ public:
ModelNode(); ModelNode();
ModelNode(const Internal::InternalNodePointer &internalNode, Model *model, const AbstractView *view); ModelNode(const Internal::InternalNodePointer &internalNode, Model *model, const AbstractView *view);
ModelNode(const ModelNode &modelNode, AbstractView *view); ModelNode(const ModelNode &modelNode, AbstractView *view);
ModelNode(const ModelNode &) = default;
ModelNode &operator=(const ModelNode &) = default;
ModelNode(ModelNode &&) = default;
ModelNode &operator=(ModelNode &&) noexcept = default;
~ModelNode(); ~ModelNode();
TypeName type() const; TypeName type() const;

1
src/plugins/qmldesigner/designercore/include/qmlmodelnodefacade.h
View File

@@ -20,7 +20,6 @@ public:
static bool isValidQmlModelNodeFacade(const ModelNode &modelNode); static bool isValidQmlModelNodeFacade(const ModelNode &modelNode);
virtual bool isValid() const; virtual bool isValid() const;
explicit operator bool() const { return isValid(); } explicit operator bool() const { return isValid(); }
virtual ~QmlModelNodeFacade();
QmlModelNodeFacade() = default; QmlModelNodeFacade() = default;
AbstractView *view() const; AbstractView *view() const;

2
src/plugins/qmldesigner/designercore/model/qmlmodelnodefacade.cpp
View File

@@ -29,8 +29,6 @@ const NodeInstanceView *QmlModelNodeFacade::nodeInstanceView() const
return nodeInstanceView(m_modelNode); return nodeInstanceView(m_modelNode);
} }
QmlModelNodeFacade::~QmlModelNodeFacade() = default;
bool QmlModelNodeFacade::hasModelNode() const bool QmlModelNodeFacade::hasModelNode() const
{ {
return m_modelNode.isValid(); return m_modelNode.isValid();