From f6c0e573bf5f80c1dc9671aa908a419b18a13f4d Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@theqtcompany.com>
Date: Tue, 25 Nov 2014 12:37:00 +0100
Subject: [PATCH] CppEditor: Use AsynchronousMessageBox

Event loops can lead to crashes so it is better to use a dialog which has
not it's own event loop.

Change-Id: I53b5dee15e7207df91df45fd531e4520d502481b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
---
 src/plugins/cppeditor/cppquickfixes.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/plugins/cppeditor/cppquickfixes.cpp b/src/plugins/cppeditor/cppquickfixes.cpp
index b00605055d1..d84f7f81baa 100644
--- a/src/plugins/cppeditor/cppquickfixes.cpp
+++ b/src/plugins/cppeditor/cppquickfixes.cpp
@@ -38,6 +38,7 @@
 #include "cppinsertvirtualmethods.h"
 
 #include <coreplugin/icore.h>
+#include <coreplugin/messagebox.h>
 
 #include <cpptools/cppclassesfilter.h>
 #include <cpptools/cppcodestylesettings.h>
@@ -62,7 +63,6 @@
 #include <QDir>
 #include <QFileInfo>
 #include <QInputDialog>
-#include <QMessageBox>
 #include <QSharedPointer>
 #include <QStack>
 #include <QTextCursor>
@@ -3187,10 +3187,9 @@ public:
             return QString();
 
         if (!isValidIdentifier(name)) {
-            QMessageBox::critical(0,
-                                  QCoreApplication::translate("QuickFix::ExtractFunction",
-                                                              "Extract Function Refactoring"),
-                                  QCoreApplication::translate("QuickFix::ExtractFunction",
+            Core::AsynchronousMessageBox::critical(QCoreApplication::translate("QuickFix::ExtractFunction",
+                                                                               "Extract Function Refactoring"),
+                                                   QCoreApplication::translate("QuickFix::ExtractFunction",
                                                               "Invalid function name"));
             return QString();
         }