From f729efe3df8ad3aee26d2902b107ea2a8fa4ce2b Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 19 Sep 2022 09:56:47 +0200 Subject: [PATCH] VcsCommand: Don't emit std channel signals when finished Conform to QtcProcess behavior and don't emit stdOutText() and stdErrText() on finished when progressive output is off. Use cleanedStdOut() / cleanedStdErr() getter instead. Change-Id: I2c416c0264f2203c7a9c73de900c12777f4fd3b3 Reviewed-by: Orgad Shaneh Reviewed-by: --- src/plugins/vcsbase/vcscommand.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/plugins/vcsbase/vcscommand.cpp b/src/plugins/vcsbase/vcscommand.cpp index 0e952a4d852..69b7c384f3e 100644 --- a/src/plugins/vcsbase/vcscommand.cpp +++ b/src/plugins/vcsbase/vcscommand.cpp @@ -262,11 +262,6 @@ void VcsCommandPrivate::processDone() startNextJob(); return; } - if (!m_progressiveOutput) { - emit q->stdOutText(m_stdOut); - if (!m_stdErr.isEmpty()) - emit q->stdErrText(m_stdErr); - } emit q->finished(success); if (!success) m_futureInterface.reportCanceled();