feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Make PathChooser::path() private

Browse Source 
Still registered as getter for the property.

Change-Id: I9a35bbe5f8bf4354670d09eba07288274eb7dd2b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2022-09-19 13:41:57 +02:00
parent 7f51ae7105
commit f736c23afc
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libs/utils/pathchooser.h
View File

@@ -128,9 +128,6 @@ public:
void setOpenTerminalHandler(const std::function<void()> &openTerminal); void setOpenTerminalHandler(const std::function<void()> &openTerminal);
std::function<void()> openTerminalHandler() const; std::function<void()> openTerminalHandler() const;
// Deprecated. Use filePath().toString() or better suitable conversions.
QString path() const { return filePath().toString(); }
// this sets the placeHolderText to defaultValue and enables to use this as // this sets the placeHolderText to defaultValue and enables to use this as
// input value during validation if the real value is empty // input value during validation if the real value is empty
// setting an empty QString will disable this and clear the placeHolderText // setting an empty QString will disable this and clear the placeHolderText
@@ -153,6 +150,10 @@ signals:
void returnPressed(); void returnPressed();
private: private:
// Deprecated, only used in property getter.
// Use filePath().toString() or better suitable conversions.
QString path() const { return filePath().toString(); }
bool validatePath(FancyLineEdit *edit, QString *errorMessage) const; bool validatePath(FancyLineEdit *edit, QString *errorMessage) const;
// Returns overridden title or the one from <title> // Returns overridden title or the one from <title>
QString makeDialogTitle(const QString &title); QString makeDialogTitle(const QString &title);