feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

IOptionsPage: replace virtual fuctions by data members

Browse Source 
Change-Id: I8297df85109b67b79f90c33263a5dc7b89efbb60
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
hjk
2012-05-22 11:17:13 +02:00
committed by Eike Ziller
parent 444445ceb3
commit f77cd29e54
101 changed files with 403 additions and 1542 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/plugins/debugger/cdb/cdboptionspage.cpp
View File

@@ -230,6 +230,13 @@ CdbOptionsPage::CdbOptionsPage() :
{
CdbOptionsPage::m_instance = this;
m_options->fromSettings(Core::ICore::settings());
setId(QLatin1String("F.Cda")); // before old CDB
setDisplayName(tr("CDB"));
setCategory(QLatin1String(Debugger::Constants::DEBUGGER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("Debugger",
Constants::DEBUGGER_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
}
CdbOptionsPage::~CdbOptionsPage()
@@ -237,31 +244,6 @@ CdbOptionsPage::~CdbOptionsPage()
CdbOptionsPage::m_instance = 0;
}
QString CdbOptionsPage::settingsId()
{
return QLatin1String("F.Cda"); // before old CDB
}
QString CdbOptionsPage::displayName() const
{
return tr("CDB");
}
QString CdbOptionsPage::category() const
{
return QLatin1String(Debugger::Constants::DEBUGGER_SETTINGS_CATEGORY);
}
QString CdbOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Debugger", Debugger::Constants::DEBUGGER_SETTINGS_TR_CATEGORY);
}
QIcon CdbOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Debugger::Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
}
QWidget *CdbOptionsPage::createPage(QWidget *parent)
{
m_widget = new CdbOptionsPageWidget(parent);

16
src/plugins/debugger/cdb/cdboptionspage.h
View File

@@ -102,18 +102,10 @@ public:
static CdbOptionsPage *instance();
// IOptionsPage
virtual QString id() const { return settingsId(); }
virtual QString displayName() const;
virtual QString category() const;
virtual QString displayCategory() const;
QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &) const;
static QString settingsId();
QWidget *createPage(QWidget *parent);
void apply();
void finish();
bool matches(const QString &) const;
QSharedPointer<CdbOptions> options() const { return m_options; }