feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

IOptionsPage: replace virtual fuctions by data members

Browse Source 
Change-Id: I8297df85109b67b79f90c33263a5dc7b89efbb60
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
hjk
2012-05-22 11:17:13 +02:00
committed by Eike Ziller
parent 444445ceb3
commit f77cd29e54
101 changed files with 403 additions and 1542 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/plugins/qmljstools/qmljscodestylesettingspage.cpp
View File

@@ -169,35 +169,11 @@ QmlJSCodeStyleSettingsPage::QmlJSCodeStyleSettingsPage(/*QSharedPointer<CppFileS
Core::IOptionsPage(parent),
m_pageTabPreferences(0)
{
}
QmlJSCodeStyleSettingsPage::~QmlJSCodeStyleSettingsPage()
{
}
QString QmlJSCodeStyleSettingsPage::id() const
{
return QLatin1String(Constants::QML_JS_CODE_STYLE_SETTINGS_ID);
}
QString QmlJSCodeStyleSettingsPage::displayName() const
{
return QCoreApplication::translate("QmlJSTools", Constants::QML_JS_CODE_STYLE_SETTINGS_NAME);
}
QString QmlJSCodeStyleSettingsPage::category() const
{
return QLatin1String(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML);
}
QString QmlJSCodeStyleSettingsPage::displayCategory() const
{
return QCoreApplication::translate("QmlJSEditor", QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML);
}
QIcon QmlJSCodeStyleSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(QmlDesigner::Constants::SETTINGS_CATEGORY_QML_ICON));
setId(QLatin1String(Constants::QML_JS_CODE_STYLE_SETTINGS_ID));
setDisplayName(QCoreApplication::translate("QmlJSTools", Constants::QML_JS_CODE_STYLE_SETTINGS_NAME));
setCategory(QLatin1String(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML));
setDisplayCategory(QCoreApplication::translate("QmlJSEditor", QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML));
setCategoryIcon(QLatin1String(QmlDesigner::Constants::SETTINGS_CATEGORY_QML_ICON));
}
QWidget *QmlJSCodeStyleSettingsPage::createPage(QWidget *parent)

20
src/plugins/qmljstools/qmljscodestylesettingspage.h
View File

@@ -61,10 +61,9 @@ class QmlJSCodeStylePreferencesWidget : public QWidget
public:
explicit QmlJSCodeStylePreferencesWidget(QWidget *parent = 0);
virtual ~QmlJSCodeStylePreferencesWidget();
~QmlJSCodeStylePreferencesWidget();
void setPreferences(TextEditor::ICodeStylePreferences *preferences);
QString searchKeywords() const;
private slots:
@@ -74,7 +73,6 @@ private slots:
void updatePreview();
private:
TextEditor::ICodeStylePreferences *m_preferences;
Ui::QmlJSCodeStyleSettingsPage *m_ui;
};
@@ -86,19 +84,11 @@ class QmlJSCodeStyleSettingsPage : public Core::IOptionsPage
public:
explicit QmlJSCodeStyleSettingsPage(QWidget *parent = 0);
~QmlJSCodeStyleSettingsPage();
virtual QString id() const;
virtual QString displayName() const;
virtual QString category() const;
virtual QString displayCategory() const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish() { }
virtual bool matches(const QString &) const;
QWidget *createPage(QWidget *parent);
void apply();
void finish() { }
bool matches(const QString &) const;
private:
QString m_searchKeywords;