IOptionsPage: replace virtual fuctions by data members

Change-Id: I8297df85109b67b79f90c33263a5dc7b89efbb60
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
hjk
2012-05-22 11:17:13 +02:00
committed by Eike Ziller
parent 444445ceb3
commit f77cd29e54
101 changed files with 403 additions and 1542 deletions

View File

@@ -40,10 +40,7 @@
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <QCoreApplication> #include <QCoreApplication>
#include <QLatin1String>
#include <QDebug> #include <QDebug>
#include <QIcon>
#include <QWidget> #include <QWidget>
using namespace Analyzer; using namespace Analyzer;
@@ -53,31 +50,11 @@ AnalyzerOptionsPage::AnalyzerOptionsPage(AbstractAnalyzerSubConfig *config, QObj
Core::IOptionsPage(parent), Core::IOptionsPage(parent),
m_config(config) m_config(config)
{ {
} setId(m_config->id());
setDisplayName(m_config->displayName());
QString AnalyzerOptionsPage::id() const setCategory(QLatin1String("T.Analyzer"));
{ setDisplayCategory(QCoreApplication::translate("Analyzer", "Analyzer"));
return m_config->id(); setCategoryIcon(QLatin1String(":/images/analyzer_category.png"));
}
QString AnalyzerOptionsPage::displayName() const
{
return m_config->displayName();
}
QString AnalyzerOptionsPage::category() const
{
return QLatin1String("T.Analyzer");
}
QString AnalyzerOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Analyzer", "Analyzer");
}
QIcon AnalyzerOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(":/images/analyzer_category.png"));
} }
QWidget *AnalyzerOptionsPage::createPage(QWidget *parent) QWidget *AnalyzerOptionsPage::createPage(QWidget *parent)

View File

@@ -50,13 +50,6 @@ class AnalyzerOptionsPage : public Core::IOptionsPage
public: public:
explicit AnalyzerOptionsPage(AbstractAnalyzerSubConfig *config, QObject *parent = 0); explicit AnalyzerOptionsPage(AbstractAnalyzerSubConfig *config, QObject *parent = 0);
// IOptionsPage implementation
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -33,11 +33,9 @@
#include "androidsettingspage.h" #include "androidsettingspage.h"
#include "androidsettingswidget.h" #include "androidsettingswidget.h"
#include "androidconstants.h" #include "androidconstants.h"
#include <QCoreApplication> #include <QCoreApplication>
#include <QIcon>
namespace Android { namespace Android {
namespace Internal { namespace Internal {
@@ -45,35 +43,12 @@ namespace Internal {
AndroidSettingsPage::AndroidSettingsPage(QObject *parent) AndroidSettingsPage::AndroidSettingsPage(QObject *parent)
: Core::IOptionsPage(parent) : Core::IOptionsPage(parent)
{ {
} setId(QLatin1String(Constants::ANDROID_SETTINGS_ID));
setDisplayName(tr("Android Configurations"));
AndroidSettingsPage::~AndroidSettingsPage() setCategory(QLatin1String(Constants::ANDROID_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Android",
} Constants::ANDROID_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(Constants::ANDROID_SETTINGS_CATEGORY_ICON));
QString AndroidSettingsPage::id() const
{
return QLatin1String(Constants::ANDROID_SETTINGS_ID);
}
QString AndroidSettingsPage::displayName() const
{
return tr("Android Configurations");
}
QString AndroidSettingsPage::category() const
{
return QLatin1String(Constants::ANDROID_SETTINGS_CATEGORY);
}
QString AndroidSettingsPage::displayCategory() const
{
return QCoreApplication::translate("Android", Constants::ANDROID_SETTINGS_TR_CATEGORY);
}
QIcon AndroidSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::ANDROID_SETTINGS_CATEGORY_ICON));
} }
bool AndroidSettingsPage::matches(const QString &searchKeyWord) const bool AndroidSettingsPage::matches(const QString &searchKeyWord) const

View File

@@ -43,19 +43,14 @@ class AndroidSettingsWidget;
class AndroidSettingsPage : public Core::IOptionsPage class AndroidSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit AndroidSettingsPage(QObject *parent = 0); explicit AndroidSettingsPage(QObject *parent = 0);
~AndroidSettingsPage();
virtual QString id() const; bool matches(const QString &searchKeyWord) const;
virtual QString displayName() const; QWidget *createPage(QWidget *parent);
virtual QString category() const; void apply();
virtual QString displayCategory() const; void finish();
virtual QIcon categoryIcon() const;
virtual bool matches(const QString &searchKeyWord) const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
private: private:
QString m_keywords; QString m_keywords;

View File

@@ -95,16 +95,8 @@ QString OptionsPageWidget::searchKeywords() const
OptionsPage::OptionsPage() OptionsPage::OptionsPage()
{ {
} setId(QLatin1String(VcsBase::Constants::VCS_ID_BAZAAR));
setDisplayName(tr("Bazaar"));
QString OptionsPage::id() const
{
return QLatin1String(VcsBase::Constants::VCS_ID_BAZAAR);
}
QString OptionsPage::displayName() const
{
return tr("Bazaar");
} }
QWidget *OptionsPage::createPage(QWidget *parent) QWidget *OptionsPage::createPage(QWidget *parent)

View File

@@ -67,8 +67,6 @@ class OptionsPage : public VcsBase::VcsBaseOptionsPage
public: public:
OptionsPage(); OptionsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();

View File

@@ -246,6 +246,13 @@ QString CMakeManager::qtVersionForQMake(const QString &qmakePath)
CMakeSettingsPage::CMakeSettingsPage() CMakeSettingsPage::CMakeSettingsPage()
: m_pathchooser(0) : m_pathchooser(0)
{ {
setId(QLatin1String("Z.CMake"));
setDisplayName(tr("CMake"));
setCategory(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("ProjectExplorer",
ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
m_userCmake.process = 0; m_userCmake.process = 0;
m_pathCmake.process = 0; m_pathCmake.process = 0;
m_userCmake.hasCodeBlocksMsvcGenerator = false; m_userCmake.hasCodeBlocksMsvcGenerator = false;
@@ -347,32 +354,6 @@ QString CMakeSettingsPage::findCmakeExecutable() const
return env.searchInPath(QLatin1String("cmake")); return env.searchInPath(QLatin1String("cmake"));
} }
QString CMakeSettingsPage::id() const
{
return QLatin1String("Z.CMake");
}
QString CMakeSettingsPage::displayName() const
{
return tr("CMake");
}
QString CMakeSettingsPage::category() const
{
return QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY);
}
QString CMakeSettingsPage::displayCategory() const
{
return QCoreApplication::translate("ProjectExplorer",
ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY);
}
QIcon CMakeSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
}
QWidget *CMakeSettingsPage::createPage(QWidget *parent) QWidget *CMakeSettingsPage::createPage(QWidget *parent)
{ {
QWidget *outerWidget = new QWidget(parent); QWidget *outerWidget = new QWidget(parent);

View File

@@ -110,26 +110,24 @@ struct CMakeValidator
class CMakeSettingsPage : public Core::IOptionsPage class CMakeSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
CMakeSettingsPage(); CMakeSettingsPage();
virtual ~CMakeSettingsPage(); ~CMakeSettingsPage();
virtual QString id() const;
virtual QString displayName() const;
virtual QString category() const;
virtual QString displayCategory() const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
virtual void apply(); void apply();
virtual void finish(); void finish();
QString cmakeExecutable() const; QString cmakeExecutable() const;
void setCMakeExecutable(const QString &executable); void setCMakeExecutable(const QString &executable);
bool isCMakeExecutableValid() const; bool isCMakeExecutableValid() const;
bool hasCodeBlocksMsvcGenerator() const; bool hasCodeBlocksMsvcGenerator() const;
private slots: private slots:
void userCmakeFinished(); void userCmakeFinished();
void pathCmakeFinished(); void pathCmakeFinished();
private: private:
void cmakeFinished(CMakeValidator *cmakeValidator) const; void cmakeFinished(CMakeValidator *cmakeValidator) const;
void saveSettings() const; void saveSettings() const;

View File

@@ -62,10 +62,6 @@ CommandMappings::CommandMappings(QObject *parent)
{ {
} }
CommandMappings::~CommandMappings()
{
}
// IOptionsPage // IOptionsPage
QWidget *CommandMappings::createPage(QWidget *parent) QWidget *CommandMappings::createPage(QWidget *parent)

View File

@@ -45,16 +45,7 @@ QT_END_NAMESPACE
namespace Core { namespace Core {
class Command; namespace Internal { namespace Ui { class CommandMappings; } }
namespace Internal {
namespace Ui { class CommandMappings; }
class ActionManagerPrivate;
class MainWindow;
}
class CORE_EXPORT CommandMappings : public Core::IOptionsPage class CORE_EXPORT CommandMappings : public Core::IOptionsPage
{ {
@@ -62,7 +53,6 @@ class CORE_EXPORT CommandMappings : public Core::IOptionsPage
public: public:
CommandMappings(QObject *parent = 0); CommandMappings(QObject *parent = 0);
~CommandMappings();
protected slots: protected slots:
void commandChanged(QTreeWidgetItem *current); void commandChanged(QTreeWidgetItem *current);

View File

@@ -35,13 +35,9 @@
#include <coreplugin/core_global.h> #include <coreplugin/core_global.h>
#include <QIcon>
#include <QObject> #include <QObject>
QT_BEGIN_NAMESPACE
class QIcon;
class QWidget;
QT_END_NAMESPACE
namespace Core { namespace Core {
class CORE_EXPORT IOptionsPage : public QObject class CORE_EXPORT IOptionsPage : public QObject
@@ -50,18 +46,30 @@ class CORE_EXPORT IOptionsPage : public QObject
public: public:
IOptionsPage(QObject *parent = 0) : QObject(parent) {} IOptionsPage(QObject *parent = 0) : QObject(parent) {}
virtual ~IOptionsPage() {}
virtual QString id() const = 0; QString id() const { return m_id; }
virtual QString displayName() const = 0; QString displayName() const { return m_displayName; }
virtual QString category() const = 0; QString category() const { return m_category; }
virtual QString displayCategory() const = 0; QString displayCategory() const { return m_displayCategory; }
virtual QIcon categoryIcon() const = 0; QIcon categoryIcon() const { return QIcon(m_categoryIcon); }
virtual bool matches(const QString & /* searchKeyWord*/) const { return false; } virtual bool matches(const QString & /* searchKeyWord*/) const { return false; }
virtual QWidget *createPage(QWidget *parent) = 0; virtual QWidget *createPage(QWidget *parent) = 0;
virtual void apply() = 0; virtual void apply() = 0;
virtual void finish() = 0; virtual void finish() = 0;
protected:
void setId(const QString &id) { m_id = id; }
void setDisplayName(const QString &displayName) { m_displayName = displayName; }
void setCategory(const QString &category) { m_category = category; }
void setDisplayCategory(const QString &displayCategory) { m_displayCategory = displayCategory; }
void setCategoryIcon(const QString &categoryIcon) { m_categoryIcon = categoryIcon; }
QString m_id;
QString m_displayName;
QString m_category;
QString m_displayCategory;
QString m_categoryIcon;
}; };
/* /*
@@ -78,13 +86,21 @@ class CORE_EXPORT IOptionsPageProvider : public QObject
public: public:
IOptionsPageProvider(QObject *parent = 0) : QObject(parent) {} IOptionsPageProvider(QObject *parent = 0) : QObject(parent) {}
virtual ~IOptionsPageProvider() {}
virtual QString category() const = 0; QString category() const { return m_category; }
virtual QString displayCategory() const = 0; QString displayCategory() const { return m_displayCategory; }
virtual QIcon categoryIcon() const = 0; QIcon categoryIcon() const { return QIcon(m_categoryIcon); }
virtual QList<IOptionsPage *> pages() const = 0; virtual QList<IOptionsPage *> pages() const = 0;
protected:
void setCategory(const QString &category) { m_category = category; }
void setDisplayCategory(const QString &displayCategory) { m_displayCategory = displayCategory; }
void setCategoryIcon(const QString &categoryIcon) { m_categoryIcon = categoryIcon; }
QString m_category;
QString m_displayCategory;
QString m_categoryIcon;
}; };
} // namespace Core } // namespace Core

View File

@@ -63,38 +63,12 @@ ShortcutSettings::ShortcutSettings(QObject *parent)
{ {
Core::Internal::ActionManagerPrivate *am = ActionManagerPrivate::instance(); Core::Internal::ActionManagerPrivate *am = ActionManagerPrivate::instance();
connect(am, SIGNAL(commandListChanged()), this, SLOT(initialize())); connect(am, SIGNAL(commandListChanged()), this, SLOT(initialize()));
}
ShortcutSettings::~ShortcutSettings() setId(QLatin1String(Core::Constants::SETTINGS_ID_SHORTCUTS));
{ setDisplayName(tr("Keyboard"));
} setCategory(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE));
setDisplayCategory(QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE));
// IOptionsPage setCategoryIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
QString ShortcutSettings::id() const
{
return QLatin1String(Core::Constants::SETTINGS_ID_SHORTCUTS);
}
QString ShortcutSettings::displayName() const
{
return tr("Keyboard");
}
QString ShortcutSettings::category() const
{
return QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE);
}
QString ShortcutSettings::displayCategory() const
{
return QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE);
}
QIcon ShortcutSettings::categoryIcon() const
{
return QIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
} }
QWidget *ShortcutSettings::createPage(QWidget *parent) QWidget *ShortcutSettings::createPage(QWidget *parent)

View File

@@ -64,14 +64,6 @@ class ShortcutSettings : public Core::CommandMappings
public: public:
ShortcutSettings(QObject *parent = 0); ShortcutSettings(QObject *parent = 0);
~ShortcutSettings();
// IOptionsPage
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();

View File

@@ -58,31 +58,11 @@ using namespace Core::Internal;
GeneralSettings::GeneralSettings(): GeneralSettings::GeneralSettings():
m_page(0), m_dialog(0) m_page(0), m_dialog(0)
{ {
} setId(QLatin1String(Core::Constants::SETTINGS_ID_ENVIRONMENT));
setDisplayName(tr("General"));
QString GeneralSettings::id() const setCategory(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE));
{ setDisplayCategory(QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE));
return QLatin1String(Core::Constants::SETTINGS_ID_ENVIRONMENT); setCategoryIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
}
QString GeneralSettings::displayName() const
{
return tr("General");
}
QString GeneralSettings::category() const
{
return QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE);
}
QString GeneralSettings::displayCategory() const
{
return QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE);
}
QIcon GeneralSettings::categoryIcon() const
{
return QIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
} }
static bool hasQmFilesForLocale(const QString &locale, const QString &creatorTrPath) static bool hasQmFilesForLocale(const QString &locale, const QString &creatorTrPath)

View File

@@ -54,11 +54,6 @@ class GeneralSettings : public IOptionsPage
public: public:
GeneralSettings(); GeneralSettings();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget* createPage(QWidget *parent); QWidget* createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -43,14 +43,11 @@
#include <extensionsystem/pluginmanager.h> #include <extensionsystem/pluginmanager.h>
#include <QCoreApplication> #include <QCoreApplication>
#include <QLatin1String>
#include <QStringList> #include <QStringList>
#include <QVector>
#include <QSet> #include <QSet>
#include <QScopedPointer> #include <QScopedPointer>
#include <QAbstractTableModel> #include <QAbstractTableModel>
#include <QHash> #include <QHash>
#include <QIcon>
#include <QTableWidgetItem> #include <QTableWidgetItem>
#include <QMessageBox> #include <QMessageBox>
#include <QtAlgorithms> #include <QtAlgorithms>
@@ -548,38 +545,20 @@ void MimeTypeSettingsPrivate::resetMimeTypes()
MimeTypeSettings::MimeTypeSettings(QObject *parent) MimeTypeSettings::MimeTypeSettings(QObject *parent)
: IOptionsPage(parent) : IOptionsPage(parent)
, d(new MimeTypeSettingsPrivate) , d(new MimeTypeSettingsPrivate)
{} {
setId(QLatin1String(Core::Constants::SETTINGS_ID_MIMETYPES));
setDisplayName(tr("MIME Types"));
setCategory(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE));
setDisplayCategory(QCoreApplication::translate("Core",
Core::Constants::SETTINGS_TR_CATEGORY_CORE));
setCategoryIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
}
MimeTypeSettings::~MimeTypeSettings() MimeTypeSettings::~MimeTypeSettings()
{ {
delete d; delete d;
} }
QString MimeTypeSettings::id() const
{
return QLatin1String(Core::Constants::SETTINGS_ID_MIMETYPES);
}
QString MimeTypeSettings::displayName() const
{
return tr("MIME Types");
}
QString MimeTypeSettings::category() const
{
return QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE);
}
QString MimeTypeSettings::displayCategory() const
{
return QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE);
}
QIcon MimeTypeSettings::categoryIcon() const
{
return QIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
}
bool MimeTypeSettings::matches(const QString &s) const bool MimeTypeSettings::matches(const QString &s) const
{ {
return d->m_keywords.contains(s, Qt::CaseInsensitive); return d->m_keywords.contains(s, Qt::CaseInsensitive);

View File

@@ -48,13 +48,7 @@ public:
MimeTypeSettings(QObject *parent = 0); MimeTypeSettings(QObject *parent = 0);
virtual ~MimeTypeSettings(); virtual ~MimeTypeSettings();
virtual QString id() const;
virtual QString displayName() const;
virtual QString category() const;
virtual QString displayCategory() const;
virtual QIcon categoryIcon() const;
virtual bool matches(const QString &s) const; virtual bool matches(const QString &s) const;
virtual QWidget *createPage(QWidget *parent); virtual QWidget *createPage(QWidget *parent);
virtual void apply(); virtual void apply();
virtual void finish(); virtual void finish();

View File

@@ -53,39 +53,11 @@ using namespace Core::Internal;
ToolSettings::ToolSettings(QObject *parent) : ToolSettings::ToolSettings(QObject *parent) :
IOptionsPage(parent) IOptionsPage(parent)
{ {
} setId(QLatin1String(Core::Constants::SETTINGS_ID_TOOLS));
setDisplayName(tr("External Tools"));
ToolSettings::~ToolSettings() setCategory(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE));
{ setDisplayCategory(QCoreApplication::translate("Core", Constants::SETTINGS_TR_CATEGORY_CORE));
} setCategoryIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
QString ToolSettings::id() const
{
return QLatin1String(Core::Constants::SETTINGS_ID_TOOLS);
}
QString ToolSettings::displayName() const
{
return tr("External Tools");
}
QString ToolSettings::category() const
{
return QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE);
}
QString ToolSettings::displayCategory() const
{
return QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE);
}
QIcon ToolSettings::categoryIcon() const
{
return QIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
} }

View File

@@ -45,17 +45,11 @@ class ExternalToolConfig;
class ToolSettings : public IOptionsPage class ToolSettings : public IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit ToolSettings(QObject *parent = 0); explicit ToolSettings(QObject *parent = 0);
~ToolSettings();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
bool matches(const QString & searchKeyWord) const; bool matches(const QString & searchKeyWord) const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -54,6 +54,12 @@ namespace CodePaster {
CodePasterSettingsPage::CodePasterSettingsPage() CodePasterSettingsPage::CodePasterSettingsPage()
{ {
setId(QLatin1String("C.CodePaster"));
setDisplayName(tr("CodePaster"));
setCategory(QLatin1String(Constants::CPASTER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("CodePaster",
Constants::CPASTER_SETTINGS_TR_CATEGORY));
m_settings = Core::ICore::settings(); m_settings = Core::ICore::settings();
if (m_settings) { if (m_settings) {
const QString keyRoot = QLatin1String(settingsGroupC) + QLatin1Char('/'); const QString keyRoot = QLatin1String(settingsGroupC) + QLatin1Char('/');
@@ -61,31 +67,6 @@ CodePasterSettingsPage::CodePasterSettingsPage()
} }
} }
QString CodePasterSettingsPage::id() const
{
return QLatin1String("C.CodePaster");
}
QString CodePasterSettingsPage::displayName() const
{
return tr("CodePaster");
}
QString CodePasterSettingsPage::category() const
{
return QLatin1String(Constants::CPASTER_SETTINGS_CATEGORY);
}
QString CodePasterSettingsPage::displayCategory() const
{
return QCoreApplication::translate("CodePaster", Constants::CPASTER_SETTINGS_TR_CATEGORY);
}
QIcon CodePasterSettingsPage::categoryIcon() const
{
return QIcon();
}
QWidget *CodePasterSettingsPage::createPage(QWidget *parent) QWidget *CodePasterSettingsPage::createPage(QWidget *parent)
{ {
QWidget *outerWidget = new QWidget(parent); QWidget *outerWidget = new QWidget(parent);

View File

@@ -48,17 +48,12 @@ class CodePasterSettingsPage : public Core::IOptionsPage
public: public:
CodePasterSettingsPage(); CodePasterSettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
QString hostName() const; QString hostName() const;
public slots: public slots:
void serverChanged(const QString &host); void serverChanged(const QString &host);

View File

@@ -101,31 +101,10 @@ FileShareProtocolSettingsPage::FileShareProtocolSettingsPage(const QSharedPointe
QObject *parent) : QObject *parent) :
Core::IOptionsPage(parent), m_settings(s), m_widget(0) Core::IOptionsPage(parent), m_settings(s), m_widget(0)
{ {
} setId(QLatin1String("X.FileSharePaster"));
setDisplayName(tr("Fileshare"));
QString FileShareProtocolSettingsPage::id() const setCategory(QLatin1String(Constants::CPASTER_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("CodePaster", Constants::CPASTER_SETTINGS_TR_CATEGORY));
return QLatin1String("X.FileSharePaster");
}
QString FileShareProtocolSettingsPage::displayName() const
{
return tr("Fileshare");
}
QString FileShareProtocolSettingsPage::category() const
{
return QLatin1String(Constants::CPASTER_SETTINGS_CATEGORY);
}
QString FileShareProtocolSettingsPage::displayCategory() const
{
return QCoreApplication::translate("CodePaster", Constants::CPASTER_SETTINGS_TR_CATEGORY);
}
QIcon FileShareProtocolSettingsPage::categoryIcon() const
{
return QIcon();
} }
QWidget *FileShareProtocolSettingsPage::createPage(QWidget *parent) QWidget *FileShareProtocolSettingsPage::createPage(QWidget *parent)

View File

@@ -72,19 +72,15 @@ public:
private: private:
Internal::Ui::FileShareProtocolSettingsWidget m_ui; Internal::Ui::FileShareProtocolSettingsWidget m_ui;
}; };
class FileShareProtocolSettingsPage : public Core::IOptionsPage class FileShareProtocolSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit FileShareProtocolSettingsPage(const QSharedPointer<FileShareProtocolSettings> &s, explicit FileShareProtocolSettingsPage(const QSharedPointer<FileShareProtocolSettings> &s,
QObject *parent = 0); QObject *parent = 0);
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }

View File

@@ -81,37 +81,18 @@ Settings SettingsWidget::settings()
SettingsPage::SettingsPage(const QSharedPointer<Settings> &settings) : SettingsPage::SettingsPage(const QSharedPointer<Settings> &settings) :
m_settings(settings), m_widget(0) m_settings(settings), m_widget(0)
{ {
setId(QLatin1String("A.General"));
setDisplayName(tr("General"));
setCategory(QLatin1String(Constants::CPASTER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("CodePaster",
Constants::CPASTER_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(Constants::SETTINGS_CATEGORY_CPASTER_ICON));
} }
SettingsPage::~SettingsPage() SettingsPage::~SettingsPage()
{ {
} }
QString SettingsPage::id() const
{
return QLatin1String("A.General");
}
QString SettingsPage::displayName() const
{
return tr("General");
}
QString SettingsPage::category() const
{
return QLatin1String(Constants::CPASTER_SETTINGS_CATEGORY);
}
QString SettingsPage::displayCategory() const
{
return QCoreApplication::translate("CodePaster", Constants::CPASTER_SETTINGS_TR_CATEGORY);
}
QIcon SettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::SETTINGS_CATEGORY_CPASTER_ICON));
}
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)
{ {
m_widget = new SettingsWidget(m_protocols, parent); m_widget = new SettingsWidget(m_protocols, parent);

View File

@@ -67,18 +67,12 @@ class SettingsPage : public Core::IOptionsPage
public: public:
explicit SettingsPage(const QSharedPointer<Settings> &settings); explicit SettingsPage(const QSharedPointer<Settings> &settings);
virtual ~SettingsPage(); ~SettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
virtual bool matches(const QString &) const; bool matches(const QString &) const;
void addProtocol(const QString& name); void addProtocol(const QString& name);

View File

@@ -51,6 +51,9 @@ CompletionSettingsPage::CompletionSettingsPage(QObject *parent)
{ {
if (QSettings *s = Core::ICore::settings()) if (QSettings *s = Core::ICore::settings())
m_commentsSettings.fromSettings(QLatin1String(CPPTOOLS_SETTINGSGROUP), s); m_commentsSettings.fromSettings(QLatin1String(CPPTOOLS_SETTINGSGROUP), s);
setId(QLatin1String("P.Completion"));
setDisplayName(tr("Completion"));
} }
CompletionSettingsPage::~CompletionSettingsPage() CompletionSettingsPage::~CompletionSettingsPage()
@@ -58,16 +61,6 @@ CompletionSettingsPage::~CompletionSettingsPage()
delete m_page; delete m_page;
} }
QString CompletionSettingsPage::id() const
{
return QLatin1String("P.Completion");
}
QString CompletionSettingsPage::displayName() const
{
return tr("Completion");
}
QWidget *CompletionSettingsPage::createPage(QWidget *parent) QWidget *CompletionSettingsPage::createPage(QWidget *parent)
{ {
QWidget *w = new QWidget(parent); QWidget *w = new QWidget(parent);

View File

@@ -55,13 +55,10 @@ public:
CompletionSettingsPage(QObject *parent); CompletionSettingsPage(QObject *parent);
~CompletionSettingsPage(); ~CompletionSettingsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
virtual bool matches(const QString &) const; bool matches(const QString &) const;
const CommentsSettings &commentsSettings() const; const CommentsSettings &commentsSettings() const;

View File

@@ -479,40 +479,15 @@ void CppCodeStylePreferencesWidget::setVisualizeWhitespace(bool on)
// ------------------ CppCodeStyleSettingsPage // ------------------ CppCodeStyleSettingsPage
CppCodeStyleSettingsPage::CppCodeStyleSettingsPage( CppCodeStyleSettingsPage::CppCodeStyleSettingsPage(QWidget *parent) :
QWidget *parent) :
Core::IOptionsPage(parent), Core::IOptionsPage(parent),
m_pageCppCodeStylePreferences(0) m_pageCppCodeStylePreferences(0)
{ {
} setId(QLatin1String(Constants::CPP_CODE_STYLE_SETTINGS_ID));
setDisplayName(QCoreApplication::translate("CppTools", Constants::CPP_CODE_STYLE_SETTINGS_NAME));
CppCodeStyleSettingsPage::~CppCodeStyleSettingsPage() setCategory(QLatin1String(Constants::CPP_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("CppTools", Constants::CPP_SETTINGS_TR_CATEGORY));
} setCategoryIcon(QLatin1String(Constants::SETTINGS_CATEGORY_CPP_ICON));
QString CppCodeStyleSettingsPage::id() const
{
return QLatin1String(Constants::CPP_CODE_STYLE_SETTINGS_ID);
}
QString CppCodeStyleSettingsPage::displayName() const
{
return QCoreApplication::translate("CppTools", Constants::CPP_CODE_STYLE_SETTINGS_NAME);
}
QString CppCodeStyleSettingsPage::category() const
{
return QLatin1String(Constants::CPP_SETTINGS_CATEGORY);
}
QString CppCodeStyleSettingsPage::displayCategory() const
{
return QCoreApplication::translate("CppTools", Constants::CPP_SETTINGS_TR_CATEGORY);
}
QIcon CppCodeStyleSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::SETTINGS_CATEGORY_CPP_ICON));
} }
QWidget *CppCodeStyleSettingsPage::createPage(QWidget *parent) QWidget *CppCodeStyleSettingsPage::createPage(QWidget *parent)

View File

@@ -100,18 +100,11 @@ class CppCodeStyleSettingsPage : public Core::IOptionsPage
public: public:
explicit CppCodeStyleSettingsPage(QWidget *parent = 0); explicit CppCodeStyleSettingsPage(QWidget *parent = 0);
~CppCodeStyleSettingsPage();
virtual QString id() const; QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish() { }
virtual QString displayCategory() const; bool matches(const QString &) const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish() { }
virtual bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -325,35 +325,11 @@ CppFileSettingsPage::CppFileSettingsPage(QSharedPointer<CppFileSettings> &settin
Core::IOptionsPage(parent), Core::IOptionsPage(parent),
m_settings(settings) m_settings(settings)
{ {
} setId(QLatin1String(Constants::CPP_FILE_SETTINGS_ID));
setDisplayName(QCoreApplication::translate("CppTools", Constants::CPP_FILE_SETTINGS_NAME));
CppFileSettingsPage::~CppFileSettingsPage() setCategory(QLatin1String(Constants::CPP_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("CppTools", Constants::CPP_SETTINGS_TR_CATEGORY));
} setCategoryIcon(QLatin1String(Constants::SETTINGS_CATEGORY_CPP_ICON));
QString CppFileSettingsPage::id() const
{
return QLatin1String(Constants::CPP_FILE_SETTINGS_ID);
}
QString CppFileSettingsPage::displayName() const
{
return QCoreApplication::translate("CppTools", Constants::CPP_FILE_SETTINGS_NAME);
}
QString CppFileSettingsPage::category() const
{
return QLatin1String(Constants::CPP_SETTINGS_CATEGORY);
}
QString CppFileSettingsPage::displayCategory() const
{
return QCoreApplication::translate("CppTools", Constants::CPP_SETTINGS_TR_CATEGORY);
}
QIcon CppFileSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::SETTINGS_CATEGORY_CPP_ICON));
} }
QWidget *CppFileSettingsPage::createPage(QWidget *parent) QWidget *CppFileSettingsPage::createPage(QWidget *parent)

View File

@@ -98,18 +98,11 @@ class CppFileSettingsPage : public Core::IOptionsPage
public: public:
explicit CppFileSettingsPage(QSharedPointer<CppFileSettings> &settings, explicit CppFileSettingsPage(QSharedPointer<CppFileSettings> &settings,
QObject *parent = 0); QObject *parent = 0);
virtual ~CppFileSettingsPage();
virtual QString id() const; QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish() { }
virtual QString displayCategory() const; bool matches(const QString &) const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish() { }
virtual bool matches(const QString &) const;
private: private:
const QSharedPointer<CppFileSettings> m_settings; const QSharedPointer<CppFileSettings> m_settings;

View File

@@ -94,14 +94,10 @@ QString SettingsPageWidget::searchKeywords() const
return rc; return rc;
} }
QString SettingsPage::id() const SettingsPage::SettingsPage()
{ {
return QLatin1String(VcsBase::Constants::VCS_ID_CVS); setId(QLatin1String(VcsBase::Constants::VCS_ID_CVS));
} setDisplayName(tr("CVS"));
QString SettingsPage::displayName() const
{
return tr("CVS");
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)

View File

@@ -72,10 +72,7 @@ class SettingsPage : public VcsBase::VcsBaseOptionsPage
Q_OBJECT Q_OBJECT
public: public:
SettingsPage() {} SettingsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();

View File

@@ -230,6 +230,13 @@ CdbOptionsPage::CdbOptionsPage() :
{ {
CdbOptionsPage::m_instance = this; CdbOptionsPage::m_instance = this;
m_options->fromSettings(Core::ICore::settings()); m_options->fromSettings(Core::ICore::settings());
setId(QLatin1String("F.Cda")); // before old CDB
setDisplayName(tr("CDB"));
setCategory(QLatin1String(Debugger::Constants::DEBUGGER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("Debugger",
Constants::DEBUGGER_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
} }
CdbOptionsPage::~CdbOptionsPage() CdbOptionsPage::~CdbOptionsPage()
@@ -237,31 +244,6 @@ CdbOptionsPage::~CdbOptionsPage()
CdbOptionsPage::m_instance = 0; CdbOptionsPage::m_instance = 0;
} }
QString CdbOptionsPage::settingsId()
{
return QLatin1String("F.Cda"); // before old CDB
}
QString CdbOptionsPage::displayName() const
{
return tr("CDB");
}
QString CdbOptionsPage::category() const
{
return QLatin1String(Debugger::Constants::DEBUGGER_SETTINGS_CATEGORY);
}
QString CdbOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Debugger", Debugger::Constants::DEBUGGER_SETTINGS_TR_CATEGORY);
}
QIcon CdbOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Debugger::Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
}
QWidget *CdbOptionsPage::createPage(QWidget *parent) QWidget *CdbOptionsPage::createPage(QWidget *parent)
{ {
m_widget = new CdbOptionsPageWidget(parent); m_widget = new CdbOptionsPageWidget(parent);

View File

@@ -102,18 +102,10 @@ public:
static CdbOptionsPage *instance(); static CdbOptionsPage *instance();
// IOptionsPage // IOptionsPage
virtual QString id() const { return settingsId(); } QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish();
virtual QString displayCategory() const; bool matches(const QString &) const;
QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &) const;
static QString settingsId();
QSharedPointer<CdbOptions> options() const { return m_options; } QSharedPointer<CdbOptions> options() const { return m_options; }

View File

@@ -152,36 +152,17 @@ void CommonOptionsPageWidget::setGlobalOptions(const GlobalDebuggerOptions &go)
CommonOptionsPage::CommonOptionsPage(const QSharedPointer<GlobalDebuggerOptions> &go) : CommonOptionsPage::CommonOptionsPage(const QSharedPointer<GlobalDebuggerOptions> &go) :
m_options(go) m_options(go)
{ {
setId(QLatin1String(DEBUGGER_COMMON_SETTINGS_ID));
setDisplayName(QCoreApplication::translate("Debugger", "General"));
setCategory(QLatin1String(DEBUGGER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("Debugger", DEBUGGER_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
} }
CommonOptionsPage::~CommonOptionsPage() CommonOptionsPage::~CommonOptionsPage()
{ {
} }
QString CommonOptionsPage::id() const
{
return _(DEBUGGER_COMMON_SETTINGS_ID);
}
QString CommonOptionsPage::displayName() const
{
return QCoreApplication::translate("Debugger", "General");
}
QString CommonOptionsPage::category() const
{
return _(DEBUGGER_SETTINGS_CATEGORY);
}
QString CommonOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Debugger", DEBUGGER_SETTINGS_TR_CATEGORY);}
QIcon CommonOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
}
void CommonOptionsPage::apply() void CommonOptionsPage::apply()
{ {
QTC_ASSERT(!m_widget.isNull() && !m_group.isNull(), return); QTC_ASSERT(!m_widget.isNull() && !m_group.isNull(), return);
@@ -220,34 +201,18 @@ bool CommonOptionsPage::matches(const QString &s) const
/////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////
// //
// DebuggingHelperOptionPage // LocalsAndExpressionsOptionsPage
// //
/////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////
QString LocalsAndExpressionsOptionsPage::id() const LocalsAndExpressionsOptionsPage::LocalsAndExpressionsOptionsPage()
{
return _("Z.LocalsAndExpressions");
}
QString LocalsAndExpressionsOptionsPage::displayName() const
{ {
setId(QLatin1String("Z.LocalsAndExpressions"));
//: '&&' will appear as one (one is marking keyboard shortcut) //: '&&' will appear as one (one is marking keyboard shortcut)
return QCoreApplication::translate("Debugger", "Locals && Expressions"); setDisplayName(QCoreApplication::translate("Debugger", "Locals && Expressions"));
} setCategory(QLatin1String(DEBUGGER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("Debugger", DEBUGGER_SETTINGS_TR_CATEGORY));
QString LocalsAndExpressionsOptionsPage::category() const setCategoryIcon(QLatin1String(DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
{
return _(DEBUGGER_SETTINGS_CATEGORY);
}
QString LocalsAndExpressionsOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Debugger", DEBUGGER_SETTINGS_TR_CATEGORY);
}
QIcon LocalsAndExpressionsOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
} }
void LocalsAndExpressionsOptionsPage::apply() void LocalsAndExpressionsOptionsPage::apply()

View File

@@ -73,14 +73,9 @@ class CommonOptionsPage : public Core::IOptionsPage
public: public:
explicit CommonOptionsPage(const QSharedPointer<GlobalDebuggerOptions> &go); explicit CommonOptionsPage(const QSharedPointer<GlobalDebuggerOptions> &go);
virtual ~CommonOptionsPage(); ~CommonOptionsPage();
// IOptionsPage // IOptionsPage
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
@@ -103,15 +98,9 @@ private:
class LocalsAndExpressionsOptionsPage : public Core::IOptionsPage class LocalsAndExpressionsOptionsPage : public Core::IOptionsPage
{ {
public: public:
LocalsAndExpressionsOptionsPage() {} LocalsAndExpressionsOptionsPage();
// IOptionsPage // IOptionsPage
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -257,31 +257,12 @@ public:
GdbOptionsPage::GdbOptionsPage() GdbOptionsPage::GdbOptionsPage()
: m_ui(0) : m_ui(0)
{ }
QString GdbOptionsPage::settingsId()
{ {
return QLatin1String("M.Gdb"); setId(QLatin1String("M.Gdb"));
} setDisplayName(tr("GDB"));
setCategory(QLatin1String(Constants::DEBUGGER_SETTINGS_CATEGORY));
QString GdbOptionsPage::displayName() const setDisplayCategory(QCoreApplication::translate("Debugger", Constants::DEBUGGER_SETTINGS_TR_CATEGORY));
{ setCategoryIcon(QLatin1String(Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
return tr("GDB");
}
QString GdbOptionsPage::category() const
{
return QLatin1String(Constants::DEBUGGER_SETTINGS_CATEGORY);
}
QString GdbOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Debugger", Constants::DEBUGGER_SETTINGS_TR_CATEGORY);
}
QIcon GdbOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
} }
QWidget *GdbOptionsPage::createPage(QWidget *parent) QWidget *GdbOptionsPage::createPage(QWidget *parent)

View File

@@ -36,8 +36,6 @@
#include <coreplugin/dialogs/ioptionspage.h> #include <coreplugin/dialogs/ioptionspage.h>
#include <utils/savedaction.h> #include <utils/savedaction.h>
namespace ProjectExplorer { class ToolChain; }
namespace Debugger { namespace Debugger {
namespace Internal { namespace Internal {
@@ -46,21 +44,14 @@ class GdbOptionsPageUi;
class GdbOptionsPage : public Core::IOptionsPage class GdbOptionsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit GdbOptionsPage(); GdbOptionsPage();
virtual QString id() const { return settingsId(); } QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish();
virtual QString displayCategory() const; bool matches(const QString &) const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &) const;
static QString settingsId();
private: private:
GdbOptionsPageUi *m_ui; GdbOptionsPageUi *m_ui;

View File

@@ -72,36 +72,12 @@ void LldbOptionsPageWidget::load()
// ---------- LldbOptionsPage // ---------- LldbOptionsPage
LldbOptionsPage::LldbOptionsPage() LldbOptionsPage::LldbOptionsPage()
{ {
// m_options->fromSettings(Core::ICore::settings()); // m_options->fromSettings(Core::ICore::settings());
} setId(QLatin1String("F.Lldb"));
setDisplayName(tr("LLDB"));
LldbOptionsPage::~LldbOptionsPage() setCategory(QLatin1String(Debugger::Constants::DEBUGGER_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Debugger", Constants::DEBUGGER_SETTINGS_TR_CATEGORY);
} setCategoryIcon(QIcon(QLatin1String(Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON)));
QString LldbOptionsPage::settingsId()
{
return QLatin1String("F.Lldb");
}
QString LldbOptionsPage::displayName() const
{
return tr("LLDB");
}
QString LldbOptionsPage::category() const
{
return QLatin1String(Debugger::Constants::DEBUGGER_SETTINGS_CATEGORY);
}
QString LldbOptionsPage::displayCategory() const
{
return QCoreApplication::translate("Debugger", Debugger::Constants::DEBUGGER_SETTINGS_TR_CATEGORY);
}
QIcon LldbOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Debugger::Constants::DEBUGGER_COMMON_SETTINGS_CATEGORY_ICON));
} }
QWidget *LldbOptionsPage::createPage(QWidget *parent) QWidget *LldbOptionsPage::createPage(QWidget *parent)

View File

@@ -65,22 +65,13 @@ class LldbOptionsPage : public Core::IOptionsPage
Q_OBJECT Q_OBJECT
public: public:
explicit LldbOptionsPage(); LldbOptionsPage();
virtual ~LldbOptionsPage();
// IOptionsPage // IOptionsPage
virtual QString id() const { return settingsId(); } QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish();
virtual QString displayCategory() const; bool matches(const QString &) const;
QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &) const;
static QString settingsId();
private: private:
QPointer<LldbOptionsPageWidget> m_widget; QPointer<LldbOptionsPageWidget> m_widget;

View File

@@ -108,31 +108,11 @@ QString CppSettingsPageWidget::searchKeywords() const
CppSettingsPage::CppSettingsPage(QObject *parent) : Core::IOptionsPage(parent) CppSettingsPage::CppSettingsPage(QObject *parent) : Core::IOptionsPage(parent)
{ {
m_parameters.fromSettings(Core::ICore::settings()); m_parameters.fromSettings(Core::ICore::settings());
} setId(QLatin1String(Designer::Constants::SETTINGS_CPP_SETTINGS_ID));
setDisplayName(QCoreApplication::translate("Designer", Designer::Constants::SETTINGS_CPP_SETTINGS_NAME));
QString CppSettingsPage::id() const setCategory(QLatin1String(Designer::Constants::SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Designer", Designer::Constants::SETTINGS_TR_CATEGORY));
return QLatin1String(Designer::Constants::SETTINGS_CPP_SETTINGS_ID); setCategoryIcon(QLatin1String(Designer::Constants::SETTINGS_CATEGORY_ICON));
}
QString CppSettingsPage::displayName() const
{
return QCoreApplication::translate("Designer", Designer::Constants::SETTINGS_CPP_SETTINGS_NAME);
}
QString CppSettingsPage::category() const
{
return QLatin1String(Designer::Constants::SETTINGS_CATEGORY);
}
QString CppSettingsPage::displayCategory() const
{
return QCoreApplication::translate("Designer", Designer::Constants::SETTINGS_TR_CATEGORY);
}
QIcon CppSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Designer::Constants::SETTINGS_CATEGORY_ICON));
} }
QWidget *CppSettingsPage::createPage(QWidget *parent) QWidget *CppSettingsPage::createPage(QWidget *parent)

View File

@@ -66,16 +66,10 @@ class CppSettingsPage : public Core::IOptionsPage
public: public:
explicit CppSettingsPage(QObject *parent = 0); explicit CppSettingsPage(QObject *parent = 0);
virtual QString id() const; QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish();
virtual QString displayCategory() const; bool matches(const QString &s) const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &s) const;
private: private:
QPointer<CppSettingsPageWidget> m_widget; QPointer<CppSettingsPageWidget> m_widget;

View File

@@ -49,35 +49,12 @@ using namespace Designer::Internal;
SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage) : SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage) :
m_designerPage(designerPage), m_initialized(false) m_designerPage(designerPage), m_initialized(false)
{ {
} setId(m_designerPage->name());
setDisplayName(m_designerPage->name());
SettingsPage::~SettingsPage() setCategory(QLatin1String(Designer::Constants::SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Designer",
} Designer::Constants::SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(Designer::Constants::SETTINGS_CATEGORY_ICON));
QString SettingsPage::id() const
{
return m_designerPage->name();
}
QString SettingsPage::displayName() const
{
return m_designerPage->name();
}
QString SettingsPage::category() const
{
return QLatin1String(Designer::Constants::SETTINGS_CATEGORY);
}
QString SettingsPage::displayCategory() const
{
return QCoreApplication::translate("Designer", Designer::Constants::SETTINGS_TR_CATEGORY);
}
QIcon SettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Designer::Constants::SETTINGS_CATEGORY_ICON));
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)
@@ -101,25 +78,10 @@ void SettingsPage::finish()
SettingsPageProvider::SettingsPageProvider(QObject *parent) SettingsPageProvider::SettingsPageProvider(QObject *parent)
: IOptionsPageProvider(parent), m_initialized(false) : IOptionsPageProvider(parent), m_initialized(false)
{ {
} setCategory(QLatin1String(Designer::Constants::SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("Designer",
SettingsPageProvider::~SettingsPageProvider() Designer::Constants::SETTINGS_TR_CATEGORY));
{ setCategoryIcon(QLatin1String(Designer::Constants::SETTINGS_CATEGORY_ICON));
}
QString SettingsPageProvider::category() const
{
return QLatin1String(Designer::Constants::SETTINGS_CATEGORY);
}
QString SettingsPageProvider::displayCategory() const
{
return QCoreApplication::translate("Designer", Designer::Constants::SETTINGS_TR_CATEGORY);
}
QIcon SettingsPageProvider::categoryIcon() const
{
return QIcon(QLatin1String(Designer::Constants::SETTINGS_CATEGORY_ICON));
} }
QList<Core::IOptionsPage *> SettingsPageProvider::pages() const QList<Core::IOptionsPage *> SettingsPageProvider::pages() const

View File

@@ -50,17 +50,10 @@ class SettingsPage : public Core::IOptionsPage
public: public:
explicit SettingsPage(QDesignerOptionsPageInterface *designerPage); explicit SettingsPage(QDesignerOptionsPageInterface *designerPage);
virtual ~SettingsPage();
QString id() const; QWidget *createPage(QWidget *parent);
QString displayName() const; void apply();
QString category() const; void finish();
QString displayCategory() const;
QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
private: private:
QDesignerOptionsPageInterface *m_designerPage; QDesignerOptionsPageInterface *m_designerPage;
@@ -73,11 +66,6 @@ class SettingsPageProvider : public Core::IOptionsPageProvider
public: public:
SettingsPageProvider(QObject *parent = 0); SettingsPageProvider(QObject *parent = 0);
~SettingsPageProvider();
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QList<Core::IOptionsPage *> pages() const; QList<Core::IOptionsPage *> pages() const;

View File

@@ -181,15 +181,14 @@ class FakeVimOptionPage : public Core::IOptionsPage
Q_OBJECT Q_OBJECT
public: public:
FakeVimOptionPage() {} FakeVimOptionPage()
{
// IOptionsPage setId(_(Constants::SETTINGS_ID));
QString id() const { return _(Constants::SETTINGS_ID); } setDisplayName(tr("General"));
QString displayName() const { return tr("General"); } setCategory(_(Constants::SETTINGS_CATEGORY));
QString category() const { return _(Constants::SETTINGS_CATEGORY); } setDisplayCategory(tr("FakeVim"));
QString displayCategory() const { return tr("FakeVim"); } setCategoryIcon(_(Constants::SETTINGS_CATEGORY_FAKEVIM_ICON));
QIcon categoryIcon() const }
{ return QIcon(_(Constants::SETTINGS_CATEGORY_FAKEVIM_ICON)); }
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply() { m_group.apply(ICore::settings()); } void apply() { m_group.apply(ICore::settings()); }
@@ -339,16 +338,15 @@ class FakeVimExCommandsPage : public Core::CommandMappings
Q_OBJECT Q_OBJECT
public: public:
FakeVimExCommandsPage(FakeVimPluginPrivate *q) : m_q(q) {} FakeVimExCommandsPage(FakeVimPluginPrivate *q)
~FakeVimExCommandsPage() {} : m_q(q)
{
// IOptionsPage setId(_(Constants::SETTINGS_EX_CMDS_ID));
QString id() const { return _(Constants::SETTINGS_EX_CMDS_ID); } setDisplayName(tr("Ex Command Mapping"));
QString displayName() const { return tr("Ex Command Mapping"); } setCategory(_(Constants::SETTINGS_CATEGORY));
QString category() const { return _(Constants::SETTINGS_CATEGORY); } setDisplayCategory(tr("FakeVim"));
QString displayCategory() const { return tr("FakeVim"); } setCategoryIcon(_(Constants::SETTINGS_CATEGORY_FAKEVIM_ICON));
QIcon categoryIcon() const }
{ return QIcon(_(Constants::SETTINGS_CATEGORY_FAKEVIM_ICON)); }
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void initialize(); void initialize();
@@ -565,16 +563,16 @@ class FakeVimUserCommandsPage : public Core::IOptionsPage
Q_OBJECT Q_OBJECT
public: public:
FakeVimUserCommandsPage(FakeVimPluginPrivate *q) : m_q(q) {} FakeVimUserCommandsPage(FakeVimPluginPrivate *q)
~FakeVimUserCommandsPage() {} : m_q(q)
{
setId(_(Constants::SETTINGS_USER_CMDS_ID));
setDisplayName(tr("User Command Mapping"));
setCategory(_(Constants::SETTINGS_CATEGORY));
setDisplayCategory(tr("FakeVim"));
setCategoryIcon(_(Constants::SETTINGS_CATEGORY_FAKEVIM_ICON));
}
// IOptionsPage
QString id() const { return _(Constants::SETTINGS_USER_CMDS_ID); }
QString displayName() const { return tr("User Command Mapping"); }
QString category() const { return _(Constants::SETTINGS_CATEGORY); }
QString displayCategory() const { return tr("FakeVim"); }
QIcon categoryIcon() const
{ return QIcon(_(Constants::SETTINGS_CATEGORY_FAKEVIM_ICON)); }
void apply(); void apply();
void finish() {} void finish() {}

View File

@@ -50,11 +50,13 @@ GerritOptionsPage::GerritOptionsPage(const QSharedPointer<GerritParameters> &p,
: VcsBase::VcsBaseOptionsPage(parent) : VcsBase::VcsBaseOptionsPage(parent)
, m_parameters(p) , m_parameters(p)
{ {
setId(optionsId());
setDisplayName(tr("Gerrit"));
} }
QString GerritOptionsPage::displayName() const QString GerritOptionsPage::optionsId()
{ {
return tr("Gerrit"); return QLatin1String("Gerrit");
} }
QWidget *GerritOptionsPage::createPage(QWidget *parent) QWidget *GerritOptionsPage::createPage(QWidget *parent)

View File

@@ -73,20 +73,17 @@ private:
class GerritOptionsPage : public VcsBase::VcsBaseOptionsPage class GerritOptionsPage : public VcsBase::VcsBaseOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
GerritOptionsPage(const QSharedPointer<GerritParameters> &p, GerritOptionsPage(const QSharedPointer<GerritParameters> &p,
QObject *parent = 0); QObject *parent = 0);
static QString optionsId() { return QLatin1String("Gerrit"); } static QString optionsId();
QString id() const { return optionsId(); }
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
bool matches(const QString &) const;
virtual bool matches(const QString &) const;
private: private:
const QSharedPointer<GerritParameters> &m_parameters; const QSharedPointer<GerritParameters> &m_parameters;

View File

@@ -121,16 +121,8 @@ QString SettingsPageWidget::searchKeywords() const
SettingsPage::SettingsPage() : SettingsPage::SettingsPage() :
m_widget(0) m_widget(0)
{ {
} setId(QLatin1String(VcsBase::Constants::VCS_ID_GIT));
setDisplayName(tr("Git"));
QString SettingsPage::id() const
{
return QLatin1String(VcsBase::Constants::VCS_ID_GIT);
}
QString SettingsPage::displayName() const
{
return tr("Git");
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)

View File

@@ -76,7 +76,7 @@ public:
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -45,31 +45,11 @@ using namespace Help::Internal;
DocSettingsPage::DocSettingsPage() DocSettingsPage::DocSettingsPage()
{ {
} setId(QLatin1String("B.Documentation"));
setDisplayName(tr("Documentation"));
QString DocSettingsPage::id() const setCategory(QLatin1String(Help::Constants::HELP_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY));
return QLatin1String("B.Documentation"); setCategoryIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
}
QString DocSettingsPage::displayName() const
{
return tr("Documentation");
}
QString DocSettingsPage::category() const
{
return QLatin1String(Help::Constants::HELP_CATEGORY);
}
QString DocSettingsPage::displayCategory() const
{
return QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY);
}
QIcon DocSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
} }
QWidget *DocSettingsPage::createPage(QWidget *parent) QWidget *DocSettingsPage::createPage(QWidget *parent)

View File

@@ -42,21 +42,14 @@ namespace Internal {
class DocSettingsPage : public Core::IOptionsPage class DocSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
typedef QHash<QString, QString> NameSpaceToPathHash;
public: public:
DocSettingsPage(); DocSettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() {} void finish() {}
virtual bool matches(const QString &s) const; bool matches(const QString &s) const;
private slots: private slots:
void addDocumentation(); void addDocumentation();
@@ -73,6 +66,7 @@ private:
QString m_searchKeywords; QString m_searchKeywords;
QString m_recentDialogPath; QString m_recentDialogPath;
typedef QHash<QString, QString> NameSpaceToPathHash;
NameSpaceToPathHash m_filesToRegister; NameSpaceToPathHash m_filesToRegister;
NameSpaceToPathHash m_filesToUnregister; NameSpaceToPathHash m_filesToUnregister;
}; };

View File

@@ -46,31 +46,11 @@ using namespace Help::Internal;
FilterSettingsPage::FilterSettingsPage() FilterSettingsPage::FilterSettingsPage()
{ {
} setId(QLatin1String("D.Filters"));
setDisplayName(tr("Filters"));
QString FilterSettingsPage::id() const setCategory(QLatin1String(Help::Constants::HELP_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY));
return QLatin1String("D.Filters"); setCategoryIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
}
QString FilterSettingsPage::displayName() const
{
return tr("Filters");
}
QString FilterSettingsPage::category() const
{
return QLatin1String(Help::Constants::HELP_CATEGORY);
}
QString FilterSettingsPage::displayCategory() const
{
return QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY);
}
QIcon FilterSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
} }
QWidget *FilterSettingsPage::createPage(QWidget *parent) QWidget *FilterSettingsPage::createPage(QWidget *parent)

View File

@@ -42,21 +42,14 @@ namespace Internal {
class FilterSettingsPage : public Core::IOptionsPage class FilterSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
typedef QMap<QString, QStringList> FilterMap;
public: public:
FilterSettingsPage(); FilterSettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
virtual bool matches(const QString &s) const; bool matches(const QString &s) const;
signals: signals:
void filtersChanged(); void filtersChanged();
@@ -75,6 +68,7 @@ private:
QString msgFilterLabel(const QString &filter) const; QString msgFilterLabel(const QString &filter) const;
Ui::FilterSettingsPage m_ui; Ui::FilterSettingsPage m_ui;
typedef QMap<QString, QStringList> FilterMap;
FilterMap m_filterMap; FilterMap m_filterMap;
FilterMap m_filterMapBackup; FilterMap m_filterMapBackup;

View File

@@ -66,31 +66,11 @@ GeneralSettingsPage::GeneralSettingsPage()
QWebSettings* webSettings = QWebSettings::globalSettings(); QWebSettings* webSettings = QWebSettings::globalSettings();
m_font.setPointSize(webSettings->fontSize(QWebSettings::DefaultFontSize)); m_font.setPointSize(webSettings->fontSize(QWebSettings::DefaultFontSize));
#endif #endif
} setId(QLatin1String("A.General settings"));
setDisplayName(tr("General"));
QString GeneralSettingsPage::id() const setCategory(QLatin1String(Help::Constants::HELP_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY));
return QLatin1String("A.General settings"); setCategoryIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
}
QString GeneralSettingsPage::displayName() const
{
return tr("General");
}
QString GeneralSettingsPage::category() const
{
return QLatin1String(Help::Constants::HELP_CATEGORY);
}
QString GeneralSettingsPage::displayCategory() const
{
return QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY);
}
QIcon GeneralSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
} }
QWidget *GeneralSettingsPage::createPage(QWidget *parent) QWidget *GeneralSettingsPage::createPage(QWidget *parent)

View File

@@ -48,16 +48,10 @@ class GeneralSettingsPage : public Core::IOptionsPage
public: public:
GeneralSettingsPage(); GeneralSettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
virtual bool matches(const QString &s) const; bool matches(const QString &s) const;
signals: signals:
void fontChanged(); void fontChanged();

View File

@@ -51,31 +51,11 @@ using namespace Locator::Internal;
SettingsPage::SettingsPage(LocatorPlugin *plugin) SettingsPage::SettingsPage(LocatorPlugin *plugin)
: m_plugin(plugin), m_page(0) : m_plugin(plugin), m_page(0)
{ {
} setId(Constants::FILTER_OPTIONS_PAGE);
setDisplayName(QCoreApplication::translate("Locator", Locator::Constants::FILTER_OPTIONS_PAGE));
QString SettingsPage::id() const setCategory(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE));
{ setDisplayCategory(QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE));
return QLatin1String(Constants::FILTER_OPTIONS_PAGE); setCategoryIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
}
QString SettingsPage::displayName() const
{
return QCoreApplication::translate("Locator", Locator::Constants::FILTER_OPTIONS_PAGE);
}
QString SettingsPage::category() const
{
return QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE);
}
QString SettingsPage::displayCategory() const
{
return QCoreApplication::translate("Core", Core::Constants::SETTINGS_TR_CATEGORY_CORE);
}
QIcon SettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Core::Constants::SETTINGS_CATEGORY_CORE_ICON));
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)

View File

@@ -58,16 +58,11 @@ class SettingsPage : public Core::IOptionsPage
public: public:
explicit SettingsPage(LocatorPlugin *plugin); explicit SettingsPage(LocatorPlugin *plugin);
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private slots: private slots:
void updateButtonStates(); void updateButtonStates();

View File

@@ -49,36 +49,11 @@ using namespace Macros::Internal;
MacroOptionsPage::MacroOptionsPage(QObject *parent) MacroOptionsPage::MacroOptionsPage(QObject *parent)
: Core::IOptionsPage(parent) : Core::IOptionsPage(parent)
{ {
} setId(QLatin1String(Constants::M_OPTIONS_PAGE));
setDisplayName(QCoreApplication::translate("Macros", Constants::M_OPTIONS_TR_PAGE));
MacroOptionsPage::~MacroOptionsPage() setCategory(QLatin1String(TextEditor::Constants::TEXT_EDITOR_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("TextEditor",
} TextEditor::Constants::TEXT_EDITOR_SETTINGS_TR_CATEGORY));
QString MacroOptionsPage::id() const
{
return Constants::M_OPTIONS_PAGE;
}
QString MacroOptionsPage::displayName() const
{
return QCoreApplication::translate("Macros", Constants::M_OPTIONS_TR_PAGE);
}
QString MacroOptionsPage::category() const
{
return TextEditor::Constants::TEXT_EDITOR_SETTINGS_CATEGORY;
}
QString MacroOptionsPage::displayCategory() const
{
return QCoreApplication::translate("TextEditor",
TextEditor::Constants::TEXT_EDITOR_SETTINGS_TR_CATEGORY);
}
QIcon MacroOptionsPage::categoryIcon() const
{
return QIcon();
} }
QWidget *MacroOptionsPage::createPage(QWidget *parent) QWidget *MacroOptionsPage::createPage(QWidget *parent)

View File

@@ -48,16 +48,9 @@ class MACROS_EXPORT MacroOptionsPage : public Core::IOptionsPage
public: public:
MacroOptionsPage(QObject *parent = 0); MacroOptionsPage(QObject *parent = 0);
~MacroOptionsPage();
// IOptionsPage implementation // IOptionsPage implementation
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -105,35 +105,11 @@ private:
MaemoQemuSettingsPage::MaemoQemuSettingsPage(QObject *parent) MaemoQemuSettingsPage::MaemoQemuSettingsPage(QObject *parent)
: Core::IOptionsPage(parent) : Core::IOptionsPage(parent)
{ {
} setId(pageId());
setDisplayName(tr("MeeGo Qemu Settings"));
MaemoQemuSettingsPage::~MaemoQemuSettingsPage() setCategory(pageCategory());
{ //setDisplayCategory(QString()); // Will be set by device configurations page.
} //setCategoryIcon(QIcon()) // See above.
QString MaemoQemuSettingsPage::id() const
{
return pageId();
}
QString MaemoQemuSettingsPage::displayName() const
{
return tr("MeeGo Qemu Settings");
}
QString MaemoQemuSettingsPage::category() const
{
return pageCategory();
}
QString MaemoQemuSettingsPage::displayCategory() const
{
return QString(); // Already set by device configurations page.
}
QIcon MaemoQemuSettingsPage::categoryIcon() const
{
return QIcon(); // See above.
} }
bool MaemoQemuSettingsPage::matches(const QString &searchKeyWord) const bool MaemoQemuSettingsPage::matches(const QString &searchKeyWord) const

View File

@@ -41,19 +41,14 @@ class MaemoQemuSettingsWidget;
class MaemoQemuSettingsPage : public Core::IOptionsPage class MaemoQemuSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
MaemoQemuSettingsPage(QObject *parent = 0); MaemoQemuSettingsPage(QObject *parent = 0);
~MaemoQemuSettingsPage();
virtual QString id() const; bool matches(const QString &searchKeyWord) const;
virtual QString displayName() const; QWidget *createPage(QWidget *parent);
virtual QString category() const; void apply();
virtual QString displayCategory() const; void finish();
virtual QIcon categoryIcon() const;
virtual bool matches(const QString &searchKeyWord) const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
static void showQemuCrashDialog(); static void showQemuCrashDialog();
static QString pageId(); static QString pageId();

View File

@@ -94,16 +94,8 @@ QString OptionsPageWidget::searchKeywords() const
OptionsPage::OptionsPage() OptionsPage::OptionsPage()
{ {
} setId(QLatin1String(VcsBase::Constants::VCS_ID_MERCURIAL));
setDisplayName(tr("Mercurial"));
QString OptionsPage::id() const
{
return QLatin1String(VcsBase::Constants::VCS_ID_MERCURIAL);
}
QString OptionsPage::displayName() const
{
return tr("Mercurial");
} }
QWidget *OptionsPage::createPage(QWidget *parent) QWidget *OptionsPage::createPage(QWidget *parent)

View File

@@ -140,16 +140,8 @@ QString SettingsPageWidget::searchKeywords() const
SettingsPage::SettingsPage() SettingsPage::SettingsPage()
{ {
} setId(QLatin1String(VcsBase::Constants::VCS_ID_PERFORCE));
setDisplayName(tr("Perforce"));
QString SettingsPage::id() const
{
return QLatin1String(VcsBase::Constants::VCS_ID_PERFORCE);
}
QString SettingsPage::displayName() const
{
return tr("Perforce");
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)

View File

@@ -78,13 +78,10 @@ class SettingsPage : public VcsBase::VcsBaseOptionsPage
public: public:
SettingsPage(); SettingsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -44,35 +44,11 @@ namespace Internal {
DeviceSettingsPage::DeviceSettingsPage(QObject *parent) DeviceSettingsPage::DeviceSettingsPage(QObject *parent)
: Core::IOptionsPage(parent) : Core::IOptionsPage(parent)
{ {
} setId(QLatin1String(Constants::DEVICE_SETTINGS_PAGE_ID));
setDisplayName(tr("Devices"));
DeviceSettingsPage::~DeviceSettingsPage() setCategory(QLatin1String(Constants::DEVICE_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("ProjectExplorer", "Devices"));
} setCategoryIcon(QLatin1String(":/projectexplorer/images/MaemoDevice.png"));
QString DeviceSettingsPage::id() const
{
return pageId();
}
QString DeviceSettingsPage::displayName() const
{
return tr("Devices");
}
QString DeviceSettingsPage::category() const
{
return pageCategory();
}
QString DeviceSettingsPage::displayCategory() const
{
return QCoreApplication::translate("ProjectExplorer", "Devices");
}
QIcon DeviceSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(":/projectexplorer/images/MaemoDevice.png"));
} }
bool DeviceSettingsPage::matches(const QString &searchKeyWord) const bool DeviceSettingsPage::matches(const QString &searchKeyWord) const
@@ -97,15 +73,5 @@ void DeviceSettingsPage::finish()
{ {
} }
QString DeviceSettingsPage::pageId()
{
return QLatin1String(Constants::DEVICE_SETTINGS_PAGE_ID);
}
QString DeviceSettingsPage::pageCategory()
{
return QLatin1String(Constants::DEVICE_SETTINGS_CATEGORY);
}
} // namespace Internal } // namespace Internal
} // namespace ProjectExplorer } // namespace ProjectExplorer

View File

@@ -35,27 +35,20 @@
namespace ProjectExplorer { namespace ProjectExplorer {
namespace Internal { namespace Internal {
class DeviceSettingsWidget; class DeviceSettingsWidget;
class DeviceSettingsPage : public Core::IOptionsPage class DeviceSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
DeviceSettingsPage(QObject *parent = 0); DeviceSettingsPage(QObject *parent = 0);
~DeviceSettingsPage();
virtual QString id() const; bool matches(const QString &searchKeyWord) const;
virtual QString displayName() const; QWidget *createPage(QWidget *parent);
virtual QString category() const; void apply();
virtual QString displayCategory() const; void finish();
virtual QIcon categoryIcon() const;
virtual bool matches(const QString &searchKeyWord) const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
static QString pageId();
static QString pageCategory();
private: private:
QString m_keywords; QString m_keywords;

View File

@@ -153,32 +153,16 @@ QString ProjectExplorerSettingsWidget::searchKeywords() const
// ------------------ ProjectExplorerSettingsPage // ------------------ ProjectExplorerSettingsPage
ProjectExplorerSettingsPage::ProjectExplorerSettingsPage() ProjectExplorerSettingsPage::ProjectExplorerSettingsPage()
{ {
setId(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_ID));
setDisplayName(tr("General"));
setCategory(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("ProjectExplorer",
Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY));
setCategoryIcon(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
} }
QString ProjectExplorerSettingsPage::id() const ProjectExplorerSettingsPage::~ProjectExplorerSettingsPage()
{ {
return QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_ID);
}
QString ProjectExplorerSettingsPage::displayName() const
{
return tr("General");
}
QString ProjectExplorerSettingsPage::category() const
{
return QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY);
}
QString ProjectExplorerSettingsPage::displayCategory() const
{
return QCoreApplication::translate("ProjectExplorer",
Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY);
}
QIcon ProjectExplorerSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
} }
QWidget *ProjectExplorerSettingsPage::createPage(QWidget *parent) QWidget *ProjectExplorerSettingsPage::createPage(QWidget *parent)

View File

@@ -73,19 +73,15 @@ private:
class ProjectExplorerSettingsPage : public Core::IOptionsPage class ProjectExplorerSettingsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
ProjectExplorerSettingsPage(); ProjectExplorerSettingsPage();
~ProjectExplorerSettingsPage();
virtual QString id() const; QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish();
virtual QString displayCategory() const; bool matches(const QString &s) const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &s) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -472,32 +472,13 @@ void ToolChainModel::removeToolChain(ToolChain *tc)
ToolChainOptionsPage::ToolChainOptionsPage() : ToolChainOptionsPage::ToolChainOptionsPage() :
m_ui(0), m_model(0), m_selectionModel(0), m_currentTcWidget(0) m_ui(0), m_model(0), m_selectionModel(0), m_currentTcWidget(0)
{ }
QString ToolChainOptionsPage::id() const
{ {
return QLatin1String(Constants::TOOLCHAIN_SETTINGS_PAGE_ID); setId(QLatin1String(Constants::TOOLCHAIN_SETTINGS_PAGE_ID));
} setDisplayName(tr("Tool Chains"));
setCategory(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY));
QString ToolChainOptionsPage::displayName() const setDisplayCategory(QCoreApplication::translate("ProjectExplorer",
{ Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY));
return tr("Tool Chains"); setCategoryIcon(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
}
QString ToolChainOptionsPage::category() const
{
return QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY);
}
QString ToolChainOptionsPage::displayCategory() const
{
return QCoreApplication::translate("ProjectExplorer",
Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY);
}
QIcon ToolChainOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
} }
QWidget *ToolChainOptionsPage::createPage(QWidget *parent) QWidget *ToolChainOptionsPage::createPage(QWidget *parent)

View File

@@ -123,16 +123,10 @@ class ToolChainOptionsPage : public Core::IOptionsPage
public: public:
ToolChainOptionsPage(); ToolChainOptionsPage();
virtual QString id() const; QWidget *createPage(QWidget *parent);
virtual QString displayName() const; void apply();
virtual QString category() const; void finish();
virtual QString displayCategory() const; bool matches(const QString &) const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish();
virtual bool matches(const QString &) const;
private slots: private slots:
void toolChainSelectionChanged(); void toolChainSelectionChanged();

View File

@@ -82,31 +82,12 @@ QString SettingsPageWidget::searchKeywords() const
SettingsPage::SettingsPage() : SettingsPage::SettingsPage() :
m_widget(0) m_widget(0)
{ {
} setId(QLatin1String("B.QmlDesigner"));
setDisplayName(tr("Qt Quick Designer"));
QString SettingsPage::id() const setCategory(QLatin1String(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML));
{ setDisplayCategory(QCoreApplication::translate("QmlJSEditor",
return QLatin1String("B.QmlDesigner"); QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML));
} setCategoryIcon(QLatin1String(Constants::SETTINGS_CATEGORY_QML_ICON));
QString SettingsPage::displayName() const
{
return tr("Qt Quick Designer");
}
QString SettingsPage::category() const
{
return QLatin1String(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML);
}
QString SettingsPage::displayCategory() const
{
return QCoreApplication::translate("QmlJSEditor", QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML);
}
QIcon SettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::SETTINGS_CATEGORY_QML_ICON));
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)

View File

@@ -53,6 +53,7 @@ namespace Internal {
class SettingsPageWidget : public QWidget class SettingsPageWidget : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
explicit SettingsPageWidget(QWidget *parent = 0); explicit SettingsPageWidget(QWidget *parent = 0);
@@ -73,16 +74,10 @@ class SettingsPage : public Core::IOptionsPage
public: public:
SettingsPage(); SettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -126,31 +126,12 @@ QuickToolBarSettings QuickToolBarSettings::get()
QuickToolBarSettingsPage::QuickToolBarSettingsPage() : QuickToolBarSettingsPage::QuickToolBarSettingsPage() :
m_widget(0) m_widget(0)
{ {
} setId(QLatin1String("C.QmlToolbar"));
setDisplayName(tr("Qt Quick ToolBar"));
QString QuickToolBarSettingsPage::id() const setCategory(QLatin1String(Constants::SETTINGS_CATEGORY_QML));
{ setDisplayCategory(QCoreApplication::translate("QmlJSEditor",
return QLatin1String("C.QmlToolbar"); QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML));
} setCategoryIcon(QLatin1String(QmlDesigner::Constants::SETTINGS_CATEGORY_QML_ICON));
QString QuickToolBarSettingsPage::displayName() const
{
return tr("Qt Quick ToolBar");
}
QString QuickToolBarSettingsPage::category() const
{
return QLatin1String(Constants::SETTINGS_CATEGORY_QML);
}
QString QuickToolBarSettingsPage::displayCategory() const
{
return QCoreApplication::translate("QmlJSEditor", QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML);
}
QIcon QuickToolBarSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(QmlDesigner::Constants::SETTINGS_CATEGORY_QML_ICON));
} }
QWidget *QuickToolBarSettingsPage::createPage(QWidget *parent) QWidget *QuickToolBarSettingsPage::createPage(QWidget *parent)

View File

@@ -94,16 +94,10 @@ class QuickToolBarSettingsPage : public Core::IOptionsPage
public: public:
QuickToolBarSettingsPage(); QuickToolBarSettingsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -169,35 +169,11 @@ QmlJSCodeStyleSettingsPage::QmlJSCodeStyleSettingsPage(/*QSharedPointer<CppFileS
Core::IOptionsPage(parent), Core::IOptionsPage(parent),
m_pageTabPreferences(0) m_pageTabPreferences(0)
{ {
} setId(QLatin1String(Constants::QML_JS_CODE_STYLE_SETTINGS_ID));
setDisplayName(QCoreApplication::translate("QmlJSTools", Constants::QML_JS_CODE_STYLE_SETTINGS_NAME));
QmlJSCodeStyleSettingsPage::~QmlJSCodeStyleSettingsPage() setCategory(QLatin1String(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML));
{ setDisplayCategory(QCoreApplication::translate("QmlJSEditor", QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML));
} setCategoryIcon(QLatin1String(QmlDesigner::Constants::SETTINGS_CATEGORY_QML_ICON));
QString QmlJSCodeStyleSettingsPage::id() const
{
return QLatin1String(Constants::QML_JS_CODE_STYLE_SETTINGS_ID);
}
QString QmlJSCodeStyleSettingsPage::displayName() const
{
return QCoreApplication::translate("QmlJSTools", Constants::QML_JS_CODE_STYLE_SETTINGS_NAME);
}
QString QmlJSCodeStyleSettingsPage::category() const
{
return QLatin1String(QmlJSEditor::Constants::SETTINGS_CATEGORY_QML);
}
QString QmlJSCodeStyleSettingsPage::displayCategory() const
{
return QCoreApplication::translate("QmlJSEditor", QmlJSEditor::Constants::SETTINGS_TR_CATEGORY_QML);
}
QIcon QmlJSCodeStyleSettingsPage::categoryIcon() const
{
return QIcon(QLatin1String(QmlDesigner::Constants::SETTINGS_CATEGORY_QML_ICON));
} }
QWidget *QmlJSCodeStyleSettingsPage::createPage(QWidget *parent) QWidget *QmlJSCodeStyleSettingsPage::createPage(QWidget *parent)

View File

@@ -61,10 +61,9 @@ class QmlJSCodeStylePreferencesWidget : public QWidget
public: public:
explicit QmlJSCodeStylePreferencesWidget(QWidget *parent = 0); explicit QmlJSCodeStylePreferencesWidget(QWidget *parent = 0);
virtual ~QmlJSCodeStylePreferencesWidget(); ~QmlJSCodeStylePreferencesWidget();
void setPreferences(TextEditor::ICodeStylePreferences *preferences); void setPreferences(TextEditor::ICodeStylePreferences *preferences);
QString searchKeywords() const; QString searchKeywords() const;
private slots: private slots:
@@ -74,7 +73,6 @@ private slots:
void updatePreview(); void updatePreview();
private: private:
TextEditor::ICodeStylePreferences *m_preferences; TextEditor::ICodeStylePreferences *m_preferences;
Ui::QmlJSCodeStyleSettingsPage *m_ui; Ui::QmlJSCodeStyleSettingsPage *m_ui;
}; };
@@ -86,19 +84,11 @@ class QmlJSCodeStyleSettingsPage : public Core::IOptionsPage
public: public:
explicit QmlJSCodeStyleSettingsPage(QWidget *parent = 0); explicit QmlJSCodeStyleSettingsPage(QWidget *parent = 0);
~QmlJSCodeStyleSettingsPage();
virtual QString id() const;
virtual QString displayName() const;
virtual QString category() const;
virtual QString displayCategory() const;
virtual QIcon categoryIcon() const;
virtual QWidget *createPage(QWidget *parent);
virtual void apply();
virtual void finish() { }
virtual bool matches(const QString &) const;
QWidget *createPage(QWidget *parent);
void apply();
void finish() { }
bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -126,32 +126,12 @@ bool UnConfiguredSettingsWidget::matches(const QString &searchKeyword)
UnConfiguredSettingsOptionPage::UnConfiguredSettingsOptionPage() UnConfiguredSettingsOptionPage::UnConfiguredSettingsOptionPage()
{ {
} setId(Constants::UNCONFIGURED_SETTINGS_PAGE_ID);
setDisplayName(QCoreApplication::translate("Qt4ProjectManager", Constants::UNCONFIGURED_SETTINGS_PAGE_NAME));
QString UnConfiguredSettingsOptionPage::id() const setCategory(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("ProjectExplorer",
return Constants::UNCONFIGURED_SETTINGS_PAGE_ID; ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY));
} setCategoryIcon(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
QString UnConfiguredSettingsOptionPage::displayName() const
{
return QCoreApplication::translate("Qt4ProjectManager", Constants::UNCONFIGURED_SETTINGS_PAGE_NAME);
}
QString UnConfiguredSettingsOptionPage::category() const
{
return QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY);
}
QString UnConfiguredSettingsOptionPage::displayCategory() const
{
return QCoreApplication::translate("ProjectExplorer",
ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY);
}
QIcon UnConfiguredSettingsOptionPage::categoryIcon() const
{
return QIcon(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON);
} }
bool UnConfiguredSettingsOptionPage::matches(const QString &searchKeyword) const bool UnConfiguredSettingsOptionPage::matches(const QString &searchKeyword) const

View File

@@ -62,16 +62,11 @@ class UnConfiguredSettingsOptionPage : public Core::IOptionsPage
public: public:
UnConfiguredSettingsOptionPage(); UnConfiguredSettingsOptionPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
bool matches(const QString &searcKeyword) const; bool matches(const QString &searcKeyword) const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
private: private:
UnConfiguredSettingsWidget *m_widget; UnConfiguredSettingsWidget *m_widget;
}; };

View File

@@ -71,32 +71,12 @@ using namespace QtSupport::Internal;
QtOptionsPage::QtOptionsPage() QtOptionsPage::QtOptionsPage()
: m_widget(0) : m_widget(0)
{ {
} setId(QLatin1String(Constants::QTVERSION_SETTINGS_PAGE_ID));
setDisplayName(QCoreApplication::translate("Qt4ProjectManager", Constants::QTVERSION_SETTINGS_PAGE_NAME));
QString QtOptionsPage::id() const setCategory(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY));
{ setDisplayCategory(QCoreApplication::translate("ProjectExplorer",
return QLatin1String(Constants::QTVERSION_SETTINGS_PAGE_ID); ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY));
} setCategoryIcon(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
QString QtOptionsPage::displayName() const
{
return QCoreApplication::translate("Qt4ProjectManager", Constants::QTVERSION_SETTINGS_PAGE_NAME);
}
QString QtOptionsPage::category() const
{
return QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY);
}
QString QtOptionsPage::displayCategory() const
{
return QCoreApplication::translate("ProjectExplorer",
ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_TR_CATEGORY);
}
QIcon QtOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(ProjectExplorer::Constants::PROJECTEXPLORER_SETTINGS_CATEGORY_ICON));
} }
QWidget *QtOptionsPage::createPage(QWidget *parent) QWidget *QtOptionsPage::createPage(QWidget *parent)

View File

@@ -139,17 +139,14 @@ private:
class QtOptionsPage : public Core::IOptionsPage class QtOptionsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
QtOptionsPage(); QtOptionsPage();
QString id() const;
QString displayName() const;
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() {} void finish() {}
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private: private:
QtOptionsPageWidget *m_widget; QtOptionsPageWidget *m_widget;

View File

@@ -105,16 +105,8 @@ QString SettingsPageWidget::searchKeywords() const
SettingsPage::SettingsPage() : SettingsPage::SettingsPage() :
m_widget(0) m_widget(0)
{ {
} setId(QLatin1String(VcsBase::Constants::VCS_ID_SUBVERSION));
setDisplayName(tr("Subversion"));
QString SettingsPage::id() const
{
return QLatin1String(VcsBase::Constants::VCS_ID_SUBVERSION);
}
QString SettingsPage::displayName() const
{
return tr("Subversion");
} }
QWidget *SettingsPage::createPage(QWidget *parent) QWidget *SettingsPage::createPage(QWidget *parent)

View File

@@ -74,13 +74,10 @@ class SettingsPage : public VcsBase::VcsBaseOptionsPage
public: public:
SettingsPage(); SettingsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
virtual bool matches(const QString &) const; bool matches(const QString &) const;
private: private:
QString m_searchKeywords; QString m_searchKeywords;

View File

@@ -102,6 +102,9 @@ BehaviorSettingsPage::BehaviorSettingsPage(const BehaviorSettingsPageParameters
d->m_defaultCodeStylePool = new CodeStylePool(0, this); // Any language d->m_defaultCodeStylePool = new CodeStylePool(0, this); // Any language
d->m_defaultCodeStylePool->addCodeStyle(d->m_codeStyle); d->m_defaultCodeStylePool->addCodeStyle(d->m_codeStyle);
d->init(); d->init();
setId(p.id);
setDisplayName(p.displayName);
} }
BehaviorSettingsPage::~BehaviorSettingsPage() BehaviorSettingsPage::~BehaviorSettingsPage()
@@ -109,16 +112,6 @@ BehaviorSettingsPage::~BehaviorSettingsPage()
delete d; delete d;
} }
QString BehaviorSettingsPage::id() const
{
return d->m_parameters.id;
}
QString BehaviorSettingsPage::displayName() const
{
return d->m_parameters.displayName;
}
QWidget *BehaviorSettingsPage::createPage(QWidget *parent) QWidget *BehaviorSettingsPage::createPage(QWidget *parent)
{ {
QWidget *w = new QWidget(parent); QWidget *w = new QWidget(parent);

View File

@@ -61,12 +61,9 @@ class BehaviorSettingsPage : public TextEditorOptionsPage
public: public:
BehaviorSettingsPage(const BehaviorSettingsPageParameters &p, QObject *parent); BehaviorSettingsPage(const BehaviorSettingsPageParameters &p, QObject *parent);
virtual ~BehaviorSettingsPage(); ~BehaviorSettingsPage();
// IOptionsPage // IOptionsPage
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -65,6 +65,8 @@ DisplaySettingsPage::DisplaySettingsPage(const DisplaySettingsPageParameters &p,
: TextEditorOptionsPage(parent), : TextEditorOptionsPage(parent),
d(new DisplaySettingsPagePrivate(p)) d(new DisplaySettingsPagePrivate(p))
{ {
setId(p.id);
setDisplayName(p.displayName);
} }
DisplaySettingsPage::~DisplaySettingsPage() DisplaySettingsPage::~DisplaySettingsPage()
@@ -72,16 +74,6 @@ DisplaySettingsPage::~DisplaySettingsPage()
delete d; delete d;
} }
QString DisplaySettingsPage::id() const
{
return d->m_parameters.id;
}
QString DisplaySettingsPage::displayName() const
{
return d->m_parameters.displayName;
}
QWidget *DisplaySettingsPage::createPage(QWidget *parent) QWidget *DisplaySettingsPage::createPage(QWidget *parent)
{ {
QWidget *w = new QWidget(parent); QWidget *w = new QWidget(parent);

View File

@@ -55,12 +55,9 @@ class DisplaySettingsPage : public TextEditorOptionsPage
public: public:
DisplaySettingsPage(const DisplaySettingsPageParameters &p, QObject *parent); DisplaySettingsPage(const DisplaySettingsPageParameters &p, QObject *parent);
virtual ~DisplaySettingsPage(); ~DisplaySettingsPage();
// IOptionsPage // IOptionsPage
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -321,6 +321,8 @@ FontSettingsPage::FontSettingsPage(const FormatDescriptions &fd,
TextEditorOptionsPage(parent), TextEditorOptionsPage(parent),
d_ptr(new FontSettingsPagePrivate(fd, id, tr("Font && Colors"), category())) d_ptr(new FontSettingsPagePrivate(fd, id, tr("Font && Colors"), category()))
{ {
setId(d_ptr->m_id);
setDisplayName(d_ptr->m_displayName);
} }
FontSettingsPage::~FontSettingsPage() FontSettingsPage::~FontSettingsPage()
@@ -328,16 +330,6 @@ FontSettingsPage::~FontSettingsPage()
delete d_ptr; delete d_ptr;
} }
QString FontSettingsPage::id() const
{
return d_ptr->m_id;
}
QString FontSettingsPage::displayName() const
{
return d_ptr->m_displayName;
}
QWidget *FontSettingsPage::createPage(QWidget *parent) QWidget *FontSettingsPage::createPage(QWidget *parent)
{ {
QWidget *w = new QWidget(parent); QWidget *w = new QWidget(parent);

View File

@@ -93,13 +93,10 @@ public:
~FontSettingsPage(); ~FontSettingsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();
virtual bool matches(const QString &) const; bool matches(const QString &) const;
void saveSettings(); void saveSettings();

View File

@@ -83,6 +83,8 @@ HighlighterSettingsPage::HighlighterSettingsPage(const QString &id, QObject *par
m_requestMimeTypeRegistration(false), m_requestMimeTypeRegistration(false),
m_d(new HighlighterSettingsPagePrivate(id)) m_d(new HighlighterSettingsPagePrivate(id))
{ {
setId(m_d->m_id);
setDisplayName(m_d->m_displayName);
} }
HighlighterSettingsPage::~HighlighterSettingsPage() HighlighterSettingsPage::~HighlighterSettingsPage()
@@ -90,16 +92,6 @@ HighlighterSettingsPage::~HighlighterSettingsPage()
delete m_d; delete m_d;
} }
QString HighlighterSettingsPage::id() const
{
return m_d->m_id;
}
QString HighlighterSettingsPage::displayName() const
{
return m_d->m_displayName;
}
QWidget *HighlighterSettingsPage::createPage(QWidget *parent) QWidget *HighlighterSettingsPage::createPage(QWidget *parent)
{ {
QWidget *w = new QWidget(parent); QWidget *w = new QWidget(parent);

View File

@@ -50,12 +50,10 @@ class HighlighterSettings;
class HighlighterSettingsPage : public TextEditorOptionsPage class HighlighterSettingsPage : public TextEditorOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
HighlighterSettingsPage(const QString &id, QObject *parent); HighlighterSettingsPage(const QString &id, QObject *parent);
virtual ~HighlighterSettingsPage(); ~HighlighterSettingsPage();
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();

View File

@@ -565,23 +565,16 @@ void SnippetsSettingsPagePrivate::decorateEditors(const TextEditor::FontSettings
SnippetsSettingsPage::SnippetsSettingsPage(const QString &id, QObject *parent) : SnippetsSettingsPage::SnippetsSettingsPage(const QString &id, QObject *parent) :
TextEditorOptionsPage(parent), TextEditorOptionsPage(parent),
d(new SnippetsSettingsPagePrivate(id)) d(new SnippetsSettingsPagePrivate(id))
{} {
setId(d->id());
setDisplayName(d->displayName());
}
SnippetsSettingsPage::~SnippetsSettingsPage() SnippetsSettingsPage::~SnippetsSettingsPage()
{ {
delete d; delete d;
} }
QString SnippetsSettingsPage::id() const
{
return d->id();
}
QString SnippetsSettingsPage::displayName() const
{
return d->displayName();
}
bool SnippetsSettingsPage::matches(const QString &s) const bool SnippetsSettingsPage::matches(const QString &s) const
{ {
return d->isKeyword(s); return d->isKeyword(s);

View File

@@ -46,14 +46,12 @@ class SnippetsSettingsPage : public TextEditorOptionsPage
public: public:
SnippetsSettingsPage(const QString &id, QObject *parent); SnippetsSettingsPage(const QString &id, QObject *parent);
virtual ~SnippetsSettingsPage(); ~SnippetsSettingsPage();
virtual QString id() const; bool matches(const QString &s) const;
virtual QString displayName() const; QWidget *createPage(QWidget *parent);
virtual bool matches(const QString &s) const; void apply();
virtual QWidget *createPage(QWidget *parent); void finish();
virtual void apply();
virtual void finish();
private: private:
SnippetsSettingsPagePrivate *d; SnippetsSettingsPagePrivate *d;

View File

@@ -35,26 +35,13 @@
#include "texteditorconstants.h" #include "texteditorconstants.h"
#include <QCoreApplication> #include <QCoreApplication>
#include <QIcon>
using namespace TextEditor; using namespace TextEditor;
TextEditorOptionsPage::TextEditorOptionsPage(QObject *parent) : TextEditorOptionsPage::TextEditorOptionsPage(QObject *parent) :
Core::IOptionsPage(parent) Core::IOptionsPage(parent)
{ {
} setCategory(QLatin1String(Constants::TEXT_EDITOR_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("TextEditor", Constants::TEXT_EDITOR_SETTINGS_TR_CATEGORY));
QString TextEditorOptionsPage::category() const setCategoryIcon(QLatin1String(Constants::TEXT_EDITOR_SETTINGS_CATEGORY_ICON));
{
return QLatin1String(Constants::TEXT_EDITOR_SETTINGS_CATEGORY);
}
QString TextEditorOptionsPage::displayCategory() const
{
return QCoreApplication::translate("TextEditor", Constants::TEXT_EDITOR_SETTINGS_TR_CATEGORY);
}
QIcon TextEditorOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::TEXT_EDITOR_SETTINGS_CATEGORY_ICON));
} }

View File

@@ -48,11 +48,6 @@ class TEXTEDITOR_EXPORT TextEditorOptionsPage : public Core::IOptionsPage
public: public:
explicit TextEditorOptionsPage(QObject *parent = 0); explicit TextEditorOptionsPage(QObject *parent = 0);
// IOptionsPage
QString category() const;
QString displayCategory() const;
QIcon categoryIcon() const;
}; };
} // namespace TextEditor } // namespace TextEditor

View File

@@ -51,10 +51,12 @@ OptionsPage::OptionsPage(const Settings &settings, QObject *parent) :
m_dialog(0) m_dialog(0)
{ {
setSettings(settings); setSettings(settings);
}
OptionsPage::~OptionsPage() setId(QLatin1String("TodoSettings"));
{ setDisplayName(tr("To-Do"));
setCategory(QLatin1String("To-Do"));
setDisplayCategory(tr("To-Do"));
setCategoryIcon(QLatin1String(Constants::ICON_TODO));
} }
void OptionsPage::setSettings(const Settings &settings) void OptionsPage::setSettings(const Settings &settings)
@@ -62,42 +64,6 @@ void OptionsPage::setSettings(const Settings &settings)
m_settings = settings; m_settings = settings;
} }
QString OptionsPage::id() const
{
return QLatin1String("TodoSettings");
}
QString OptionsPage::trName() const
{
return tr("To-Do");
}
QString OptionsPage::category() const
{
return QLatin1String("To-Do");
}
QString OptionsPage::trCategory() const
{
return tr("To-Do");
}
QString OptionsPage::displayName() const
{
return trName();
}
QString OptionsPage::displayCategory() const
{
return trCategory();
}
QIcon OptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::ICON_TODO));
}
QWidget *OptionsPage::createPage(QWidget *parent) QWidget *OptionsPage::createPage(QWidget *parent)
{ {
m_dialog = new OptionsDialog(parent); m_dialog = new OptionsDialog(parent);

View File

@@ -46,19 +46,12 @@ class OptionsDialog;
class OptionsPage : public Core::IOptionsPage class OptionsPage : public Core::IOptionsPage
{ {
Q_OBJECT Q_OBJECT
public: public:
OptionsPage(const Settings &settings, QObject *parent = 0); OptionsPage(const Settings &settings, QObject *parent = 0);
~OptionsPage();
void setSettings(const Settings &settings); void setSettings(const Settings &settings);
QString id() const;
QString trName() const;
QString category() const;
QString trCategory() const;
QString displayName() const;
QIcon categoryIcon() const;
QString displayCategory() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish(); void finish();

View File

@@ -110,20 +110,9 @@ CommonOptionsPage::CommonOptionsPage(QObject *parent) :
VcsBaseOptionsPage(parent) VcsBaseOptionsPage(parent)
{ {
m_settings.fromSettings(Core::ICore::settings()); m_settings.fromSettings(Core::ICore::settings());
}
void CommonOptionsPage::updateNickNames() setId(QLatin1String(Constants::VCS_COMMON_SETTINGS_ID));
{ setDisplayName(QCoreApplication::translate("VcsBase", Constants::VCS_COMMON_SETTINGS_NAME));
}
QString CommonOptionsPage::id() const
{
return QLatin1String(Constants::VCS_COMMON_SETTINGS_ID);
}
QString CommonOptionsPage::displayName() const
{
return QCoreApplication::translate("VcsBase", Constants::VCS_COMMON_SETTINGS_NAME);
} }
QWidget *CommonOptionsPage::createPage(QWidget *parent) QWidget *CommonOptionsPage::createPage(QWidget *parent)

View File

@@ -69,9 +69,6 @@ class CommonOptionsPage : public VcsBaseOptionsPage
public: public:
explicit CommonOptionsPage(QObject *parent = 0); explicit CommonOptionsPage(QObject *parent = 0);
QString id() const;
QString displayName() const;
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() { } void finish() { }
@@ -83,8 +80,6 @@ signals:
void settingsChanged(const VcsBase::Internal::CommonVcsSettings &s); void settingsChanged(const VcsBase::Internal::CommonVcsSettings &s);
private: private:
void updateNickNames();
CommonSettingsWidget *m_widget; CommonSettingsWidget *m_widget;
CommonVcsSettings m_settings; CommonVcsSettings m_settings;
QString m_searchKeyWords; QString m_searchKeyWords;

View File

@@ -35,7 +35,6 @@
#include "vcsbaseconstants.h" #include "vcsbaseconstants.h"
#include <QCoreApplication> #include <QCoreApplication>
#include <QIcon>
/*! /*!
\class VcsBase::VcsBaseOptionsPage \class VcsBase::VcsBaseOptionsPage
@@ -48,21 +47,9 @@ namespace VcsBase {
VcsBaseOptionsPage::VcsBaseOptionsPage(QObject *parent) : VcsBaseOptionsPage::VcsBaseOptionsPage(QObject *parent) :
Core::IOptionsPage(parent) Core::IOptionsPage(parent)
{ {
} setCategory(QLatin1String(Constants::VCS_SETTINGS_CATEGORY));
setDisplayCategory(QCoreApplication::translate("VcsBase", Constants::VCS_SETTINGS_TR_CATEGORY));
QString VcsBaseOptionsPage::category() const setCategoryIcon(QLatin1String(Constants::SETTINGS_CATEGORY_VCS_ICON));
{
return QLatin1String(Constants::VCS_SETTINGS_CATEGORY);
}
QString VcsBaseOptionsPage::displayCategory() const
{
return QCoreApplication::translate("VcsBase", Constants::VCS_SETTINGS_TR_CATEGORY);
}
QIcon VcsBaseOptionsPage::categoryIcon() const
{
return QIcon(QLatin1String(Constants::SETTINGS_CATEGORY_VCS_ICON));
} }
} // namespace VcsBase } // namespace VcsBase

Some files were not shown because too many files have changed in this diff Show More