From f787afe732a44996fb36e94218a090ff100dc716 Mon Sep 17 00:00:00 2001
From: Alessandro Portale <alessandro.portale@qt.io>
Date: Thu, 15 Jul 2021 10:31:05 +0200
Subject: [PATCH] Tracing: Fix a couple of warnings regarding parameter
 injection
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Parameter "XYZ" is not declared. Injection of parameters into signal
handlers is deprecated. Use JavaScript functions with formal parameters
instead.

Change-Id: I3aea1af6bb6559f26dc83b8c20ada11885b715f9
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
---
 src/libs/tracing/qml/CategoryLabel.qml  |  4 ++--
 src/libs/tracing/qml/MainView.qml       | 10 +++++++---
 src/libs/tracing/qml/Overview.qml       |  4 ++--
 src/libs/tracing/qml/TimelineLabels.qml |  4 ++--
 src/libs/tracing/qml/TimelineRulers.qml |  2 +-
 5 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/src/libs/tracing/qml/CategoryLabel.qml b/src/libs/tracing/qml/CategoryLabel.qml
index cfd98c9a31f..e70dba108c8 100644
--- a/src/libs/tracing/qml/CategoryLabel.qml
+++ b/src/libs/tracing/qml/CategoryLabel.qml
@@ -72,7 +72,7 @@ Item {
     DropArea {
         id: dropArea
 
-        onPositionChanged: {
+        onPositionChanged: (drag) => {
             var sourceIndex = drag.source.visualIndex;
             if (drag.source.y === 0) {
                 // special case for first position: Always swap, no matter if upper border touched.
@@ -129,7 +129,7 @@ Item {
                             labelContainer.selectNextBySelectionId(label.id);
                         }
                     }
-                    onSetRowHeight: {
+                    onSetRowHeight: (newHeight) => {
                         labelsArea.parentModel.setExpandedRowHeight(index + 1, newHeight);
                         loader.height = labelsArea.parentModel.rowHeight(index + 1);
                     }
diff --git a/src/libs/tracing/qml/MainView.qml b/src/libs/tracing/qml/MainView.qml
index 0bdf9346ec7..17a6a29e3c0 100644
--- a/src/libs/tracing/qml/MainView.qml
+++ b/src/libs/tracing/qml/MainView.qml
@@ -151,8 +151,12 @@ Rectangle {
         zoomer: zoomControl
         reverseSelect: shiftPressed
 
-        onMoveCategories: content.moveCategories(sourceIndex, targetIndex)
-        onSelectItem: content.select(modelIndex, eventIndex)
+        onMoveCategories: (sourceIndex, targetIndex) => {
+            content.moveCategories(sourceIndex, targetIndex)
+        }
+        onSelectItem: (modelIndex, eventIndex) => {
+            content.select(modelIndex, eventIndex)
+        }
     }
 
     TimeDisplay {
@@ -206,7 +210,7 @@ Rectangle {
 
         onWidthChanged: selectionRange.update();
 
-        onPropagateSelection: {
+        onPropagateSelection: (newModel, newItem) => {
             if (lockItemSelection || (newModel === selectedModel && newItem === selectedItem))
                 return;
 
diff --git a/src/libs/tracing/qml/Overview.qml b/src/libs/tracing/qml/Overview.qml
index d2b3eb29417..5152e4bc965 100644
--- a/src/libs/tracing/qml/Overview.qml
+++ b/src/libs/tracing/qml/Overview.qml
@@ -168,10 +168,10 @@ Rectangle {
             }
         }
 
-        onPressed: {
+        onPressed: (mouse) => {
             jumpTo(mouse.x);
         }
-        onPositionChanged: {
+        onPositionChanged: (mouse) => {
             jumpTo(mouse.x);
         }
     }
diff --git a/src/libs/tracing/qml/TimelineLabels.qml b/src/libs/tracing/qml/TimelineLabels.qml
index c675ce1b6d9..88fadfa6342 100644
--- a/src/libs/tracing/qml/TimelineLabels.qml
+++ b/src/libs/tracing/qml/TimelineLabels.qml
@@ -115,14 +115,14 @@ Flickable {
                             categories.selectItem(index, eventId)
                         }
 
-                        onSelectNextBySelectionId: {
+                        onSelectNextBySelectionId: (selectionId) => {
                             categories.selectItem(index, modelData.nextItemBySelectionId(
                                     selectionId, zoomer.rangeStart,
                                     categories.selectedModel === index ? categories.selectedItem :
                                                                          -1));
                         }
 
-                        onSelectPrevBySelectionId: {
+                        onSelectPrevBySelectionId: (selectionId) => {
                             categories.selectItem(index,  modelData.prevItemBySelectionId(
                                     selectionId, zoomer.rangeStart,
                                     categories.selectedModel === index ? categories.selectedItem :
diff --git a/src/libs/tracing/qml/TimelineRulers.qml b/src/libs/tracing/qml/TimelineRulers.qml
index 0e052e716ff..99c9d533a37 100644
--- a/src/libs/tracing/qml/TimelineRulers.qml
+++ b/src/libs/tracing/qml/TimelineRulers.qml
@@ -44,7 +44,7 @@ Item {
         anchors.right: parent.right
         height: scaleHeight
 
-        onClicked: {
+        onClicked: (mouse) => {
             rulersModel.append({
                 timestamp: (mouse.x + contentX) * viewTimePerPixel + windowStart
             });