feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Replace assignment of null QString() with a call to clear().

Browse Source 
Looks like it's a kind of rule in QtCreator code.

Change-Id: I92fb60055273d66d6e459245836df5b90d7a3cc6
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
This commit is contained in:
Jarek Kobus
2015-06-16 13:40:40 +02:00
parent 427170e504
commit f7c98fa6ab
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
share/qtcreator/qml/qmlpuppet/container/sharedmemory_unix.cpp
View File

@@ -339,7 +339,7 @@ bool SharedMemory::initKeyInternal()
return false; return false;
} }
m_errorString = QString(); m_errorString.clear();
m_error = QSharedMemory::NoError; m_error = QSharedMemory::NoError;
return true; return true;
} }

4
src/plugins/updateinfo/updateinfoplugin.cpp
View File

@@ -141,7 +141,7 @@ void UpdateInfoPlugin::stopCheckForUpdates()
if (!d->m_checkUpdatesCommand) if (!d->m_checkUpdatesCommand)
return; return;
d->m_collectedOutput = QString(); d->m_collectedOutput.clear();
d->m_checkUpdatesCommand->disconnect(); d->m_checkUpdatesCommand->disconnect();
d->m_checkUpdatesCommand->cancel(); d->m_checkUpdatesCommand->cancel();
d->m_checkUpdatesCommand = 0; d->m_checkUpdatesCommand = 0;
@@ -203,7 +203,7 @@ bool UpdateInfoPlugin::initialize(const QStringList & /* arguments */, QString *
if (!QFileInfo(d->m_maintenanceTool).isExecutable()) { if (!QFileInfo(d->m_maintenanceTool).isExecutable()) {
*errorMessage = tr("The maintenance tool at \"%1\" is not an executable. Check your installation.") *errorMessage = tr("The maintenance tool at \"%1\" is not an executable. Check your installation.")
.arg(d->m_maintenanceTool); .arg(d->m_maintenanceTool);
d->m_maintenanceTool = QString(); d->m_maintenanceTool.clear();
return false; return false;
} }