feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Add missing context pointer connect

Browse Source 
* Add missing context pointer in connect statement
* Fix console output "QFile::remove: Empty or null file name"

Task-number: QDS-6170
Change-Id: I31f671dc1422c6b90aff81252f4bc4cf2c34e7d1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Henning Gruendl
2022-02-17 10:14:20 +01:00
committed by Henning Gründl
parent 5d660d7afe
commit f7cbc513aa
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/studiowelcome/examplecheckout.cpp
View File

@@ -77,7 +77,8 @@ FileDownloader::FileDownloader(QObject *parent)
FileDownloader::~FileDownloader() FileDownloader::~FileDownloader()
{ {
m_tempFile.remove(); if (m_tempFile.exists())
m_tempFile.remove();
} }
void FileDownloader::start() void FileDownloader::start()
@@ -111,7 +112,8 @@ void FileDownloader::start()
QNetworkReply::connect(reply, &QNetworkReply::finished, this, [this, reply]() { QNetworkReply::connect(reply, &QNetworkReply::finished, this, [this, reply]() {
if (reply->error()) { if (reply->error()) {
m_tempFile.remove(); if (m_tempFile.exists())
m_tempFile.remove();
qDebug() << Q_FUNC_INFO << m_url << reply->errorString(); qDebug() << Q_FUNC_INFO << m_url << reply->errorString();
emit downloadFailed(); emit downloadFailed();
} else { } else {
@@ -411,7 +413,7 @@ void FileExtractor::extract()
emit detailedTextChanged(); emit detailedTextChanged();
}); });
QObject::connect(archive, &Utils::Archive::finished, [this](bool ret) { QObject::connect(archive, &Utils::Archive::finished, this, [this](bool ret) {
m_finished = ret; m_finished = ret;
m_timer.stop(); m_timer.stop();