Nim: Inline NimBuildInfo into nimbuildconfigurationfactory.cpp

It's only used there. Less code, less disk space.

This code is likely to be copied over and over into future language
plugins.
We cannot afford to spend 1 MB of disk space per build for every 12
lines
of trivial code, so remove this precedent.

Before:

1006824 ./.obj/debug-shared/nimbuildinfo.o
1509784 ./.obj/debug-shared/nimbuildconfigurationfactory.o

After:

1520840 ./.obj/debug-shared/nimbuildconfigurationfactory.o

Change-Id: I8e82b73e50595089d270e52b34cf8bd80ec7e965
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
hjk
2016-08-23 09:17:04 +02:00
committed by hjk
parent 2847e248e6
commit f7e7fc4e29
5 changed files with 16 additions and 97 deletions

View File

@@ -25,7 +25,6 @@
#include "nimbuildconfigurationfactory.h"
#include "nimbuildconfiguration.h"
#include "nimbuildinfo.h"
#include "nimcompilerbuildstep.h"
#include "nimcompilercleanstep.h"
#include "nimproject.h"
@@ -33,6 +32,7 @@
#include "../nimconstants.h"
#include <coreplugin/documentmanager.h>
#include <projectexplorer/buildconfiguration.h>
#include <projectexplorer/buildinfo.h>
#include <projectexplorer/buildsteplist.h>
#include <projectexplorer/buildstep.h>
@@ -49,6 +49,21 @@ using namespace Utils;
namespace Nim {
class NimBuildInfo : public BuildInfo
{
public:
NimBuildInfo(BuildConfiguration::BuildType buildType,
const NimBuildConfigurationFactory *factory)
: BuildInfo(factory), m_buildType(buildType)
{}
BuildConfiguration::BuildType buildType() const { return m_buildType; }
private:
BuildConfiguration::BuildType m_buildType;
};
NimBuildConfigurationFactory::NimBuildConfigurationFactory(QObject *parent)
: IBuildConfigurationFactory(parent)
{}