From f82692cc7f6285ea836a819191b4fcde91bef52d Mon Sep 17 00:00:00 2001 From: Bernhard Beschow Date: Fri, 1 Jan 2021 19:19:15 +0100 Subject: [PATCH] AutoTest: Make code more symmetric ... by assuming that active.keys() is a subset of TestFrameworkManager::registeredFrameworks() which is used in the case above. Also, TestFrameworkManager::registeredFrameworks() is already sorted, as can be seen from the above case, too. Change-Id: If82c8c998716fa56d6257d3ee0ec09c12d458bb1 Reviewed-by: Christian Stenger --- src/plugins/autotest/testtreemodel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/autotest/testtreemodel.cpp b/src/plugins/autotest/testtreemodel.cpp index 6f172cf2f3e..1b7a76ef8cf 100644 --- a/src/plugins/autotest/testtreemodel.cpp +++ b/src/plugins/autotest/testtreemodel.cpp @@ -316,10 +316,10 @@ void TestTreeModel::synchronizeTestFrameworks() } else { // we've got custom project settings const TestProjectSettings *settings = AutotestPlugin::projectSettings(project); const QHash active = settings->activeFrameworks(); - sorted = Utils::filtered(active.keys(), [active](ITestFramework *framework) { - return active.value(framework); + sorted = Utils::filtered(TestFrameworkManager::registeredFrameworks(), + [active](ITestFramework *framework) { + return active.value(framework, false); }); - Utils::sort(sorted, &ITestFramework::priority); } // pre-check to avoid further processing when frameworks are unchanged