feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Avoid overloading superclass method

Browse Source 
IOutputPane has an updateFilter method now, so rename the one in the
TODO output pane.

Change-Id: I0e6291372c83373b82d0d9911feffe032df8af5e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Eike Ziller
2019-06-17 09:42:12 +02:00
parent 09b9aa98a8
commit f841a9e462
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/todo/todooutputpane.cpp
View File

@@ -91,7 +91,7 @@ int TodoOutputPane::priorityInStatusBar() const
void TodoOutputPane::clearContents() void TodoOutputPane::clearContents()
{ {
clearFilter(); clearKeywordFilter();
} }
void TodoOutputPane::visibilityChanged(bool visible) void TodoOutputPane::visibilityChanged(bool visible)
@@ -190,7 +190,7 @@ void TodoOutputPane::updateTodoCount()
emit setBadgeNumber(m_todoTreeView->model()->rowCount()); emit setBadgeNumber(m_todoTreeView->model()->rowCount());
} }
void TodoOutputPane::updateFilter() void TodoOutputPane::updateKeywordFilter()
{ {
QStringList keywords; QStringList keywords;
for (const QToolButton *btn: qAsConst(m_filterButtons)) { for (const QToolButton *btn: qAsConst(m_filterButtons)) {
@@ -208,12 +208,12 @@ void TodoOutputPane::updateFilter()
updateTodoCount(); updateTodoCount();
} }
void TodoOutputPane::clearFilter() void TodoOutputPane::clearKeywordFilter()
{ {
for (QToolButton *btn: qAsConst(m_filterButtons)) for (QToolButton *btn: qAsConst(m_filterButtons))
btn->setChecked(false); btn->setChecked(false);
updateFilter(); updateKeywordFilter();
} }
void TodoOutputPane::createTreeView() void TodoOutputPane::createTreeView()
@@ -282,7 +282,7 @@ void TodoOutputPane::createScopeButtons()
QToolButton *button = createCheckableToolButton(keyword.name, tooltip.arg(keyword.name), toolBarIcon(keyword.iconType)); QToolButton *button = createCheckableToolButton(keyword.name, tooltip.arg(keyword.name), toolBarIcon(keyword.iconType));
button->setProperty(Constants::FILTER_KEYWORD_NAME, keyword.name); button->setProperty(Constants::FILTER_KEYWORD_NAME, keyword.name);
button->setToolButtonStyle(Qt::ToolButtonIconOnly); button->setToolButtonStyle(Qt::ToolButtonIconOnly);
connect(button, &QToolButton::clicked, this, &TodoOutputPane::updateFilter); connect(button, &QToolButton::clicked, this, &TodoOutputPane::updateKeywordFilter);
m_filterButtons.append(button); m_filterButtons.append(button);
} }

4
src/plugins/todo/todooutputpane.h
View File

@@ -80,8 +80,8 @@ private:
void scopeButtonClicked(QAbstractButton *button); void scopeButtonClicked(QAbstractButton *button);
void todoTreeViewClicked(const QModelIndex &index); void todoTreeViewClicked(const QModelIndex &index);
void updateTodoCount(); void updateTodoCount();
void updateFilter(); void updateKeywordFilter();
void clearFilter(); void clearKeywordFilter();
void createTreeView(); void createTreeView();
void freeTreeView(); void freeTreeView();