feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJS: Change from QMap to QHash for QString keys.

Browse Source 
Tests indicate that lookup in QHash<QString, ...> is more performant
even for short strings.

Change-Id: I8e5a73d0f1a72e202522f397b16901887f9c3591
Reviewed-on: http://codereview.qt-project.org/5070
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
This commit is contained in:
Christian Kamm
2011-09-16 10:35:48 +02:00
parent 3503731abd
commit f8462cca65
10 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmljstools/qmljsmodelmanager.cpp
View File

@@ -736,7 +736,7 @@ void ModelManager::startCppQmlTypeUpdate()
void ModelManager::updateCppQmlTypes(ModelManager *qmlModelManager,
CPlusPlus::CppModelManagerInterface *cppModelManager,
QMap<QString, QPair<CPlusPlus::Document::Ptr, bool> > documents)
QHash<QString, QPair<CPlusPlus::Document::Ptr, bool> > documents)
{
CppDataHash newData = qmlModelManager->cppData();
@@ -756,7 +756,7 @@ void ModelManager::updateCppQmlTypes(ModelManager *qmlModelManager,
finder(doc);
QList<LanguageUtils::FakeMetaObject::ConstPtr> exported = finder.exportedTypes();
QMap<QString, QString> contextProperties = finder.contextProperties();
QHash<QString, QString> contextProperties = finder.contextProperties();
if (exported.isEmpty() && contextProperties.isEmpty()) {
newData.remove(fileName);
} else {