feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ExtensionManager: Simplify ExtensionItemDelegate a bit

Browse Source 
Lifetime of m_itemWidget is the same as the delegate's. Also the
need to have it mutable now makes it clear that the widget is in
fact mutated.

Change-Id: Ia24d0787cbf43e7b02652f17e89baeb20c0fc079
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
hjk
2024-10-16 12:00:25 +02:00
parent 334cd28e07
commit f88ed762a0
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/extensionmanager/extensionsbrowser.cpp
View File

@@ -375,30 +375,23 @@ class ExtensionItemDelegate : public QItemDelegate
public: public:
explicit ExtensionItemDelegate(QObject *parent) explicit ExtensionItemDelegate(QObject *parent)
: QItemDelegate(parent) : QItemDelegate(parent)
{ {}
m_itemWidget = new ExtensionItemWidget;
}
~ExtensionItemDelegate()
{
delete m_itemWidget;
}
void paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) void paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index)
const override const override
{ {
m_itemWidget->paint(painter, option, index); m_itemWidget.paint(painter, option, index);
} }
QSize sizeHint([[maybe_unused]] const QStyleOptionViewItem &option, QSize sizeHint([[maybe_unused]] const QStyleOptionViewItem &option,
const QModelIndex &index) const override const QModelIndex &index) const override
{ {
m_itemWidget->setData(index); m_itemWidget.setData(index);
return {cellWidth, m_itemWidget->minimumSizeHint().height() + gapSize}; return {cellWidth, m_itemWidget.minimumSizeHint().height() + gapSize};
} }
private: private:
ExtensionItemWidget *m_itemWidget; mutable ExtensionItemWidget m_itemWidget;
}; };
class SortFilterProxyModel : public QSortFilterProxyModel class SortFilterProxyModel : public QSortFilterProxyModel