feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJS: Disable collection of semantic messages in 'Build Issues'.

Browse Source 
There are too many false positives when a project contains source code
for plugins and qml files using that plugin at the same time. It was
particularly bad for qtdeclarative itself.

Reviewed-by: Roberto Raggi
This commit is contained in:
Christian Kamm
2011-05-12 12:46:34 +02:00
parent 6aa24fd184
commit f8bcd6c615
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/plugins/qmljseditor/qmltaskmanager.cpp
View File

@@ -70,12 +70,13 @@ QmlTaskManager::QmlTaskManager(QObject *parent) :
} }
void QmlTaskManager::collectMessages(QFutureInterface<FileErrorMessages> &future, void QmlTaskManager::collectMessages(QFutureInterface<FileErrorMessages> &future,
Snapshot snapshot, QStringList files, QStringList importPaths) Snapshot snapshot, QStringList files, QStringList /*importPaths*/)
{ {
Interpreter::Context ctx(snapshot); // ### link and check error messages are disabled for now: too many false-positives!
QHash<QString, QList<DiagnosticMessage> > linkMessages; //Interpreter::Context ctx(snapshot);
Link link(&ctx, snapshot, importPaths); //QHash<QString, QList<DiagnosticMessage> > linkMessages;
link(&linkMessages); //Link link(&ctx, snapshot, importPaths);
//link(&linkMessages);
foreach (const QString &fileName, files) { foreach (const QString &fileName, files) {
Document::Ptr document = snapshot.document(fileName); Document::Ptr document = snapshot.document(fileName);
@@ -85,10 +86,11 @@ void QmlTaskManager::collectMessages(QFutureInterface<FileErrorMessages> &future
FileErrorMessages result; FileErrorMessages result;
result.fileName = fileName; result.fileName = fileName;
result.messages = document->diagnosticMessages(); result.messages = document->diagnosticMessages();
result.messages += linkMessages.value(fileName);
Check checker(document, &ctx); //result.messages += linkMessages.value(fileName);
result.messages.append(checker());
//Check checker(document, &ctx);
//result.messages.append(checker());
future.reportResult(result); future.reportResult(result);
if (future.isCanceled()) if (future.isCanceled())