From f8c3d860fcd3853201e715e2f0c8aa3799b018da Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 3 Aug 2022 12:02:04 +0300 Subject: [PATCH] Gerrit: Do not pass username to curl for REST requests It is set in .netrc anyway, and there is a regression in curl that causes it to fail when passing the user name. See https://github.com/curl/curl/issues/8653 Change-Id: Ic7aa2d874884db71f71d162486acf4e054eab7e9 Reviewed-by: hjk --- src/plugins/git/gerrit/gerritserver.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/git/gerrit/gerritserver.cpp b/src/plugins/git/gerrit/gerritserver.cpp index 7fc9ae4c7ef..9c891f457f3 100644 --- a/src/plugins/git/gerrit/gerritserver.cpp +++ b/src/plugins/git/gerrit/gerritserver.cpp @@ -120,7 +120,7 @@ QString GerritServer::url(UrlType urlType) const case Https: protocol = "https"; break; } QString res = protocol + "://"; - if (type == Ssh || urlType != DefaultUrl) + if (type == Ssh || urlType == UrlWithHttpUser) res += hostArgument(); else res += host;