feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SessionManager: Modernize code a bit

Browse Source 
Change-Id: I9e44990c62ccca8e06919576bb9be463bb84cf19
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2017-09-29 12:50:19 +02:00
parent db5a00231f
commit f8ded0df26
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/session.cpp
View File

@@ -711,11 +711,11 @@ void SessionManager::configureEditors(Project *project)
} }
} }
void SessionManager::removeProjects(QList<Project *> remove) void SessionManager::removeProjects(const QList<Project *> &remove)
{ {
QMap<QString, QStringList> resMap; QMap<QString, QStringList> resMap;
foreach (Project *pro, remove) for (Project *pro : remove)
emit m_instance->aboutToRemoveProject(pro); emit m_instance->aboutToRemoveProject(pro);
// Refresh dependencies // Refresh dependencies
@@ -738,12 +738,10 @@ void SessionManager::removeProjects(QList<Project *> remove)
} }
d->m_depMap = resMap; d->m_depMap = resMap;
// TODO: Clear m_modelProjectHash
bool changeStartupProject = false; bool changeStartupProject = false;
// Delete projects // Delete projects
foreach (Project *pro, remove) { for (Project *pro : remove) {
pro->saveSettings(); pro->saveSettings();
// Remove the project node: // Remove the project node:

2
src/plugins/projectexplorer/session.h
View File

@@ -78,7 +78,7 @@ public:
static void addProject(Project *project); static void addProject(Project *project);
static void removeProject(Project *project); static void removeProject(Project *project);
static void removeProjects(QList<Project *> remove); static void removeProjects(const QList<Project *> &remove);
static void setStartupProject(Project *startupProject); static void setStartupProject(Project *startupProject);