From f8e9592824a28b8f26e301af6a8a09e5702e243c Mon Sep 17 00:00:00 2001
From: Mahmoud Badri <mahmoud.badri@qt.io>
Date: Mon, 15 Jan 2024 14:44:38 +0200
Subject: [PATCH] QmlDesigner: Prevent saving an effect with invalid name using
 keyboard

Fixes: QDS-11605
Change-Id: Ice1cdc715c24534d045491ede3dbfc0c3e0cbe59
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
---
 .../qmldesigner/effectMakerQmlSources/SaveAsDialog.qml         | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/share/qtcreator/qmldesigner/effectMakerQmlSources/SaveAsDialog.qml b/share/qtcreator/qmldesigner/effectMakerQmlSources/SaveAsDialog.qml
index 8e762cebbd8..eef24116697 100644
--- a/share/qtcreator/qmldesigner/effectMakerQmlSources/SaveAsDialog.qml
+++ b/share/qtcreator/qmldesigner/effectMakerQmlSources/SaveAsDialog.qml
@@ -84,6 +84,9 @@ StudioControls.Dialog {
                 text: qsTr("Save")
                 enabled: nameText.text !== ""
                 onClicked: {
+                    if (!enabled) // needed since this event handler can be triggered from keyboard events
+                        return
+
                     EffectMakerBackend.effectMakerModel.saveComposition(nameText.text)
 
                     if (root.clearOnClose) {