From f91074297996e87cc5139b33e7f45e892a50e451 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Sun, 15 Nov 2015 16:52:28 +0200 Subject: [PATCH] Gerrit: Initialize all members dependeOnNumber and neededByNumber were not initialized. Change-Id: I12b90b842d540ae0e8ac9ff5be1be2ace2473ba8 Reviewed-by: Friedemann Kleint --- src/plugins/git/gerrit/gerritmodel.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/plugins/git/gerrit/gerritmodel.h b/src/plugins/git/gerrit/gerritmodel.h index c07d1ebe501..1c530ef07d9 100644 --- a/src/plugins/git/gerrit/gerritmodel.h +++ b/src/plugins/git/gerrit/gerritmodel.h @@ -71,16 +71,14 @@ public: class GerritChange { public: - GerritChange() : number(0), depth(-1) {} - bool isValid() const { return number && !url.isEmpty() && !project.isEmpty(); } QString filterString() const; QStringList gitFetchArguments(const QSharedPointer &p) const; QString url; - int number; - int dependsOnNumber; - int neededByNumber; + int number = 0; + int dependsOnNumber = 0; + int neededByNumber = 0; QString title; QString owner; QString email; @@ -89,7 +87,7 @@ public: QString status; QDateTime lastUpdated; GerritPatchSet currentPatchSet; - int depth; + int depth = -1; }; typedef QSharedPointer GerritChangePtr;