From 8c14daf980d15bd5614e38fe79e0a04404c2f536 Mon Sep 17 00:00:00 2001 From: Oswald Buddenhagen Date: Wed, 18 Feb 2009 10:32:02 +0100 Subject: [PATCH 1/2] do not create bizarre or even invalid fifo names under windows --- src/plugins/debugger/outputcollector.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/debugger/outputcollector.cpp b/src/plugins/debugger/outputcollector.cpp index f091ca92084..205ee91581b 100644 --- a/src/plugins/debugger/outputcollector.cpp +++ b/src/plugins/debugger/outputcollector.cpp @@ -80,7 +80,7 @@ bool OutputCollector::listen() return m_server->isListening(); m_server = new QLocalServer(this); connect(m_server, SIGNAL(newConnection()), SLOT(newConnectionAvailable())); - return m_server->listen(QLatin1String("creator-") + QCoreApplication::applicationPid()); // XXX how to make that secure? + return m_server->listen(QLatin1String("creator-%1").arg(QCoreApplication::applicationPid())); // XXX how to make that secure? #else if (!m_serverPath.isEmpty()) return true; From 1b32bf5b027bb62c38ddfaf67f9b7116e918862c Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Wed, 18 Feb 2009 11:00:25 +0100 Subject: [PATCH 2/2] Fixes: Show help as in standalone Designer (currentProperty). Task: 235520 Details: Use new integration API #ifdefed for 4.5.1 onwards. --- src/plugins/designer/formwindoweditor.cpp | 17 ++++++++++++++--- .../qt_private/qdesigner_integration_p.h | 2 ++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/plugins/designer/formwindoweditor.cpp b/src/plugins/designer/formwindoweditor.cpp index 869443a9aaf..a2fa85b5ca3 100644 --- a/src/plugins/designer/formwindoweditor.cpp +++ b/src/plugins/designer/formwindoweditor.cpp @@ -49,6 +49,7 @@ #include #include #include +#include #include #include @@ -330,9 +331,17 @@ void FormWindowEditor::activate() QString FormWindowEditor::contextHelpId() const { - // TODO [13.2.09]: Replace this by QDesignerIntegrations context help Id - // in the upcoming version of Qt - QDesignerFormEditorInterface *core = FormEditorW::instance()->designerEditor(); + const QDesignerFormEditorInterface *core = FormEditorW::instance()->designerEditor(); +#if QT_VERSION > 0x040500 + // Present from Qt 4.5.1 onwards. This will show the class documentation + // scrolled to the current property. + const qdesigner_internal::QDesignerIntegration *integration = + qobject_cast(core->integration()); + if (integration) + return integration->contextHelpId(); + return QString(); +#else + // Pre 4.5.1. This will show the class documentation. QObject *o = core->propertyEditor()->object(); if (!o) return QString(); @@ -347,5 +356,7 @@ QString FormWindowEditor::contextHelpId() const className = QLatin1String("QSpacerItem"); else if (className == QLatin1String("QLayoutWidget")) className = QLatin1String("QLayout"); + return className; +#endif } diff --git a/src/plugins/designer/qt_private/qdesigner_integration_p.h b/src/plugins/designer/qt_private/qdesigner_integration_p.h index b301a1ce827..d02da7b809e 100644 --- a/src/plugins/designer/qt_private/qdesigner_integration_p.h +++ b/src/plugins/designer/qt_private/qdesigner_integration_p.h @@ -95,6 +95,8 @@ public: bool isResourceEditingEnabled() const; bool isSlotNavigationEnabled() const; + QString contextHelpId() const; + protected: void setResourceFileWatcherBehaviour(ResourceFileWatcherBehaviour behaviour); // PromptAndReload by default