From f93da92893e1c3531fc19d077a8e513636363adc Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 18 Feb 2025 10:46:45 +0100 Subject: [PATCH] Utils: Fix toggling the "enabled" status ... of the first entry in a list of environment variables. Commit 727be63dacaff6a8327f2c74852a7d907f4ca7e3 changed an assertion from testing against end() to begin(), which was likely unintended. Task-number: QTCREATORBUG-32495 Change-Id: I7814018d914219b4aebff70ab4aa6f185dbfcff0 Reviewed-by: Marcus Tillmanns --- src/libs/utils/environmentmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/utils/environmentmodel.cpp b/src/libs/utils/environmentmodel.cpp index 9d5edb684fd..46681742158 100644 --- a/src/libs/utils/environmentmodel.cpp +++ b/src/libs/utils/environmentmodel.cpp @@ -356,7 +356,7 @@ void EnvironmentModel::toggleVariable(const QModelIndex &idx) { const QString name = indexToVariable(idx); const auto newIt = d->m_resultNameValueDictionary.find(name); - QTC_ASSERT(newIt != d->m_resultNameValueDictionary.begin(), return); + QTC_ASSERT(newIt != d->m_resultNameValueDictionary.end(), return); const auto op = newIt.enabled() ? EnvironmentItem::SetDisabled : EnvironmentItem::SetEnabled; const int changesPos = d->findInChanges(name); if (changesPos != -1) {