From f9993088022ebf994c0cac287bb88e7f503e8141 Mon Sep 17 00:00:00 2001
From: Miikka Heikkinen <miikka.heikkinen@qt.io>
Date: Mon, 17 Feb 2025 16:16:19 +0200
Subject: [PATCH] QmlDesigner: Fix NodeHint in PS builds

m_modelNode needs to be set also in project storage builds to
properly resolve hints.

Fixes: QDS-14763
Change-Id: I789d170f8904708e965a8beedaac79a3f56dae02
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
---
 .../qmldesigner/libs/designercore/metainfo/nodehints.cpp   | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/plugins/qmldesigner/libs/designercore/metainfo/nodehints.cpp b/src/plugins/qmldesigner/libs/designercore/metainfo/nodehints.cpp
index 5cbae6861fa..48ba12078ca 100644
--- a/src/plugins/qmldesigner/libs/designercore/metainfo/nodehints.cpp
+++ b/src/plugins/qmldesigner/libs/designercore/metainfo/nodehints.cpp
@@ -71,10 +71,9 @@ static QVariant evaluateExpression(const QString &expression, const ModelNode &m
 QmlDesigner::NodeHints::NodeHints(const ModelNode &node)
 #ifdef QDS_USE_PROJECTSTORAGE
     : NodeHints{node.metaInfo()}
-#else
-    : m_modelNode(node)
 #endif
 {
+    m_modelNode = node;
 #ifndef QDS_USE_PROJECTSTORAGE
 
     if (!isValid())
@@ -124,7 +123,7 @@ NodeHints::NodeHints(const ItemLibraryEntry &entry, [[maybe_unused]] Model *mode
 namespace {
 bool convert(FlagIs flagIs)
 {
-    return flagIs == FlagIs::True ? true : false;
+    return flagIs == FlagIs::True;
 }
 } // namespace
 
@@ -326,7 +325,7 @@ bool NodeHints::hideInNavigator() const
     if (!isValid())
         return false;
 
-    auto flagIs = m_modelNode.metaInfo().hideInNavigator();
+    auto flagIs = m_metaInfo.hideInNavigator();
 
     if (flagIs != FlagIs::Set)
         return convert(flagIs);