feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Editors: Remove useless parent widget argument from create/duplicate

Browse Source 
It was never called with a sensible value anyhow, and only complicates things.

Change-Id: I005848700b6c00114d91495670d4a0e15a2d2e64
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Eike Ziller
2014-01-07 14:41:57 +01:00
parent 236ea9efb9
commit f9ce335a6d
58 changed files with 100 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/genericprojectmanager/genericprojectfileseditor.cpp
View File

@@ -62,9 +62,9 @@ ProjectFilesFactory::ProjectFilesFactory(Manager *manager)
}
Core::IEditor *ProjectFilesFactory::createEditor(QWidget *parent)
Core::IEditor *ProjectFilesFactory::createEditor()
{
ProjectFilesEditorWidget *ed = new ProjectFilesEditorWidget(parent, this);
ProjectFilesEditorWidget *ed = new ProjectFilesEditorWidget(this);
TextEditorSettings::initializeEditor(ed);
return ed->editor();
}
@@ -91,11 +91,10 @@ bool ProjectFilesEditor::duplicateSupported() const
return true;
}
Core::IEditor *ProjectFilesEditor::duplicate(QWidget *parent)
Core::IEditor *ProjectFilesEditor::duplicate()
{
ProjectFilesEditorWidget *parentEditor = qobject_cast<ProjectFilesEditorWidget *>(editorWidget());
ProjectFilesEditorWidget *editor = new ProjectFilesEditorWidget(parent,
parentEditor->factory());
ProjectFilesEditorWidget *editor = new ProjectFilesEditorWidget(parentEditor->factory());
TextEditorSettings::initializeEditor(editor);
return editor->editor();
}
@@ -106,7 +105,7 @@ Core::IEditor *ProjectFilesEditor::duplicate(QWidget *parent)
//
////////////////////////////////////////////////////////////////////////////////////////
ProjectFilesEditorWidget::ProjectFilesEditorWidget(QWidget *parent, ProjectFilesFactory *factory)
ProjectFilesEditorWidget::ProjectFilesEditorWidget(ProjectFilesFactory *factory, QWidget *parent)
: BaseTextEditorWidget(parent),
m_factory(factory)
{

6
src/plugins/genericprojectmanager/genericprojectfileseditor.h
View File

@@ -50,7 +50,7 @@ class ProjectFilesFactory: public Core::IEditorFactory
public:
ProjectFilesFactory(Manager *manager);
Core::IEditor *createEditor(QWidget *parent);
Core::IEditor *createEditor();
};
class ProjectFilesEditor : public TextEditor::BaseTextEditor
@@ -62,7 +62,7 @@ public:
Core::Id id() const;
bool duplicateSupported() const;
Core::IEditor *duplicate(QWidget *parent);
Core::IEditor *duplicate();
};
class ProjectFilesEditorWidget : public TextEditor::BaseTextEditorWidget
@@ -70,7 +70,7 @@ class ProjectFilesEditorWidget : public TextEditor::BaseTextEditorWidget
Q_OBJECT
public:
ProjectFilesEditorWidget(QWidget *parent, ProjectFilesFactory *factory);
ProjectFilesEditorWidget(ProjectFilesFactory *factory, QWidget *parent = 0);
ProjectFilesFactory *factory() const;
TextEditor::BaseTextEditor *createEditor();