From f9f10a1e32dbdcad02d9c5064018b34c771fe3dd Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Wed, 14 Jun 2017 14:44:09 +0200 Subject: [PATCH] Clang: Fix conversion warning in tests mock-matchers.h:204:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] bool operator()(const A& a, const B& b) const { return a == b; } ~~^~~~ Change-Id: I58883118e1eb42f2e0129b760cdce07daf4ac8d3 Reviewed-by: Marco Bubke Reviewed-by: Ivan Donchevskii --- tests/unit/unittest/clangcompletecodejob-test.cpp | 3 ++- tests/unit/unittest/clangrequestreferencesjob-test.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/unit/unittest/clangcompletecodejob-test.cpp b/tests/unit/unittest/clangcompletecodejob-test.cpp index 635424c3188..0c5d3082190 100644 --- a/tests/unit/unittest/clangcompletecodejob-test.cpp +++ b/tests/unit/unittest/clangcompletecodejob-test.cpp @@ -79,7 +79,8 @@ TEST_F(CompleteCodeJob, ForwardTicketNumber) job.setContext(jobContextWithMockClient); job.prepareAsyncRun(); EXPECT_CALL(mockIpcClient, - codeCompleted(Property(&CodeCompletedMessage::ticketNumber, Eq(99)))) + codeCompleted(Property(&CodeCompletedMessage::ticketNumber, + Eq(jobRequest.ticketNumber)))) .Times(1); job.runAsync(); diff --git a/tests/unit/unittest/clangrequestreferencesjob-test.cpp b/tests/unit/unittest/clangrequestreferencesjob-test.cpp index 234d8258836..9105a660708 100644 --- a/tests/unit/unittest/clangrequestreferencesjob-test.cpp +++ b/tests/unit/unittest/clangrequestreferencesjob-test.cpp @@ -79,7 +79,7 @@ TEST_F(RequestReferencesJob, ForwardTicketNumber) job.setContext(jobContextWithMockClient); job.prepareAsyncRun(); EXPECT_CALL(mockIpcClient, - references(Property(&ReferencesMessage::ticketNumber, Eq(99)))) + references(Property(&ReferencesMessage::ticketNumber, Eq(jobRequest.ticketNumber)))) .Times(1); job.runAsync();