From fa011af1a06bca730a682e99fd50d8abe937b401 Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 16 Aug 2023 08:07:33 +0200 Subject: [PATCH] ProjectExplorer: Avoid early creation of KitManager This was only meant as part of a safety net, but in the case that the situation this was guarding against actually happens we'd also notice by simply not seeing the effect. This is not different to any other place in the code where we e.g. create objects/widgets/... and don't put them in the right container. Change-Id: I0700fd3ca235662b718cf01229211a4eebec8a9a Reviewed-by: Jarek Kobus Reviewed-by: --- src/plugins/projectexplorer/kitmanager.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/plugins/projectexplorer/kitmanager.cpp b/src/plugins/projectexplorer/kitmanager.cpp index 011e9ccc7db..989cd99e79d 100644 --- a/src/plugins/projectexplorer/kitmanager.cpp +++ b/src/plugins/projectexplorer/kitmanager.cpp @@ -651,13 +651,6 @@ void KitManager::completeKit(Kit *k) KitAspectFactory::KitAspectFactory() { kitAspectFactoriesStorage().addKitAspect(this); - - // Adding aspects created by this factory to possibly already existing kits is - // currently not needed here as kits are only created after all factories - // are created in *Plugin::initialize() or plugin load. - // Make sure we notice when this assumption breaks: - KitManager::instance(); // Ensure existence - QTC_CHECK(d->m_kitList.empty()); } KitAspectFactory::~KitAspectFactory()