feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Optimize ModelNode a little bit

Browse Source 
The functions are doing not much but are called often. So they are a
good case for inlining.

Change-Id: I755c63287d7d518b55d4f131077b98dd0345930c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2023-06-07 16:15:16 +02:00
parent 6f78cd1a3c
commit fa28c29781
2 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmldesigner/designercore/include/modelnode.h
View File

@@ -81,7 +81,7 @@ public:
ModelNode &operator=(const ModelNode &) = default; ModelNode &operator=(const ModelNode &) = default;
ModelNode(ModelNode &&) = default; ModelNode(ModelNode &&) = default;
ModelNode &operator=(ModelNode &&) noexcept = default; ModelNode &operator=(ModelNode &&) noexcept = default;
~ModelNode(); ~ModelNode() = default;
TypeName type() const; TypeName type() const;
QString simplifiedTypeName() const; QString simplifiedTypeName() const;
@@ -268,7 +268,7 @@ public:
} }
private: // functions private: // functions
Internal::InternalNodePointer internalNode() const; Internal::InternalNodePointer internalNode() const { return m_internalNode; }
bool hasLocked() const; bool hasLocked() const;

13
src/plugins/qmldesigner/designercore/model/modelnode.cpp
View File

@@ -66,10 +66,6 @@ ModelNode::ModelNode(const ModelNode &modelNode, AbstractView *view)
, m_view(view) , m_view(view)
{} {}
/*! \brief does nothing
*/
ModelNode::~ModelNode() = default;
/*! \brief returns the name of node which is a short cut to a property like objectName /*! \brief returns the name of node which is a short cut to a property like objectName
\return name of the node \return name of the node
*/ */
@@ -657,15 +653,6 @@ void ModelNode::destroy()
//\} //\}
/*! \name Property Manipulation
* This functions interact with properties.
*/
Internal::InternalNodePointer ModelNode::internalNode() const
{
return m_internalNode;
}
/*! /*!
\brief returns the model of the node \brief returns the model of the node
\return returns the model of the node \return returns the model of the node