From fa57e933a9763593eaf403c2a40038cb59903f4b Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 19 Jun 2019 08:43:49 +0200 Subject: [PATCH] ProjectExplorer: Remove MsvcToolChainFactory::create() This was doing effectively the same as the base constructor with all code paths overriding the values set here. Change-Id: I41e29bc5ae5ef7d99ff4adc7beed738c49a3139f Reviewed-by: David Schulz --- src/plugins/projectexplorer/msvctoolchain.cpp | 7 ------- src/plugins/projectexplorer/msvctoolchain.h | 1 - 2 files changed, 8 deletions(-) diff --git a/src/plugins/projectexplorer/msvctoolchain.cpp b/src/plugins/projectexplorer/msvctoolchain.cpp index cf927acbe35..060334382a6 100644 --- a/src/plugins/projectexplorer/msvctoolchain.cpp +++ b/src/plugins/projectexplorer/msvctoolchain.cpp @@ -2122,13 +2122,6 @@ bool MsvcToolChainFactory::canCreate() const return !g_availableMsvcToolchains.isEmpty(); } -ToolChain *MsvcToolChainFactory::create() -{ - auto tc = new MsvcToolChain(Constants::MSVC_TOOLCHAIN_TYPEID); - tc->setupVarsBat(Abi::hostAbi(), g_availableMsvcToolchains.first()->varsBat(), ""); - return tc; -} - MsvcToolChain::WarningFlagAdder::WarningFlagAdder(const QString &flag, WarningFlags &flags) : m_flags(flags) { diff --git a/src/plugins/projectexplorer/msvctoolchain.h b/src/plugins/projectexplorer/msvctoolchain.h index d540ed79331..3bc92241e46 100644 --- a/src/plugins/projectexplorer/msvctoolchain.h +++ b/src/plugins/projectexplorer/msvctoolchain.h @@ -210,7 +210,6 @@ public: QList autoDetect(const QList &alreadyKnown) override; bool canCreate() const override; - ToolChain *create() override; static QString vcVarsBatFor(const QString &basePath, MsvcToolChain::Platform platform,