feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Use some initializer lists when appropriate

Browse Source 
Change-Id: Ic1988a3a046bf5a4c262d1e648376f077ed97448
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
hjk
2015-03-19 00:59:04 +01:00
parent 384437e994
commit fa704e0b84
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/valgrind/memchecktool.cpp
View File

@@ -177,13 +177,10 @@ bool MemcheckErrorFilterProxyModel::filterAcceptsRow(int sourceRow, const QModel
return true;
}
static void initKindFilterAction(QAction *action, const QList<int> &kinds)
static void initKindFilterAction(QAction *action, const QVariantList &kinds)
{
action->setCheckable(true);
QVariantList data;
foreach (int kind, kinds)
data << kind;
action->setData(data);
action->setData(kinds);
}
MemcheckTool::MemcheckTool(QObject *parent)
@@ -208,21 +205,21 @@ MemcheckTool::MemcheckTool(QObject *parent)
tr("These suppression files were used in the last memory analyzer run."));
QAction *a = new QAction(tr("Definite Memory Leaks"), this);
initKindFilterAction(a, QList<int>() << Leak_DefinitelyLost << Leak_IndirectlyLost);
initKindFilterAction(a, { Leak_DefinitelyLost, Leak_IndirectlyLost });
m_errorFilterActions.append(a);
a = new QAction(tr("Possible Memory Leaks"), this);
initKindFilterAction(a, QList<int>() << Leak_PossiblyLost << Leak_StillReachable);
initKindFilterAction(a, { Leak_PossiblyLost, Leak_StillReachable });
m_errorFilterActions.append(a);
a = new QAction(tr("Use of Uninitialized Memory"), this);
initKindFilterAction(a, QList<int>() << InvalidRead << InvalidWrite << InvalidJump << Overlap
<< InvalidMemPool << UninitCondition << UninitValue
<< SyscallParam << ClientCheck);
initKindFilterAction(a, { InvalidRead, InvalidWrite, InvalidJump, Overlap,
InvalidMemPool, UninitCondition, UninitValue,
SyscallParam, ClientCheck });
m_errorFilterActions.append(a);
a = new QAction(tr("Invalid Calls to \"free()\""), this);
initKindFilterAction(a, QList<int>() << InvalidFree << MismatchedFree);
initKindFilterAction(a, { InvalidFree, MismatchedFree });
m_errorFilterActions.append(a);
}