forked from qt-creator/qt-creator
C++: Don't show unused mark for known RAII types
Change-Id: Id552539c6a2cf5d7558adf88bed61a11ab770516 Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
This commit is contained in:
@@ -32,9 +32,17 @@
|
||||
|
||||
#include "cpptoolsreuse.h"
|
||||
|
||||
#include <Symbols.h>
|
||||
#include <CoreTypes.h>
|
||||
#include <cplusplus/Overview.h>
|
||||
#include <cplusplus/LookupContext.h>
|
||||
|
||||
#include <QtCore/QSet>
|
||||
#include <QtGui/QTextDocument>
|
||||
#include <QtGui/QTextCursor>
|
||||
|
||||
using namespace CPlusPlus;
|
||||
|
||||
namespace CppTools {
|
||||
|
||||
void moveCursorToEndOfIdentifier(QTextCursor *tc) {
|
||||
@@ -49,4 +57,50 @@ void moveCursorToEndOfIdentifier(QTextCursor *tc) {
|
||||
}
|
||||
}
|
||||
|
||||
static bool isOwnershipRAIIName(const QString &name)
|
||||
{
|
||||
static QSet<QString> knownNames;
|
||||
if (knownNames.isEmpty()) {
|
||||
// Qt
|
||||
knownNames.insert(QLatin1String("QScopedPointer"));
|
||||
knownNames.insert(QLatin1String("QScopedArrayPointer"));
|
||||
knownNames.insert(QLatin1String("QMutexLocker"));
|
||||
knownNames.insert(QLatin1String("QReadLocker"));
|
||||
knownNames.insert(QLatin1String("QWriteLocker"));
|
||||
// Standard C++
|
||||
knownNames.insert(QLatin1String("auto_ptr"));
|
||||
knownNames.insert(QLatin1String("unique_ptr"));
|
||||
// Boost
|
||||
knownNames.insert(QLatin1String("scoped_ptr"));
|
||||
knownNames.insert(QLatin1String("scoped_array"));
|
||||
}
|
||||
|
||||
return knownNames.contains(name);
|
||||
}
|
||||
|
||||
bool isOwnershipRAIIType(CPlusPlus::Symbol *symbol, const LookupContext &context)
|
||||
{
|
||||
if (!symbol)
|
||||
return false;
|
||||
|
||||
// This is not a "real" comparison of types. What we do is to resolve the symbol
|
||||
// in question and then try to match its name with already known ones.
|
||||
if (symbol->isDeclaration()) {
|
||||
Declaration *declaration = symbol->asDeclaration();
|
||||
const NamedType *namedType = declaration->type()->asNamedType();
|
||||
if (namedType) {
|
||||
ClassOrNamespace *clazz = context.lookupType(namedType->name(),
|
||||
declaration->enclosingScope());
|
||||
if (clazz && !clazz->symbols().isEmpty()) {
|
||||
Overview overview;
|
||||
Symbol *symbol = clazz->symbols().at(0);
|
||||
return isOwnershipRAIIName(overview.prettyName(symbol->name()));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
|
||||
} // CppTools
|
||||
|
||||
@@ -37,10 +37,18 @@
|
||||
|
||||
QT_FORWARD_DECLARE_CLASS(QTextCursor)
|
||||
|
||||
namespace CPlusPlus {
|
||||
class Symbol;
|
||||
class LookupContext;
|
||||
}
|
||||
|
||||
namespace CppTools {
|
||||
|
||||
void CPPTOOLS_EXPORT moveCursorToEndOfIdentifier(QTextCursor *tc);
|
||||
|
||||
bool CPPTOOLS_EXPORT isOwnershipRAIIType(CPlusPlus::Symbol *symbol,
|
||||
const CPlusPlus::LookupContext &context);
|
||||
|
||||
} // CppTools
|
||||
|
||||
#endif // CPPTOOLSREUSE_H
|
||||
|
||||
Reference in New Issue
Block a user