feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Minor optimizations in DocumentModel

Browse Source 
Required for followup changes

Change-Id: I6280427433bd88fedf87e4d8d25c2f7481d94210
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Orgad Shaneh
2015-02-23 10:15:53 +02:00
committed by Orgad Shaneh
parent fb567a224d
commit fa9deea671
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/coreplugin/editormanager/documentmodel.cpp
View File

@@ -190,8 +190,10 @@ DocumentModel::Entry *DocumentModel::firstRestoredEntry()
void DocumentModelPrivate::addEntry(DocumentModel::Entry *entry) void DocumentModelPrivate::addEntry(DocumentModel::Entry *entry)
{ {
const Utils::FileName fileName = entry->fileName();
// replace a non-loaded entry (aka 'restored') if possible // replace a non-loaded entry (aka 'restored') if possible
int previousIndex = indexOfFilePath(entry->fileName()); int previousIndex = indexOfFilePath(fileName);
if (previousIndex >= 0) { if (previousIndex >= 0) {
if (entry->document && m_entries.at(previousIndex)->document == 0) { if (entry->document && m_entries.at(previousIndex)->document == 0) {
DocumentModel::Entry *previousEntry = m_entries.at(previousIndex); DocumentModel::Entry *previousEntry = m_entries.at(previousIndex);
@@ -265,13 +267,13 @@ void DocumentModelPrivate::removeDocument(int idx)
if (idx < 0) if (idx < 0)
return; return;
QTC_ASSERT(idx < d->m_entries.size(), return); QTC_ASSERT(idx < d->m_entries.size(), return);
IDocument *document = d->m_entries.at(idx)->document;
int row = idx + 1/*<no document>*/; int row = idx + 1/*<no document>*/;
beginRemoveRows(QModelIndex(), row, row); beginRemoveRows(QModelIndex(), row, row);
delete d->m_entries.takeAt(idx); DocumentModel::Entry *entry = d->m_entries.takeAt(idx);
endRemoveRows(); endRemoveRows();
if (document) if (IDocument *document = entry->document)
disconnect(document, SIGNAL(changed()), this, SLOT(itemChanged())); disconnect(document, SIGNAL(changed()), this, SLOT(itemChanged()));
delete entry;
} }
void DocumentModel::removeAllRestoredEntries() void DocumentModel::removeAllRestoredEntries()