feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Move IEditor::createNew to IDocument::setContents

Browse Source 
The method is for setting the contents, so it belongs to the document,
and should be named correspondingly.

Change-Id: I40363dc08f11268f530885b512e4a88e8b10d096
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Eike Ziller
2013-07-15 15:14:10 +02:00
parent 0ba2b9b37d
commit fade19a9bf
42 changed files with 194 additions and 191 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/vcsbase/vcsbasesubmiteditor.cpp
View File

@@ -349,12 +349,6 @@ void VcsBaseSubmitEditor::slotDescriptionChanged()
{
}
bool VcsBaseSubmitEditor::createNew(const QString &contents)
{
setFileContents(contents);
return true;
}
bool VcsBaseSubmitEditor::open(QString *errorString, const QString &fileName, const QString &realFileName)
{
if (fileName.isEmpty())
@@ -365,7 +359,7 @@ bool VcsBaseSubmitEditor::open(QString *errorString, const QString &fileName, co
return false;
const QString text = QString::fromLocal8Bit(reader.data());
if (!createNew(text))
if (!setFileContents(text.toUtf8()))
return false;
d->m_file->setFilePath(QFileInfo(fileName).absoluteFilePath());
@@ -518,9 +512,9 @@ QByteArray VcsBaseSubmitEditor::fileContents() const
return d->m_widget->descriptionText().toLocal8Bit();
}
bool VcsBaseSubmitEditor::setFileContents(const QString &contents)
bool VcsBaseSubmitEditor::setFileContents(const QByteArray &contents)
{
d->m_widget->setDescriptionText(contents);
d->m_widget->setDescriptionText(QString::fromUtf8(contents));
return true;
}